From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F52C433DB for ; Wed, 17 Feb 2021 08:13:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04AD564DFF for ; Wed, 17 Feb 2021 08:13:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04AD564DFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mzYJ1J1xGoFiaE9w/CSNCy0vDnKRNVeoboYoETOZIOQ=; b=COmLRvUBI+BykO9bHxR+PDXwv JJskHl2Z6oT6qHEyiShIo/0w64QU8vEWWIF5ief0kN3aWp4OLu0sY3YpxTCHA6GDQp7sru8pId9wx nOPG4/8fjJR1tOfMLQ+ANGVc7js8woeg7rEzDZiJIJ/cL1a7riK04+ESB0XnwgIyM/25nnGYT0K+f j0QGKlph5EXcM+7SijvKdigqRa6OyRWj9n89WzSnquDTHcgtFat6tpkrke8uaBSaB4OBrYbSG0ZFe jAs7xlppPuoaNFEMdKmuI1mp92limUhmf/7OPavkOXontusjjenEaTKfIOqeCsEuLOFfj+71tHnNM Aj0VBqcew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCHum-0001qU-LQ; Wed, 17 Feb 2021 08:10:28 +0000 Received: from mail-wr1-f53.google.com ([209.85.221.53]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCHsG-0000Rr-Tw for linux-arm-kernel@lists.infradead.org; Wed, 17 Feb 2021 08:07:54 +0000 Received: by mail-wr1-f53.google.com with SMTP id v1so16345954wrd.6 for ; Wed, 17 Feb 2021 00:07:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U+fDZ975xL8Hj6o7r3HYdRzIxYB9Qn2UcitDVPde2lk=; b=VrTbc6qaaVL6po/zjttm/XAzLuWr9qtW+R3HIszY0mtEUVm8WacHZUhGC1Yb3momoE E9fLN+Q5lIlx3fC8r8wUF6vRC4cXmberQt91euEisAq1Jk+7Qy2JLDNTYBC/0Znu2DPh D+W+HSGH63vFnDWs1RLvd+VizdbuWorl2goz2QOw8rpPXrgKZNGri3K68wGkGT8YcoVY YnKZkZyW/fhF4SU1eeXto3Vwb95zrOIjZ/XvChUbGghjPHjb+3/oXnAFCbfW/8yp038J bp+E64nibjvWgdV9SbIe+fbwgAVsmuK85fN12OzJ6aYGEc8kl74smT8reMQx4arWIQmg um6Q== X-Gm-Message-State: AOAM533fv6araeE+B4GLKkKQI1DsOTWZdraePA3+2qFf+0IcxjTkJxd5 G+jPnJfWaZdUBDfQTQu7QB4= X-Google-Smtp-Source: ABdhPJwNT+lcJ8Ykcqd/E88u6ALDtw/JWkUv3IEXbdQLstE1LEVNDwPI3r2r7w5nhQbEelsQ5+QVYw== X-Received: by 2002:adf:cf06:: with SMTP id o6mr27655581wrj.169.1613549269872; Wed, 17 Feb 2021 00:07:49 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id y6sm1847778wma.10.2021.02.17.00.07.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 00:07:48 -0800 (PST) Date: Wed, 17 Feb 2021 09:07:47 +0100 From: Krzysztof Kozlowski To: Marten Lindahl Subject: Re: [PATCH] i2c: exynos5: Preserve high speed master code Message-ID: <20210217080747.a7nqzbotszwlb3dd@kozik-lap> References: <20210215190322.22094-1-marten.lindahl@axis.com> <20210216075141.o4wjnwmmjze2p3cn@kozik-lap> <20210216220933.2wzmft72bhjptzl3@axis.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210216220933.2wzmft72bhjptzl3@axis.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210217_030753_051011_28A59FBC X-CRM114-Status: GOOD ( 15.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, kernel@axis.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 16, 2021 at 11:09:33PM +0100, Marten Lindahl wrote: > > Any reason why not "|= MASTER_ID(i2c->adap.nr)" here instead of more > > expensive IO read? It's quite important because your current code will > > bitwise-or old I2C slave address with a new one... This should break > > during tests with multiple I2C slave devices, shouldn't it? > > > > You are correct. It is better to use the macro instead, and yes, > safer too. I only have one device that supports high speed i2c, but > I get your point. It could potentially break. > > > On which HW did you test it? > > I used an Artpec development board as master and INA230EVM board > as slave. Artpec development board with? What SoC? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel