From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C29BCC433E0 for ; Wed, 17 Feb 2021 08:33:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61A6764E2E for ; Wed, 17 Feb 2021 08:33:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61A6764E2E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=axis.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NPc1bKUNbO1tjQsmdGJavICCzO6PCugi/X6UADRBTAk=; b=wcysFyvWBtTp/XlCUJ5qFdCUA XNg15p3A+31fJNY7iO/huY5Lf/rbDID4wSlbEGuj0o/XjZShQKdkyReHxaEGEn2DKUKCfT6ayo6EZ KnM0277giWCNhrJhIRlnEERDjyfp8f8ydV4VSqbpXrWIxHX4c5GTzHJib2XyQoR82QFvIEBJmNdcb UkgCpHIuDBS94xgud1zcHZTGjrzokHtoNL3vGCUTZs4I9g6Q9cyiJum2/QcjDp+Jiq1/MvtLlRyND E8Xlu1Gu1SkoKVRznw+RHwlRFpaUv38H0HSjdl95u/M1QII297PNH/YNsWgdVXVG7/j5HVkMMj2G3 zM7qN+crg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCIFu-0005C3-Fs; Wed, 17 Feb 2021 08:32:18 +0000 Received: from smtp1.axis.com ([195.60.68.17]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCIFr-0005BR-U0 for linux-arm-kernel@lists.infradead.org; Wed, 17 Feb 2021 08:32:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1613550736; x=1645086736; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=F8vZxAEmte+jbew9PFlKUPYh3emsMfZMkNAme23J2xE=; b=Y76pcXQ9RwKE5gt3H4WBFGrWQ/hJI4bOhQvXzF0cm8LRL/h7s1W5d/U5 v6CCivVw9mi73tSFl2AHFtojbCXegdiyKwQq+VRVxFaWiJaPc+Ts2Kom+ wgvW1r9HAdtV6AEx2FKj9DybrQnV3QgGdKQAFULeKSdlqx3AxmhEjmool bRx4ABSs3aRWxioGSJluv12kWJYCI9PoN+Jfyu1SjT7m4w6gjD3xW93R2 Xwua8VpW4BHFdNZhuqXFf6vFcLpAYugt8ymp3eEM3M2YLHGt1g0EnxHj2 nSxpRJcX0y/KNieB/1VEg+9LU/UTGB9J3g975SpHgaNuPFHytGvnTJbeo w==; Date: Wed, 17 Feb 2021 09:32:11 +0100 From: Jesper Nilsson To: Krzysztof Kozlowski Subject: Re: [PATCH] i2c: exynos5: Preserve high speed master code Message-ID: <20210217083211.GN30470@axis.com> References: <20210215190322.22094-1-marten.lindahl@axis.com> <20210216075141.o4wjnwmmjze2p3cn@kozik-lap> <20210216220933.2wzmft72bhjptzl3@axis.com> <20210217080747.a7nqzbotszwlb3dd@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210217080747.a7nqzbotszwlb3dd@kozik-lap> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210217_033216_240793_46A00354 X-CRM114-Status: GOOD ( 15.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-samsung-soc@vger.kernel.org" , =?iso-8859-1?Q?M=E5rten?= Lindahl , "linux-kernel@vger.kernel.org" , kernel , "linux-i2c@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 17, 2021 at 09:07:47AM +0100, Krzysztof Kozlowski wrote: > On Tue, Feb 16, 2021 at 11:09:33PM +0100, Marten Lindahl wrote: > > > Any reason why not "|= MASTER_ID(i2c->adap.nr)" here instead of more > > > expensive IO read? It's quite important because your current code will > > > bitwise-or old I2C slave address with a new one... This should break > > > during tests with multiple I2C slave devices, shouldn't it? > > > > > > > You are correct. It is better to use the macro instead, and yes, > > safer too. I only have one device that supports high speed i2c, but > > I get your point. It could potentially break. > > > > > On which HW did you test it? > > > > I used an Artpec development board as master and INA230EVM board > > as slave. > > Artpec development board with? What SoC? The ARTPEC-line of SoC:s are Axis Communications own ASICs, in the latest iteration it's a Cortex-53 and includes instances of the exynos5 HSI2C ip. > Best regards, > Krzysztof /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel