From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B13C9C433DB for ; Wed, 17 Feb 2021 08:46:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AA0564DE0 for ; Wed, 17 Feb 2021 08:46:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AA0564DE0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5/OwcgDTZnPmxxNyd7YfU0PG5T6JwEcZRWioIff4Scc=; b=GAFn5+vN7hmjGYx2RiCbcqmYQ JHdgCX5ExpXHeO/4iTM3Oy3OzvCi4/NFkAeQKW+0hVcaJMcsszMA0Uw1D4TPCoQHya+8h2N2ulCwy rHraDvONeFoxsXyX6/SvDrTI52sr67SaD/AgyKYxZREIQ3GXlJvvm4K739/gBYTPI7QtlD2huGNRm Ey+0srLLBt8anXqtyJC9TEFiLUDqGC6IYH3PosNXPinvmYPucI4ZsqqzlmTFRuqxpyVvYSwn5Z6dG 3uogKL75WrnnC/yhtrc1pJu9JwSJLw+0aHAX5oTKbSNnatAUGnKfxE11I7RasiUBki/hzzJonaUl3 59Ze7sdkA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCIR2-0006UP-02; Wed, 17 Feb 2021 08:43:48 +0000 Received: from mail-wm1-f43.google.com ([209.85.128.43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCIQz-0006Tu-UC for linux-arm-kernel@lists.infradead.org; Wed, 17 Feb 2021 08:43:46 +0000 Received: by mail-wm1-f43.google.com with SMTP id v62so2524707wmg.4 for ; Wed, 17 Feb 2021 00:43:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HM9Ed9VK7QFCdL2LC2Q7uP7A/EnIqoKacM0+9fsn0yQ=; b=JwUvJY/CjJYo3EDiYPRN7+ElB6en1yVU7gzNS9NEmAxtOXIv93ElA1j4eGaXbThfOG ZU6DnI/NbB2xa4PARn3yUA3Wo6IV6bpq1yVh6ooXpdchME6398Ypc47iZT7QnSQlre5P rXU0xzSqNNG3KeLtIR6QYnb3hildQrU65xdihDzGMSzBCi5H4J+eP8crm7HssaqE8XAo UGLz8EKqNgKCeTXqscO5NBZ1NK+aBgVy13KubXKdIBcpe6vGRyDevibWBaYqMixXSNFK +5F2aEQA6XdGg6eI+iJJrSxod5UZFHRMGwgwoD79exsK5HV9kNIgnDaEsWh0031GDjS4 uxqQ== X-Gm-Message-State: AOAM531N/QWLnV+G0+wRLGXnR3PxZTnFi10CU1oqh1fdlCFAoTxztyF0 hd91RMd6u/Xs5L64VJzqXeO91asB3GE= X-Google-Smtp-Source: ABdhPJxA34OFeXKV76dkYXxsHjLutRVnhz+BPRwZ1RWJzc9Pq0sAW49JabygCXoUJ5sMkgRGXRM9lg== X-Received: by 2002:a05:600c:414b:: with SMTP id h11mr6149605wmm.125.1613551424165; Wed, 17 Feb 2021 00:43:44 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id q140sm2707349wme.0.2021.02.17.00.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 00:43:43 -0800 (PST) Date: Wed, 17 Feb 2021 09:43:42 +0100 From: Krzysztof Kozlowski To: Jesper Nilsson Subject: Re: [PATCH] i2c: exynos5: Preserve high speed master code Message-ID: <20210217084342.wqtrdeisfs5gb7wq@kozik-lap> References: <20210215190322.22094-1-marten.lindahl@axis.com> <20210216075141.o4wjnwmmjze2p3cn@kozik-lap> <20210216220933.2wzmft72bhjptzl3@axis.com> <20210217080747.a7nqzbotszwlb3dd@kozik-lap> <20210217083211.GN30470@axis.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210217083211.GN30470@axis.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210217_034345_989269_9CEFBB90 X-CRM114-Status: GOOD ( 19.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-samsung-soc@vger.kernel.org" , =?utf-8?Q?M=C3=A5rten?= Lindahl , "linux-kernel@vger.kernel.org" , kernel , "linux-i2c@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 17, 2021 at 09:32:11AM +0100, Jesper Nilsson wrote: > On Wed, Feb 17, 2021 at 09:07:47AM +0100, Krzysztof Kozlowski wrote: > > On Tue, Feb 16, 2021 at 11:09:33PM +0100, Marten Lindahl wrote: > > > > Any reason why not "|= MASTER_ID(i2c->adap.nr)" here instead of more > > > > expensive IO read? It's quite important because your current code will > > > > bitwise-or old I2C slave address with a new one... This should break > > > > during tests with multiple I2C slave devices, shouldn't it? > > > > > > > > > > You are correct. It is better to use the macro instead, and yes, > > > safer too. I only have one device that supports high speed i2c, but > > > I get your point. It could potentially break. > > > > > > > On which HW did you test it? > > > > > > I used an Artpec development board as master and INA230EVM board > > > as slave. > > > > Artpec development board with? What SoC? > > The ARTPEC-line of SoC:s are Axis Communications own ASICs, in the latest iteration > it's a Cortex-53 and includes instances of the exynos5 HSI2C ip. Cool! Good to see that this code is re-used. :) Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel