From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2885C433E6 for ; Wed, 17 Feb 2021 16:29:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7ED0764DFF for ; Wed, 17 Feb 2021 16:29:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7ED0764DFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f2CC1Wdx/+WZaNyASDKh7N9fM0OvMS95GgLCu7vQByk=; b=EbBtzzdrLeTYcIxDYOi7E+Euu SPGrgMvfvht/1SYpa/O6U7n005ljyswPO7a6IsGL/3mYATFFoL1Vr+WFGdLqkyBnq6109mw7nl8Gu dnP8VWN/mgMC4FqkPDns/P3H2ina8sQLkQYnD27/anvGrxrWBYKzi4k0SkaQa9T+Hr2geyEyBw/Kq WCYp4Hn/pBQVlFohKsInXXlcj8za6oMB0sl7frJDVrHXHwft3JmA9vT0KKJnEjqUtpg02n1D13keY RDOXrPuGKUtlIarQmWp85IYAZzC2ac16scs/vJMI4bFsE4oE3pgUuqLq+U4k4pFlMXgTOtpcJnxd2 grfrB/LeA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCPfh-0005Xv-Ma; Wed, 17 Feb 2021 16:27:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCPff-0005Wy-BU for linux-arm-kernel@lists.infradead.org; Wed, 17 Feb 2021 16:27:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3F06664DFF; Wed, 17 Feb 2021 16:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613579242; bh=48uDl0cK0TcRMhfYwNZd76eaGCNym7qStjlm6Y7QXUE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QqS/LrquQEMaM4nTE53Kk8otC9u21gFaxqJITH/nSi+v+enHLlG986bZwBtnlkSUV HaT3Ag+fVD9dziO6hqWHbg5xwkJRyJKgo6cU5MTXuMkK3st8fByRFwRm+pXhSQzRgb dJ1hwG+QIfDmnsepmOrArDgNgDEN7z2Rm6ydWJ+9pJMZzbRINn/qCge10PfLgKBfkr /v0t1qZ4AfDvUSA2SQ9u0B4jdLDlkI36HufliVWGqWFpLHrT26r0uyN8zIuOw+sf5+ OYA4uQEzgBX+NmFv7bqR/yZ65vMo92gFnnf0vx1D3oRCPz7nI8Rsfcs1UvOOPjxGAA qzpC6k2aWAO/A== Date: Wed, 17 Feb 2021 17:27:18 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Andrew Lunn Subject: Re: [PATCH] ARM: dts: turris-omnia: fix hardware buffer management Message-ID: <20210217172718.6fdf412e@kernel.org> In-Reply-To: References: <20210217153038.1068170-1-rsalvaterra@gmail.com> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210217_112723_504279_359AD1C3 X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, gregory.clement@bootlin.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rui Salvaterra Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 17 Feb 2021 17:22:17 +0100 Andrew Lunn wrote: > On Wed, Feb 17, 2021 at 03:30:38PM +0000, Rui Salvaterra wrote: > > Hardware buffer management has never worked on the Turris Omnia, as the > > required MBus window hadn't been reserved. Fix thusly. > > Hi Rui > > I don't know all the details for the MBus Windows... > > Can this be set once in armada-385.dtsi ? > > Did you check the other dts files. Do any others have the same > problem? > > Andrew armada-38x.dtsi defines only ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>; for internal-regs. It probably depends on how the mbus driver works. If the mbus driver maps every window defined in ranges, regardless whether they are used, then we do not want to put all windows in .dtsi file. Marek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel