From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 309B8C433E0 for ; Thu, 18 Feb 2021 07:32:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6D3E64DDA for ; Thu, 18 Feb 2021 07:32:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6D3E64DDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ma1LTEvnsSoKBspmuovm5sOLI6zYXwVC33mICJ7Z+zY=; b=WMlOCnHiw9hzk/+ydZRLg62/n o4fh15PF7pdolF3r0lE2HIsBN20kjyN5zANjigk0Y7CrNUogyxKffzOsDypM6pXtRHBoZyKMBSE9Q 6oI8HC+7te7gtASMVi2qqiJrAtzNEVCE0q/bSdDWoKA/q7lcYezgVb48gPtXe39Hz3quub4OJ2aAZ t5aZvVpjajFJzxDMeBdVQETCiL7jqxQjz8vAlTRBhg293mlsAdt4lhCnBmlRc0u128Laf/pFqjutG 3igWv8vSlkthKd+a3uCxXVvQsu5k7iBCnb85H07SLpDAmws5rLCmsS3jHpBl8zuYJNldnq5HCA4T5 o6S3AWDrQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCdmU-0002Uz-15; Thu, 18 Feb 2021 07:31:22 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCdmQ-0002Tn-V5 for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2021 07:31:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613633477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MnV8BsWsjwH7peotIX7G2PVOFrZQTedhCt87aYcboVo=; b=AGz3UzH033TI9vledAvJU5aJoghgGSa2nXcfcLe7swDi2cKjzfByRuJWpZfkViO3TLXlKq TM1bO2kHTquEsFkStjCBei8PIU91dblDnqxgFY7+sDF9WEyDZvyCFTFZyKjxQbgNJCMzEH YHJAWq1XrJEBVWrjfEKc16FmuomKa2U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-4-36TG0Bi-NdSHuWcSGq9n-g-1; Thu, 18 Feb 2021 02:31:13 -0500 X-MC-Unique: 36TG0Bi-NdSHuWcSGq9n-g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CC291814329; Thu, 18 Feb 2021 07:31:10 +0000 (UTC) Received: from localhost (ovpn-12-112.pek2.redhat.com [10.72.12.112]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C05B35D9D2; Thu, 18 Feb 2021 07:31:06 +0000 (UTC) Date: Thu, 18 Feb 2021 15:31:04 +0800 From: Baoquan He To: Chen Zhou , rppt@kernel.org Subject: Re: [PATCH v14 09/11] x86, arm64: Add ARCH_WANT_RESERVE_CRASH_KERNEL config Message-ID: <20210218073104.GI2871@MiWiFi-R3L-srv> References: <20210130071025.65258-1-chenzhou10@huawei.com> <20210130071025.65258-10-chenzhou10@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210130071025.65258-10-chenzhou10@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210218_023119_227071_5AA06A42 X-CRM114-Status: GOOD ( 21.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: horms@verge.net.au, John.P.donnelly@oracle.com, wangkefeng.wang@huawei.com, arnd@arndb.de, will@kernel.org, corbet@lwn.net, catalin.marinas@arm.com, xiexiuqi@huawei.com, guohanjun@huawei.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-doc@vger.kernel.org, mingo@redhat.com, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, huawei.libin@huawei.com, prabhakar.pkin@gmail.com, tglx@linutronix.de, dyoung@redhat.com, kexec@lists.infradead.org, nsaenzjulienne@suse.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/30/21 at 03:10pm, Chen Zhou wrote: > We make the functions reserve_crashkernel[_low]() as generic for > x86 and arm64. Since reserve_crashkernel[_low]() implementations > are quite similar on other architectures as well, we can have more > users of this later. > > So have CONFIG_ARCH_WANT_RESERVE_CRASH_KERNEL in arch/Kconfig and > select this by X86 and ARM64. > > Suggested-by: Mike Rapoport > Suggested-by: Baoquan He > Signed-off-by: Chen Zhou > --- > arch/Kconfig | 3 +++ > arch/arm64/Kconfig | 1 + > arch/x86/Kconfig | 2 ++ > kernel/crash_core.c | 7 ++----- > 4 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 24862d15f3a3..0ca1ff5bb157 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -24,6 +24,9 @@ config KEXEC_ELF > config HAVE_IMA_KEXEC > bool > > +config ARCH_WANT_RESERVE_CRASH_KERNEL > + bool > + > config SET_FS > bool > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index f39568b28ec1..09365c7ff469 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -82,6 +82,7 @@ config ARM64 > select ARCH_WANT_FRAME_POINTERS > select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) > select ARCH_WANT_LD_ORPHAN_WARN > + select ARCH_WANT_RESERVE_CRASH_KERNEL if KEXEC_CORE > select ARCH_HAS_UBSAN_SANITIZE_ALL > select ARM_AMBA > select ARM_ARCH_TIMER > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 21f851179ff0..e6926fcb4a40 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -12,6 +12,7 @@ config X86_32 > depends on !64BIT > # Options that are inherently 32-bit kernel only: > select ARCH_WANT_IPC_PARSE_VERSION > + select ARCH_WANT_RESERVE_CRASH_KERNEL if KEXEC_CORE > select CLKSRC_I8253 > select CLONE_BACKWARDS > select GENERIC_VDSO_32 > @@ -28,6 +29,7 @@ config X86_64 > select ARCH_HAS_GIGANTIC_PAGE > select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 > select ARCH_USE_CMPXCHG_LOCKREF > + select ARCH_WANT_RESERVE_CRASH_KERNEL if KEXEC_CORE > select HAVE_ARCH_SOFT_DIRTY > select MODULES_USE_ELF_RELA > select NEED_DMA_MAP_STATE > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index 8479be270c0b..2c5783985db5 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -320,9 +320,7 @@ int __init parse_crashkernel_low(char *cmdline, > * --------- Crashkernel reservation ------------------------------ > */ > > -#ifdef CONFIG_KEXEC_CORE > - > -#if defined(CONFIG_X86) || defined(CONFIG_ARM64) > +#ifdef CONFIG_ARCH_WANT_RESERVE_CRASH_KERNEL > static int __init reserve_crashkernel_low(void) > { > #ifdef CONFIG_64BIT > @@ -450,8 +448,7 @@ void __init reserve_crashkernel(void) > crashk_res.start = crash_base; > crashk_res.end = crash_base + crash_size - 1; > } > -#endif > -#endif /* CONFIG_KEXEC_CORE */ > +#endif /* CONFIG_ARCH_WANT_RESERVE_CRASH_KERNEL */ Why don't you move the dummy reserve_crashkernel() here too? #ifdef CONFIG_ARCH_WANT_RESERVE_CRASH_KERNEL #ifdef CONFIG_KEXEC_CORE ... '...the real crashkernel reservation code...' ... #else static void __init reserve_crashkernel(void) { } #endif #endif /* CONFIG_ARCH_WANT_RESERVE_CRASH_KERNEL */ Like this, you don't need those two dummy reserve_crashkernel() in x86 and arm64? Thanks Baoquan > > Elf_Word *append_elf_note(Elf_Word *buf, char *name, unsigned int type, > void *data, size_t data_len) > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel