From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18585C433E0 for ; Thu, 18 Feb 2021 09:15:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4DCF61494 for ; Thu, 18 Feb 2021 09:15:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4DCF61494 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PL3AwOoA8j65WwILb65kE/wvrqHOG1PidIianrLIpLM=; b=Ik5TWLFSuSVmYr0p2Yy9t2XTu xrh9dikAhYTs7e9AChGYtgCS9tzALwTMM/6KkIR7rQq3tjQqodPg85T1b8Dz76wdlPh4nMA0+rNGo LPZrAighBWgXT5hynRdGqfMGzO1LGgvyl7k0fvDWfa6gpWPPMplA30+IHPqHsIGX7ZlWqST1jJHos 3jL8Yx0I9XDiCKZyQDLeeH9Ai2yChw3cjjBdgHohEkX5MgIyOUzDwHvrIlTnsUX1+vaSAQd33IGHv +HPU7eEfb/hDGkgsJLJ8WK1ORCVgaJ/j8LiFWTEfaUmWtUOvJekzrydOIg72UkIbYSUPS+kzUe2tb a8vR50B2A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCfNX-00031t-13; Thu, 18 Feb 2021 09:13:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCfNU-00031B-KW for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2021 09:13:41 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 57B9B64E5F; Thu, 18 Feb 2021 09:13:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613639619; bh=B0hMsWiw3eAyDDiSNcBDZUifk66GOGmnQHglDj25lFw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B9U10zUJ6moUeph7lBVjm93xe5W3LPGVwnzfX+rGvCxRSxjYC3+aWvjt9+0St6Wtl L439P/hZ3DGbVMYDbGboI3djSBc3c8h0s+u/IvLrCvtkj1VPYChjcbOOrzLBs/3hZo EsQPwRnq1r/2IW42K3AR2ylfvLf3GwcK/7q1mtT5vdja6qlkgZgXIfMLtmoVhAGkye dBZC78JSs+kqBwUc4roCxa+KJylmoQmt3smbm6nA6X3+qEuTnHGP5idytaNADVZeCD AwUkGdveQPMjyeSRTzd5vDqH+fxx6ViH9FyBYNtjNAjWcN3wIVo3AnwVn2eCv3/9LY b29Svs4yiX69w== Date: Thu, 18 Feb 2021 09:13:35 +0000 From: Will Deacon To: "Leizhen (ThunderTown)" Subject: Re: [PATCH 1/1] ARM: hw_breakpoint: Do not directly check the event's overflow_handler hook Message-ID: <20210218091334.GB4874@willie-the-truck> References: <20210207105934.2001-1-thunder.leizhen@huawei.com> <20210212100159.GA30991@willie-the-truck> <16641f07-e2fd-f3d0-88de-c4c5deb2ad45@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <16641f07-e2fd-f3d0-88de-c4c5deb2ad45@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210218_041340_790134_2AB00F56 X-CRM114-Status: GOOD ( 20.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Wang Nan , Russell King , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 18, 2021 at 10:03:22AM +0800, Leizhen (ThunderTown) wrote: > > > On 2021/2/12 18:02, Will Deacon wrote: > > On Sun, Feb 07, 2021 at 06:59:34PM +0800, Zhen Lei wrote: > >> The commit 1879445dfa7b ("perf/core: Set event's default > >> ::overflow_handler()") set a default event->overflow_handler in > >> perf_event_alloc(), and replace the check event->overflow_handler with > >> is_default_overflow_handler(), but one is missing. > >> > >> Currently, the bp->overflow_handler can not be NULL. As a result, > >> enable_single_step() is always not invoked. > >> > >> Fixes: 1879445dfa7b ("perf/core: Set event's default ::overflow_handler()") > >> Signed-off-by: Zhen Lei > >> Cc: Wang Nan > >> --- > >> arch/arm/kernel/hw_breakpoint.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c > >> index 08660ae9dcbce1c..b1423fb130ea4a0 100644 > >> --- a/arch/arm/kernel/hw_breakpoint.c > >> +++ b/arch/arm/kernel/hw_breakpoint.c > >> @@ -886,7 +886,7 @@ static void breakpoint_handler(unsigned long unknown, struct pt_regs *regs) > >> info->trigger = addr; > >> pr_debug("breakpoint fired: address = 0x%x\n", addr); > >> perf_bp_event(bp, regs); > >> - if (!bp->overflow_handler) > >> + if (is_default_overflow_handler(bp)) > >> enable_single_step(bp, addr); > >> goto unlock; > >> } > > > > Acked-by: Will Deacon > > > > Please can you put this into the patch tracker? > > > > https://www.arm.linux.org.uk/developer/patches/ > > I've added it. > > https://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=9064/1 Thanks, although you forgot to add my Ack! Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel