From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C381C433DB for ; Fri, 19 Feb 2021 18:21:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 198EB64E4B for ; Fri, 19 Feb 2021 18:21:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 198EB64E4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NrBKg48K+AVkTG0afnPcv2ErSBQAwPcSJakdYIZ3Kj8=; b=Qg7ObHfOL8yV2ehZSB8b8RFN3 M8jzXNcQWG7nYBeIJ0OywQ4NPzFN07qf10cHEAP7lJHo6/eOs5/KAqAn0TSlyZ1f4V+SBpzbG9WeV 83FCpnqboMwJOLiut3NMW1pTsF8XG7tr5kCHei4/QLRv4kQXyTi0b7ymHrkcE/ahR42H3ObqPE2rJ ccDBscuGe53+H3G6fz0ykIcm1O/+gdg/KncU2AvkooVdv4VaDRZBl9+IVnCusKQkRRZKRyQh84BUz UZeJkl3a8REHT2LLCc2vexregt6B4wPTwVny+ZX1t2wt06IxClGHOKc81NFky3av4Xtr9T3H6LWHg /MpqbNO5w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDAMh-0000nb-LZ; Fri, 19 Feb 2021 18:18:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDAMf-0000nD-4G for linux-arm-kernel@lists.infradead.org; Fri, 19 Feb 2021 18:18:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A15F9ED1; Fri, 19 Feb 2021 10:18:46 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.45.200]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5F76E3F73D; Fri, 19 Feb 2021 10:18:44 -0800 (PST) Date: Fri, 19 Feb 2021 18:18:34 +0000 From: Mark Rutland To: Joey Gouly Subject: Re: [PATCH 8/8] arm64: irq: allow FIQs to be handled Message-ID: <20210219181825.GA84857@C02TD0UTHF1T.local> References: <20210219113904.41736-1-mark.rutland@arm.com> <20210219113904.41736-9-mark.rutland@arm.com> <20210219153725.GA43917@e124191.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210219153725.GA43917@e124191.cambridge.arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210219_131853_274075_A3084C73 X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, marcan@marcan.st, linux-kernel@vger.kernel.org, james.morse@arm.com, maz@kernel.org, tglx@linutronix.de, nd@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 19, 2021 at 03:37:25PM +0000, Joey Gouly wrote: > Hi Mark, > > On Fri, Feb 19, 2021 at 11:39:04AM +0000, Mark Rutland wrote: > > On contemporary platforms we don't use FIQ, and treat any stray FIQ as a > > fatal event. However, some platforms have an interrupt controller wired > > to FIQ, and need to handle FIQ as part of regular operation. > > > > [...] > > > diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S > > index 0474cca9f1a9..a8290bd87a49 100644 > > --- a/arch/arm64/kernel/entry.S > > +++ b/arch/arm64/kernel/entry.S > > @@ -586,23 +586,23 @@ SYM_CODE_START(vectors) > > > > kernel_ventry 1, sync // Synchronous EL1h > > kernel_ventry 1, irq // IRQ EL1h > > - kernel_ventry 1, fiq_invalid // FIQ EL1h > > + kernel_ventry 1, fiq // FIQ EL1h > > kernel_ventry 1, error // Error EL1h > > > > kernel_ventry 0, sync // Synchronous 64-bit EL0 > > kernel_ventry 0, irq // IRQ 64-bit EL0 > > - kernel_ventry 0, fiq_invalid // FIQ 64-bit EL0 > > + kernel_ventry 0, fiq // FIQ 64-bit EL0 > > kernel_ventry 0, error // Error 64-bit EL0 > > > > #ifdef CONFIG_COMPAT > > kernel_ventry 0, sync_compat, 32 // Synchronous 32-bit EL0 > > kernel_ventry 0, irq_compat, 32 // IRQ 32-bit EL0 > > - kernel_ventry 0, fiq_invalid_compat, 32 // FIQ 32-bit EL0 > > + kernel_ventry 0, fiq_compat, 32 // FIQ 32-bit EL0 > > kernel_ventry 0, error_compat, 32 // Error 32-bit EL0 > > #else > > kernel_ventry 0, sync_invalid, 32 // Synchronous 32-bit EL0 > > kernel_ventry 0, irq_invalid, 32 // IRQ 32-bit EL0 > > - kernel_ventry 0, fiq_invalid, 32 // FIQ 32-bit EL0 > > + kernel_ventry 0, fiq, 32 // FIQ 32-bit EL0 > > kernel_ventry 0, error_invalid, 32 // Error 32-bit EL0 > > #endif > > SYM_CODE_END(vectors) > > I believe you can now remove functions `el0_fiq_invalid` and `el0_fiq_invalid_compat`. > `el1_fiq_invalid` is still used by Synchronous EL1t, so can't be removed. Good spot; el0_fiq_invalid_compat can go. For the !CONFIG_COMPAT it was wrong to move away from fiq_invalid as that vector should never legimitately fire, so I'll revert back to fiq_invalid for that case and match the rest of the !CONFIG_COMPAT AArch32 EL0 handlers. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel