From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5136FC433DB for ; Sat, 20 Feb 2021 09:05:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CE5964ED5 for ; Sat, 20 Feb 2021 09:05:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CE5964ED5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baikalelectronics.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wi0ATNcjG3fElQWsqmE5t0h4EB7NEYz5l7ERTexbAzw=; b=hv7NIfwRokEnbtMTeELpfMhog rGwD/D6DEFdjrsrKVBYzUcBKPx0xka1hZtHEZbItv2jKY04U7gsHTb899QAc/Ep6qlnHoknRjiRL9 euQ3wHrCBqzQdSY/mLe5E+vQSTw4DssxRNfsXueZHn/UvRQZjchvvPEi5rmp9JmJC7aFsSgRPJbfE 4c+D1n9h/KftMzbybX7Ciyvf+LkZPHOgH44MPunOokaQGB3yT6I6NoYk0Q9f4xfD5W6eY3QATVMsn ML/8a/Q9I6RXD55hCFUs7h1MVi26mLNbBY+XFR/Kfpi2h879fUPCfyk3uwdOco/gY5TF7PfyM0Tax 0Yw6yy1RQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDOAI-0004rn-6f; Sat, 20 Feb 2021 09:03:02 +0000 Received: from mail.baikalelectronics.com ([87.245.175.226] helo=mail.baikalelectronics.ru) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDOAE-0004r9-NM for linux-arm-kernel@lists.infradead.org; Sat, 20 Feb 2021 09:03:00 +0000 Date: Sat, 20 Feb 2021 12:02:48 +0300 From: Serge Semin To: Russell King - ARM Linux admin , Heiner Kallweit , Andrew Lunn Subject: Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode Message-ID: <20210220090248.oiyonlfucvmgzw6d@mobilestation> References: <20210208140341.9271-1-Sergey.Semin@baikalelectronics.ru> <20210208140341.9271-2-Sergey.Semin@baikalelectronics.ru> <8300d9ca-b877-860f-a975-731d6d3a93a5@gmail.com> <20210209101528.3lf47ouaedfgq74n@mobilestation> <20210209105646.GP1463@shell.armlinux.org.uk> <20210210164720.migzigazyqsuxwc6@mobilestation> <20210211103941.GW1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210211103941.GW1463@shell.armlinux.org.uk> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210220_040258_929106_BC843757 X-CRM114-Status: GOOD ( 22.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jose Abreu , Joao Pinto , Alexandre Torgue , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Serge Semin , Alexey Malahov , Jose Abreu , Pavel Parkhomenko , Maxime Coquelin , Giuseppe Cavallaro , Jakub Kicinski , Vyacheslav Mitrofanov , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 11, 2021 at 10:39:41AM +0000, Russell King - ARM Linux admin wrote: > On Wed, Feb 10, 2021 at 07:47:20PM +0300, Serge Semin wrote: > > On Tue, Feb 09, 2021 at 10:56:46AM +0000, Russell King - ARM Linux admin wrote: > > > On Tue, Feb 09, 2021 at 11:37:29AM +0100, Heiner Kallweit wrote: > > > > Right, adding something like a genphy_{read,write}_mmd() doesn't make > > > > too much sense for now. What I meant is just exporting mmd_phy_indirect(). > > > > Then you don't have to open-code the first three steps of a mmd read/write. > > > > And it requires no additional code in phylib. > > > > > > ... but at the cost that the compiler can no longer inline that code, > > > as I mentioned in my previous reply. (However, the cost of the accesses > > > will be higher.) On the plus side, less I-cache footprint, and smaller > > > kernel code. > > > > Just to note mmd_phy_indirect() isn't defined with inline specifier, > > but just as static and it's used twice in the > > drivers/net/phy/phy-core.c unit. So most likely the compiler won't > > inline the function code in there. > > You can't always tell whether the compiler will inline a static function > or not. Andrew, Heiner, Russell, what is your final decision about this? Shall we export the mmd_phy_indirect() method, implement new genphy_{read,write}_mmd() or just leave the patch as is manually accessing the MMD register in the driver? -Sergey > > > Anyway it's up to the PHY > > library maintainers to decide. Please settle the issue with Heiner and > > Andrew then. I am ok with both solutions and will do as you decide. > > FYI, *I* am one of the phylib maintainers. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel