From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C07C1C433DB for ; Sat, 20 Feb 2021 19:15:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8125B61481 for ; Sat, 20 Feb 2021 19:15:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8125B61481 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JYyukVZKqDKcOduy3M1CExn2Cjz8eR+C30+DA2LNSKw=; b=s5/3IzffbbtwCMS/Hbez6qTUV uxVMcTGOqB+YuzMZZHMRihZvf5nDl4mnmfiUKNiuq/yfnZitIiuv+m5CO4i4j98zAA2ezLYihJge3 v6BObK82j+7lEPwtYY1ooasUixMJUGPI+n2WJSBcrCcd+0DbV4yTOGnYm2wNNxSagutXN3oxEh2eC 7d81qrPeEFkRMCwYeCy906EXLQHoCUFcdg5UnlyBbC9YZ24hajLT9RhKQKdQkg0t7Vof1gYJawnB/ G6EWyvAYY5cxWppysrmIDYi6esiLDNuFm4QDoGhdgJv/KpSWT/HDaSMjnTjZamKHuXvrUWABhcIzJ us4fhUI9A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDXh4-0003c7-PF; Sat, 20 Feb 2021 19:13:30 +0000 Received: from mail-wm1-f42.google.com ([209.85.128.42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDXh1-0003at-Sn for linux-arm-kernel@lists.infradead.org; Sat, 20 Feb 2021 19:13:28 +0000 Received: by mail-wm1-f42.google.com with SMTP id v62so10731602wmg.4 for ; Sat, 20 Feb 2021 11:13:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VF3s9s8dD+8FgMnQzEnFyHG1q1prhIJgjdP8jQ0Kb/E=; b=O8hjjsTPbeqrBhyKxFNoHIxLtw79Nt3HEGLgPs76eR96GtSYa2awYCeAGI5x+o+qtR LoiHxhDwM0WXvhJoe/TUWziwfwLhVgvZyY/VHfYn5BHyVUVAN3EjXd1BAMtsf/Pcauj4 Vm7SjkMnrYt6QrvPIlMfKVlCggpdHsEEGVWc43mReSebg9PzoPPZV727ZAr6OUXhCXzT 1DpG7qlj5P5tI4atz0/RFqlaV1FIh6NhrRrbpd//+92OKKhMa48hIV/XYaelHNrnJ60x TqDKLpdu1sIkjlr+3aX9UQELOxCIbsU1lwnLwzLMKrh7k3jFinC3c4P+yBN+lZhlF/BA 1otA== X-Gm-Message-State: AOAM530bnpl9/S8DrI+FvOJT1toKG9okV8gI9ftTN45+8mGPf+d816Db 0YcRw854BtuTptr4VYXLGSU= X-Google-Smtp-Source: ABdhPJw9s3IjvIxVsPN1AfNRpwIaxtgvmFES1CWbXCIdbkt8xArpUI6D3W0a2jIIJOy8C9bd/VV77g== X-Received: by 2002:a1c:d7:: with SMTP id 206mr13505454wma.68.1613848406537; Sat, 20 Feb 2021 11:13:26 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id x18sm10044772wrr.10.2021.02.20.11.13.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Feb 2021 11:13:25 -0800 (PST) Date: Sat, 20 Feb 2021 20:13:23 +0100 From: Krzysztof Kozlowski To: Hector Martin Subject: Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource Message-ID: <20210220191323.ugmzrtkvcxyqqolj@kozik-lap> References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-21-marcan@marcan.st> <20210215185135.onivzktfscv5myh2@kozik-lap> <20274436-7275-9734-5a07-d6da46b45c5f@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20274436-7275-9734-5a07-d6da46b45c5f@marcan.st> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210220_141328_037143_00F22D25 X-CRM114-Status: GOOD ( 21.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Arnd Bergmann , Rob Herring , Tony Lindgren , Marc Zyngier , Linus Walleij , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Kettenis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: > On 16/02/2021 03.51, Krzysztof Kozlowski wrote: > > > Also fix a bug checking the return value, which should use IS_ERR(). > > > > No, no, no. We never, never combine fixing bugs with some rework. > > However devm_ioremap() returns NULL so where is the error? > > Sorry, this was a commit message mistake. The code is correct and so is the > patch: just the NULL check is correct for the previous variant and IS_ERR is > correct for devm_ioremap_resource. I confused myself while writing the > commit message after the fact. > > > Did you test your patches on existing platforms? If not, please mark all > > of them as RFT on next submission, so Greg does not pick them too fast. > > I unfortunately don't have any Exynos devices where I could test the code (I > have a couple but no serial connections, and I have no idea if mailine would > run on them). I'll mark v3 as RFT. If you have one of Odroid boards with Exynos, then you can nicely test Exynos. Others - depends, on board. Anyway I can test them for you. I just want to be sure that Greg waits for this testing. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel