From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adrien Grassein <adrien.grassein@gmail.com>
Cc: DTML <devicetree@vger.kernel.org>,
will@kernel.org, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
catalin.marinas@arm.com, Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/8] arm64: dts: imx8mm-nitrogen-r2: add espi2 support
Date: Sat, 20 Feb 2021 20:20:29 +0100 [thread overview]
Message-ID: <20210220192029.nl3mk3b2tejxzyda@kozik-lap> (raw)
In-Reply-To: <CABkfQAEB5K6HO9U_GkHGVDTKjR_JyBJVodidWXFSJcqw8LPcgg@mail.gmail.com>
On Fri, Feb 19, 2021 at 03:02:35PM +0100, Adrien Grassein wrote:
> Le ven. 19 févr. 2021 à 14:19, Krzysztof Kozlowski <krzk@kernel.org> a écrit :
> >
> > On Wed, Feb 17, 2021 at 05:10:47PM +0100, Adrien Grassein wrote:
> > > Add the description for espi support.
> > >
> > > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > ---
> > > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 30 +++++++++++++++++++
> > > 1 file changed, 30 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> > > index f62a25efc69e..c4bb22bb4e6a 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> > > @@ -10,6 +10,14 @@ / {
> > > model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2";
> > > compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm";
> > >
> > > + clock {
> > > + clk16m: clk16m {
> >
> > No changes here. The review tag was conditional in a way that I assumed
> > you will implement this change.
> >
> Sorry I misunderstood your comment. I renamed the "clocks" node.
> By the way, after a review, this nod is useless (not used).
The "clocks" node was okay, you can also remove it. I was commenting
below the clock itself. The device nodes should have generic names, so
"clock" or "clock-16m".
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-20 19:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 16:10 [PATCH v2 0/8] Add peripheral support for imx8mm-nitrogen-r2 board Adrien Grassein
2021-02-17 16:10 ` [PATCH v2 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip Adrien Grassein
2021-02-19 13:18 ` Krzysztof Kozlowski
2021-02-19 14:03 ` Adrien Grassein
2021-02-20 19:19 ` Krzysztof Kozlowski
2021-02-21 23:46 ` Adrien Grassein
2021-02-22 18:40 ` Krzysztof Kozlowski
2021-02-23 10:44 ` Adrien Grassein
2021-02-23 19:03 ` Krzysztof Kozlowski
2021-02-17 16:10 ` [PATCH v2 2/8] arm64: dts: imx8mm-nitrogen-r2: add USB support Adrien Grassein
2021-02-17 16:10 ` [PATCH v2 3/8] arm64: dts: imx8mm-nitrogen-r2: add espi2 support Adrien Grassein
2021-02-19 13:19 ` Krzysztof Kozlowski
2021-02-19 14:02 ` Adrien Grassein
2021-02-20 19:20 ` Krzysztof Kozlowski [this message]
2021-02-17 16:10 ` [PATCH v2 4/8] arm64: dts: imx8mm-nitrogen-r2: add UARTs Adrien Grassein
2021-02-19 13:20 ` Krzysztof Kozlowski
2021-02-17 16:10 ` [PATCH v2 5/8] arm64: dts: imx8mm-nitrogen-r2: add PWMs Adrien Grassein
2021-02-17 16:10 ` [PATCH v2 6/8] arm64: dts: imx8mm-nitrogen-r2: add FlexSPI Adrien Grassein
2021-02-17 16:10 ` [PATCH v2 7/8] arm64: dts: imx8mm-nitrogen-r2: add audio Adrien Grassein
2021-02-17 16:10 ` [PATCH v2 8/8] arm64: defconfig: Enable wm8960 audio driver Adrien Grassein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210220192029.nl3mk3b2tejxzyda@kozik-lap \
--to=krzk@kernel.org \
--cc=adrien.grassein@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox