From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D71C433E0 for ; Sat, 20 Feb 2021 19:24:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C58164E54 for ; Sat, 20 Feb 2021 19:24:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C58164E54 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7tfOtFt6U0M8tfeuBbhco83pJz48OVbVBas3f+pHCqk=; b=3jqeKChLAGPM9VDsOAD6BUz0q aCuvcEEvpDEN8taVq7uTuEdNFEZLayrVn42NtPtOylUVAJqdvHtVH/zy80sUusjMpBR0gnswEY+gl EKzelYde0vYU3j8BpeNgiOv8LtuvgSX4PLXgLIvr1k+7gLtypgI4TwkZtSYeoQDvd5OKww8diLwcL V97XlnBF0fec+8S8nY5BQRCA3INz5DIXCGvB0o8/+pHvvAUkRpYTMxMKSRLtBi25M2ZlW7RVlT1Bf 8dsdmnWKWyYGqCRDlYSWZ73IpAGMV6QBybCfCU2g9avPgVTfz4fYAtEPJkUCejJgQz0pzOzspWrz+ vM9tDmF5A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDXqE-00058V-SZ; Sat, 20 Feb 2021 19:22:58 +0000 Received: from mail-ed1-f42.google.com ([209.85.208.42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDXqB-00056t-5a for linux-arm-kernel@lists.infradead.org; Sat, 20 Feb 2021 19:22:56 +0000 Received: by mail-ed1-f42.google.com with SMTP id z22so16569897edb.9 for ; Sat, 20 Feb 2021 11:22:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JzFKHqvuSUGXCnevV5+iFx0p/nySPaeOSAeBEwyhoZM=; b=AwAm04bgIKKFo7CAlK6iWaBkO1t9tlFRHih/spfUhWIpP9Bl5AFJIhTlpkuKMTh/bg dfHS2DaUAOIk0XXiLzqEqrL168LOMe6NRZ8K36c+hAudjJ9ThPLWQA5U9O1+rktaFHwy /EhRLweuAUnNX7tGIk4yYGM4xN7w3VaV9oX07xKf4VTC2sxkHUQcvxW+EOL/aRvo054S 6wQTW5BjC5Ee+rXA8Rt/PGNxXuGpoVY0Rp24EmgmwlVErWBueY/X9z96LPbcHBDjGzgd uID77AEYwi5PmrCcBkmNcPN8epZDa0h3JVkiBBTqgDorPGbxHcVL8BL8OB9ApHAHaEYK wu6w== X-Gm-Message-State: AOAM531yoJnWFXyaNdJ5ZkyrPyPP9QE+xO5iRwNdxuqoixxDgJKf3+/h 7FnRY7O4xn5375G++eFw1f4= X-Google-Smtp-Source: ABdhPJzM9MWlsrTf8/OshCZ1sv8gKEwc9FTZajGLSwthP3mMiTUtfDoWeQkCLEz68cHLu7p0fc+0jg== X-Received: by 2002:a50:aac8:: with SMTP id r8mr14937708edc.9.1613848970522; Sat, 20 Feb 2021 11:22:50 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id k4sm4856721ejv.73.2021.02.20.11.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Feb 2021 11:22:49 -0800 (PST) Date: Sat, 20 Feb 2021 20:22:48 +0100 From: Krzysztof Kozlowski To: Adrien Grassein Subject: Re: [PATCH v3 1/9] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip Message-ID: <20210220192248.2x4zk4zvorxbjsen@kozik-lap> References: <20210219143028.207975-1-adrien.grassein@gmail.com> <20210219143028.207975-2-adrien.grassein@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210219143028.207975-2-adrien.grassein@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210220_142255_250352_993C9AFF X-CRM114-Status: GOOD ( 18.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, will@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, catalin.marinas@arm.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 19, 2021 at 03:30:20PM +0100, Adrien Grassein wrote: > Add usdhc3 description which corresponds to the wifi/bt chip > > Signed-off-by: Adrien Grassein > --- > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > index c0c384d76147..4a3dabeb8c85 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > @@ -9,6 +9,24 @@ > / { > model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > + > + reg_vref_1v8: regulator-vref-1v8 { > + compatible = "regulator-fixed"; > + regulator-name = "vref-1v8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + reg_wlan_vmmc: regulator-wlan-vmmc { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_reg_wlan_vmmc>; > + regulator-name = "reg_wlan_vmmc"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > }; > > &A53_0 { > @@ -206,6 +224,20 @@ &usdhc2 { > status = "okay"; > }; > > +/* wlan */ > +&usdhc3 { > + bus-width = <4>; > + sdhci-caps-mask = <0x2 0x0>; > + non-removable; > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > + pinctrl-0 = <&pinctrl_usdhc3>; > + pinctrl-1 = <&pinctrl_usdhc3_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc3_200mhz>; > + vmmc-supply = <®_wlan_vmmc>; > + vqmmc-supply = <®_vref_1v8>; You sent v3 before I replied on your comments. I don't think there is any benefit in fixed-regulator which cannot be controlled. Are you sure vqmmc (the bus clock, host interface, controller core?) does not go from the PMIC? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel