From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3509C433DB for ; Sun, 21 Feb 2021 14:06:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CAAD64EE0 for ; Sun, 21 Feb 2021 14:06:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CAAD64EE0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gk0r5KmVUCWrYgJ/CTx3JA29NKanC2WBtAhocU2EdGI=; b=CCv780PxEyFinHabMnZAAIY53 IZr1DbdTX5DVliUUgB6fNc7iwt/494pY63H6HvnQTZBx3aYTmMh9sizVoB/voJ/fEtGCDu7M5/0c1 o/evaAPQ6eJYz3PmKDu/KWxdgFZXlNfPYlvGSe6yveWb++18THUYPt0IyRrcFpVOmPVN3HaQylaDr PbLRwAuZ0LP33r6lQT7oGqUnSdSwwkalNBT+lUvETyqHKHUfXstdRhNWnGKGlWNMQ+VZF7IBtwCIl mgrGk4u8o4pJ36S0aa7VIFwb6NNaVdl8W/jCUb7hGgbdWOyPbyuyt0YzyyBcqaQxen70jOkq5TyGb hLnkm3Fdg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDpML-00035M-Bk; Sun, 21 Feb 2021 14:05:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDpMI-00034s-Ml for linux-arm-kernel@lists.infradead.org; Sun, 21 Feb 2021 14:05:15 +0000 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0315061481; Sun, 21 Feb 2021 14:05:10 +0000 (UTC) Date: Sun, 21 Feb 2021 14:05:07 +0000 From: Jonathan Cameron To: William Breathitt Gray Subject: Re: [PATCH v8 19/22] counter: Implement extension*_name sysfs attributes Message-ID: <20210221140507.0a5ef57f@archlinux> In-Reply-To: References: <20210214180913.05bd3498@archlinux> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210221_090514_830959_E0576BF1 X-CRM114-Status: GOOD ( 22.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kamel.bouhara@bootlin.com, gwendal@chromium.org, a.fatoum@pengutronix.de, david@lechnology.com, linux-iio@vger.kernel.org, patrick.havelange@essensium.com, alexandre.belloni@bootlin.com, mcoquelin.stm32@gmail.com, linux-kernel@vger.kernel.org, o.rempel@pengutronix.de, Dan Carpenter , kernel@pengutronix.de, fabrice.gasnier@st.com, syednwaris@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, alexandre.torgue@st.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 19 Feb 2021 17:51:37 +0900 William Breathitt Gray wrote: > On Sun, Feb 14, 2021 at 06:09:13PM +0000, Jonathan Cameron wrote: > > On Fri, 12 Feb 2021 21:13:43 +0900 > > William Breathitt Gray wrote: > > > > > The Generic Counter chrdev interface expects users to supply extension > > > IDs in order to select extensions for requests. In order for users to > > > know what extension ID belongs to which extension this information must > > > be exposed. The extension*_name attribute provides a way for users to > > > discover what extension ID belongs to which extension by reading the > > > respective extension name for an extension ID. > > > > > > Cc: David Lechner > > > Cc: Gwendal Grignou > > > Cc: Dan Carpenter > > > Signed-off-by: William Breathitt Gray > > > --- > > > Documentation/ABI/testing/sysfs-bus-counter | 9 ++++ > > > drivers/counter/counter-sysfs.c | 51 +++++++++++++++++---- > > > 2 files changed, 50 insertions(+), 10 deletions(-) > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-counter b/Documentation/ABI/testing/sysfs-bus-counter > > > index 6353f0a2f8f8..847e96f19d19 100644 > > > --- a/Documentation/ABI/testing/sysfs-bus-counter > > > +++ b/Documentation/ABI/testing/sysfs-bus-counter > > > @@ -100,6 +100,15 @@ Description: > > > Read-only attribute that indicates whether excessive noise is > > > present at the channel Y counter inputs. > > > > > > +What: /sys/bus/counter/devices/counterX/countY/extensionZ_name > > > +What: /sys/bus/counter/devices/counterX/extensionZ_name > > > +What: /sys/bus/counter/devices/counterX/signalY/extensionZ_name > > > +KernelVersion: 5.13 > > > +Contact: linux-iio@vger.kernel.org > > > +Description: > > > + Read-only attribute that indicates the component name of > > > + Extension Z. > > > > Good to say what form this takes. > > Do you mean a description like this: "Read-only string attribute that > indicates the component name of Extension Z"? My expectation would be that the possible strings are tightly constrained (perhaps via review). So I'd like to see what they are and a brief description of what each one means. Jonathan > > William Breathitt Gray _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel