From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AECC8C433DB for ; Mon, 22 Feb 2021 01:33:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B0B964E77 for ; Mon, 22 Feb 2021 01:33:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B0B964E77 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c+2KZjBflTDq9PzDXjaVxcfylu93My7xynImSM6Aalg=; b=E2zUH7vciYGc1JHv8poLxsnVK /Trg/SCnCteY28c79nSWXLea6g+gQsf6/kyRUU7ubXS28eJEyW9OXVJ85riVeFH0ogNZeXMRl7qSY oPkExp6WnhZf8+6PUJLgw0BbN6U/wBlW0SN/c2MrGMBMaEJ1vLzZip5V1gYojAc/tKky6ibRQ4AAe +JWc2rTLq4rftPwemCjdQJByF7mulyLgOLOkO7OvpqbSC8VxO1hMGhkfdPF3HdnkvSU5vL2S0ONQf 4ri1GVKsDRjIrgnHvNp1cFxWyKlOnsUtXXrEGyxMD5UwiK/XiciCF06YBvnH+r+uA6oJnmkwOJarG ZiSZQVeGQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lE059-00060J-S0; Mon, 22 Feb 2021 01:32:15 +0000 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lE056-0005z4-TW for linux-arm-kernel@lists.infradead.org; Mon, 22 Feb 2021 01:32:13 +0000 Received: by mail-ot1-x32a.google.com with SMTP id s3so7406214otg.5 for ; Sun, 21 Feb 2021 17:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=urSTMy9t6cTiTrhHbL96lNEFLr5gM8etKvvG8YybOtM=; b=RiKpsUd2eg9pq2eKx9PgQDgKlS6S2TMP1cA6OmvM+0aHJN1D+Fxatx7zLPScl4ZvP1 z0qfvtLpR+HDDilB8prIpl46msQycXNibiUYYCf1kto7cDyfvgtxVKRI9ZSyyvcl3ZKp 6JBAGiAbBDBlaRu8DbGbpHN8pvSQ+rk81NktKSs/nBI+1M2aoBpkxjSBIkaFd8An7F12 tFHljIX96wMyJpDhZO9594jJ13VQxiZjSjSnv1IBAor0PzRNmhjg0BWxLWZkBRd06PFD K7d/0XsrGKDw2UK+ViumxfVoK96HtpH/Sdl+TJkEgMQC8MGj+XmO3FBglsLneyIIE6YI G1Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=urSTMy9t6cTiTrhHbL96lNEFLr5gM8etKvvG8YybOtM=; b=Ojj+uzymkSFayjvR8CWTpYiJWquVL9zMcz5zQhU/Tz0VSFNoaRBK0GMfMOfwdX5vuc 9mMb7qYJAlPkhAS6DbTZq1ht/0y4W0cWE8EiiS8+29s5z0aRw+xc5HJG02+HL+s4jURF up+JVeWSApPHI5/nUF1hjhZeF2hwTv8LtYVF4ZtPMkRSWDo7QDO9RcuDBy6M3yE9SnsV FLx+88C//f1C2RLJhl0l43HQ1KkZH6C4JOzARC5AvnUzkIKYegW9eDn7vwdwEGzm1dos hV61iIDWM5bmVA9Qdl5OZN1bW5wlLGkviICYIY/4WsACAx4icG/2/pyaI5TxG36CMqPe V74A== X-Gm-Message-State: AOAM530Sozg3nzaa/K5fWkIn6Nnx84x+0o4RWe1l0qdtaXnqa8RZwn8V qXhvzeWCGhv2z82W+NoVj0A= X-Google-Smtp-Source: ABdhPJy9/ek5tQDmOCC4jipCZCItMiaiSmbk31Qp56NGSfXHrJmQjQYbxDtf5G5zBFDY1OH+xstrXg== X-Received: by 2002:a05:6830:3151:: with SMTP id c17mr1142078ots.194.1613957529125; Sun, 21 Feb 2021 17:32:09 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id p3sm1046484otf.22.2021.02.21.17.32.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 Feb 2021 17:32:08 -0800 (PST) Date: Sun, 21 Feb 2021 17:32:07 -0800 From: Guenter Roeck To: Lakshmi Ramasubramanian Subject: Re: [PATCH v18 03/11] of: Add a common kexec FDT setup function Message-ID: <20210222013207.GA142216@roeck-us.net> References: <20210213161049.6190-1-nramas@linux.microsoft.com> <20210213161049.6190-4-nramas@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210213161049.6190-4-nramas@linux.microsoft.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210221_203212_986055_2BB26793 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, benh@kernel.crashing.org, tao.li@vivo.com, zohar@linux.ibm.com, paulus@samba.org, vincenzo.frascino@arm.com, frowand.list@gmail.com, sashal@kernel.org, robh@kernel.org, mpe@ellerman.id.au, masahiroy@kernel.org, jmorris@namei.org, takahiro.akashi@linaro.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, serge@hallyn.com, devicetree@vger.kernel.org, pasha.tatashin@soleen.com, will@kernel.org, prsriva@linux.microsoft.com, hsinyi@chromium.org, allison@lohutok.net, christophe.leroy@c-s.fr, mbrugger@suse.com, balajib@linux.microsoft.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, james.morse@arm.com, dmitry.kasatkin@gmail.com, joe@perches.com, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 13, 2021 at 08:10:41AM -0800, Lakshmi Ramasubramanian wrote: > From: Rob Herring > > Both arm64 and powerpc do essentially the same FDT /chosen setup for > kexec. The differences are either omissions that arm64 should have > or additional properties that will be ignored. The setup code can be > combined and shared by both powerpc and arm64. > > The differences relative to the arm64 version: > - If /chosen doesn't exist, it will be created (should never happen). > - Any old dtb and initrd reserved memory will be released. > - The new initrd and elfcorehdr are marked reserved. > - "linux,booted-from-kexec" is set. > > The differences relative to the powerpc version: > - "kaslr-seed" and "rng-seed" may be set. > - "linux,elfcorehdr" is set. > - Any existing "linux,usable-memory-range" is removed. > > Combine the code for setting up the /chosen node in the FDT and updating > the memory reservation for kexec, for powerpc and arm64, in > of_kexec_alloc_and_setup_fdt() and move it to "drivers/of/kexec.c". > > Signed-off-by: Rob Herring > Signed-off-by: Lakshmi Ramasubramanian s390:allmodconfig: drivers/of/kexec.c: In function 'of_kexec_alloc_and_setup_fdt': drivers/of/kexec.c:378:10: error: 'const struct kimage' has no member named 'arch' 378 | image->arch.elf_load_addr, | ^~ drivers/of/kexec.c:379:10: error: 'const struct kimage' has no member named 'arch' 379 | image->arch.elf_headers_sz); | ^~ drivers/of/kexec.c:387:35: error: 'const struct kimage' has no member named 'arch' 387 | ret = fdt_add_mem_rsv(fdt, image->arch.elf_load_addr, | ^~ drivers/of/kexec.c:388:16: error: 'const struct kimage' has no member named 'arch' 388 | image->arch.elf_headers_sz); | ^~ Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel