From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A38C433E6 for ; Tue, 23 Feb 2021 14:20:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B19BF64E58 for ; Tue, 23 Feb 2021 14:20:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B19BF64E58 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pATvfBZLheZGkL5oqj9pRxhJ1BHtX/fLfgWi5cIDDsU=; b=bUDMqs0eCkv51xQ7NWJ09Wi3U RAV2roInYD6oY008RGkCRjAXkWZu8qIa3bkgkn04u2IyxUUi/CZ2M3UoCEsesQJDbUzNxECkjZb0j fvYyIII1+VK8EOtJETT8G2vHniNhefF1BmE8sJpdFWYLPWy9oY5hcTg1h5l0X8fbFIcZ5nv1K6Dgt FHcVySezV1UajoPRq3q9RCN8D6ZsKCcxWBnbs1pN84zCEB8s6Y4lzrF5w5ZEAn2QY+w7ITOlsPVcU hRP4/YMrdecmpkn0fecw9XTYzchLoFEjLGNvw3vMaXZLXUHKfEskqzn6tKpqGtTwrsuyZhKvTV1xd 6Bw/UT+9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEYXP-0002lu-CS; Tue, 23 Feb 2021 14:19:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEYXM-0002lP-GZ for linux-arm-kernel@lists.infradead.org; Tue, 23 Feb 2021 14:19:41 +0000 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 103EE64E58; Tue, 23 Feb 2021 14:19:37 +0000 (UTC) Date: Tue, 23 Feb 2021 09:19:36 -0500 From: Steven Rostedt To: Jens Wiklander Subject: Re: [PATCH] tee: optee: add invoke_fn tracepoints Message-ID: <20210223091936.5b390f35@gandalf.local.home> In-Reply-To: <20210223131124.GA2303918@jade> References: <20210210144409.36ecdaed@xhacker.debian> <20210223184026.22c86356@xhacker.debian> <20210223131124.GA2303918@jade> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210223_091940_637535_E13F4978 X-CRM114-Status: GOOD ( 14.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jisheng Zhang , op-tee@lists.trustedfirmware.org, Linux Kernel Mailing List , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 23 Feb 2021 14:11:24 +0100 Jens Wiklander wrote: > I used the -strict option. > > ./scripts/checkpatch.pl -strict 0001-tee-optee-add-invoke_fn-tracepoints.patch > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #44: > new file mode 100644 The above is just asking for someone to take maintainership of the new file. > > CHECK: Alignment should match open parenthesis > #68: FILE: drivers/tee/optee/optee_trace.h:20: > +TRACE_EVENT(optee_invoke_fn_begin, > + TP_PROTO(struct optee_rpc_param *param), > > CHECK: Lines should not end with a '(' > #71: FILE: drivers/tee/optee/optee_trace.h:23: > + TP_STRUCT__entry( > > CHECK: Lines should not end with a '(' > #76: FILE: drivers/tee/optee/optee_trace.h:28: > + TP_fast_assign( > > CHECK: Alignment should match open parenthesis > #89: FILE: drivers/tee/optee/optee_trace.h:41: > +TRACE_EVENT(optee_invoke_fn_end, > + TP_PROTO(struct optee_rpc_param *param, struct arm_smccc_res *res), > > CHECK: Lines should not end with a '(' > #92: FILE: drivers/tee/optee/optee_trace.h:44: > + TP_STRUCT__entry( > > CHECK: Lines should not end with a '(' > #97: FILE: drivers/tee/optee/optee_trace.h:49: > + TP_fast_assign( The TRACE_EVENT() macro is "special", and checkpatch notoriously stumbles over it. I usually recommend that people ignore the checkpatch warnings on TRACE_EVENT() macros. -- Steve > > total: 0 errors, 1 warnings, 6 checks, 86 lines checked _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel