From: Will Deacon <will@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Pavel Tatashin <pasha.tatashin@soleen.com>,
catalin.marinas@arm.com, kexec@lists.infradead.org,
jmorris@namei.org, linux-kernel@vger.kernel.org,
tyhicks@linux.microsoft.com, james.morse@arm.com,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] kexec: move machine_kexec_post_load() to public interface
Date: Tue, 23 Feb 2021 09:45:32 +0000 [thread overview]
Message-ID: <20210223094531.GA10254@willie-the-truck> (raw)
In-Reply-To: <m1im6jmki1.fsf@fess.ebiederm.org>
On Mon, Feb 22, 2021 at 11:16:38PM -0600, Eric W. Biederman wrote:
> Will Deacon <will@kernel.org> writes:
>
> > On Fri, 19 Feb 2021 14:51:42 -0500, Pavel Tatashin wrote:
> >> machine_kexec_post_load() is called after kexec load is finished. It must
> >> declared in public header not in kexec_internal.h
> >>
> >> Fixes the following compiler warning:
> >>
> >> arch/arm64/kernel/machine_kexec.c:62:5: warning: no previous prototype for
> >> function 'machine_kexec_post_load' [-Wmissing-prototypes]
> >> int machine_kexec_post_load(struct kimage *kimage)
> >
> > Applied to arm64 (for-next/fixes), thanks!
> >
> > [1/1] kexec: move machine_kexec_post_load() to public interface
> > https://git.kernel.org/arm64/c/2596b6ae412b
>
> As you have already applied this it seems a bit late,
> but I will mention that change could legitimately have the following
> tag.
>
> Fixes: de68e4daea90 ("kexec: add machine_kexec_post_load()")
>
> So far arm64 is the only implementation of that hook.
I added 'Fixes: 4c3c31230c91 ("arm64: kexec: move relocation function
setup")' when I applied the patch, so at least it's clearly marked as a
fix.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-02-23 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 19:51 [PATCH v2] kexec: move machine_kexec_post_load() to public interface Pavel Tatashin
2021-02-22 14:29 ` Will Deacon
2021-02-23 5:16 ` Eric W. Biederman
2021-02-23 9:45 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223094531.GA10254@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=ebiederm@xmission.com \
--cc=james.morse@arm.com \
--cc=jmorris@namei.org \
--cc=kernel-team@android.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=tyhicks@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox