From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 473BEC433DB for ; Tue, 23 Feb 2021 13:13:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F02206023C for ; Tue, 23 Feb 2021 13:13:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F02206023C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pf1U1UuNyuOmgc6nGPWaDVpt1IGY45JM+H1J0fuWY3E=; b=099r7sRXwf7oVQr98KtyWC5SE Y+iPvIMzmjxI+bdCt8mhKzWxGRYWPptrMbkiH6i1wT37UinydwWPEzTv9LegVYbGezcKPOUsb2W52 LRz8itUJiqZ/aYq9+4Hh8aXcPbNiCofvZ3liBvNizGo2IEZKrHClxEz7FX956DzxEHVY0Ur9kbzJZ oiodiL5FpjyfPhzHvObj/pOzrySbzBT/ZzsaeGBJRop81WV3yCx0vmZKLIO6S5GsPo+zwdfmsW072 P7NjxGh00AHGrKlCY+FPm+PCDGmyvNFYqWJnRsZ+wpqgS0WvKL16t12XIvJr+gwqwEwyFubiT8Rrl SmTbutr3w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEXTP-0005Hz-EO; Tue, 23 Feb 2021 13:11:31 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEXTM-0005HW-HU for linux-arm-kernel@lists.infradead.org; Tue, 23 Feb 2021 13:11:29 +0000 Received: by mail-lf1-x134.google.com with SMTP id f1so11153703lfu.3 for ; Tue, 23 Feb 2021 05:11:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=58Vl6MdTDmvOpytzkwrUHMlB/23h8vA0IENULWrl6dY=; b=MH3OmbwBejCINO6iEeH3lQHAeNNuSSvnB8ObDUY5/Y6k6aSd7va3qPSFG0BlnJ97qB baLhc70dMw8bPcL2atw4yF0ol8/4l/ZT59GKmVfxkthtbfW8IQ/273ErCqrgzn+NQPCk PJuMgrenDbT2DV9nXaf4Vn9b+eH9uiFIJxTXMyE4/5LSTAVCoj4sSRAXQG/LCvF1S6V+ 7jvWBkHQ5ZrsPppScMi4c+RCXoWYaRlxU+YlOHy3yFvV++9Qviq5mp0Z4Gi7Vb8y3gvO sVzdJIQ6oYyJ3cQPaI/GS/CLcWwuEbQocEL3GvcvZhEpex0MPwxLIJ1vm2UaSmIJx042 R4Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=58Vl6MdTDmvOpytzkwrUHMlB/23h8vA0IENULWrl6dY=; b=JhBcpQkJNRxTy/LLXtzBxk1vqDVWn1vrKN7Sk6EOoYRtNZBkWg4WF1TL21Y0d9QVpb xi3q04Y9VWjk02ownvj+XK45F7xPy/sjbAfjZQrsecDhWnOEb4isTfbq07gjpnP+GPb1 TTtAFHyMH9IvgW8phTeAYEk0EThmaNhA3IZM6LegCINL/q7P4WsE7o1699I9A9wXrQ9G 8+6x2nM7OAy0ppF4xZTRa853r4N6CEtu77u7p6QxZAjywZ1g0VaY0w2Ax4/dl5JQuXbb 5enmt0rFOB5Z+0flOG4fPYv1exDM16q8YXWSfpZpkb9eUavtWfvg1UsxWHDb6/id9P6X UThQ== X-Gm-Message-State: AOAM531sbM7TmNNIMpqLZq24P4Q7y5zBcZR29q0Yn0KdKoeHioBq3CK7 yySUa7CFO1ZnzKs5w9y5e3dH5w== X-Google-Smtp-Source: ABdhPJzBn1+hHYrCfYGYXrVxS8zkjZxNp5SjFO3AGPTItBvE3mIES0AjqSuwk/9tZIuSpGxUP+u3sg== X-Received: by 2002:a05:6512:108c:: with SMTP id j12mr12127512lfg.431.1614085886767; Tue, 23 Feb 2021 05:11:26 -0800 (PST) Received: from jade (h-249-223.A175.priv.bahnhof.se. [98.128.249.223]) by smtp.gmail.com with ESMTPSA id p13sm2886020ljj.49.2021.02.23.05.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 05:11:26 -0800 (PST) Date: Tue, 23 Feb 2021 14:11:24 +0100 From: Jens Wiklander To: Jisheng Zhang Subject: Re: [PATCH] tee: optee: add invoke_fn tracepoints Message-ID: <20210223131124.GA2303918@jade> References: <20210210144409.36ecdaed@xhacker.debian> <20210223184026.22c86356@xhacker.debian> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210223184026.22c86356@xhacker.debian> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210223_081128_773854_0909CDD9 X-CRM114-Status: GOOD ( 30.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , op-tee@lists.trustedfirmware.org, Linux Kernel Mailing List , "Steven Rostedt \(VMware\)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 23, 2021 at 06:40:26PM +0800, Jisheng Zhang wrote: > On Tue, 23 Feb 2021 08:59:22 +0100 Jens Wiklander wrote: > > > > > > Hi Jisheng, > > Hi Jens, > > > > > On Wed, Feb 10, 2021 at 7:44 AM Jisheng Zhang > > wrote: > > > > > > Add tracepoints to retrieve information about the invoke_fn. This would > > > help to measure how many invoke_fn are triggered and how long it takes > > > to complete one invoke_fn call. > > > > > > Signed-off-by: Jisheng Zhang > > > --- > > > > > > Since v1: > > > - add BUILD_BUG_ON() macro usage to make sure that the size of what is being > > > copied, is not smaller than the amount being copied. Thank Steve. > > > - move optee_trace.h to keep include headers sorted > > > > > > drivers/tee/optee/call.c | 4 ++ > > > drivers/tee/optee/optee_trace.h | 67 +++++++++++++++++++++++++++++++++ > > > 2 files changed, 71 insertions(+) > > > create mode 100644 drivers/tee/optee/optee_trace.h > > > [snip] > > > diff --git a/drivers/tee/optee/optee_trace.h b/drivers/tee/optee/optee_trace.h > > > new file mode 100644 > > > index 000000000000..7c954eefa4bf > > > --- /dev/null > > > +++ b/drivers/tee/optee/optee_trace.h > > > @@ -0,0 +1,67 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > +/* > > > + * optee trace points > > > + * > > > + * Copyright (C) 2021 Synaptics Incorporated > > > + * Author: Jisheng Zhang > > > + */ > > > + > > > +#undef TRACE_SYSTEM > > > +#define TRACE_SYSTEM optee > > > + > > > +#if !defined(_TRACE_OPTEE_H) || defined(TRACE_HEADER_MULTI_READ) > > > +#define _TRACE_OPTEE_H > > > + > > > +#include > > > +#include > > > +#include "optee_private.h" > > > + > > > > Checkpatch has some complaints below. Is that something that could be > > fixed or is this so far from regular C-syntax that we don't care? > > I tried ./scripts/checkpatch.pl in Linus tree to check the patch, there's > no any error, and except the "MAINTAINERS need updating" warning, there's > no other warnings. > > git log -- scripts/checkpatch.pl > shows the latest checkpatch.pl is at commit 62137364e3e8afcc745846c5c67cacf943149073 > > I'm not sure what happened. I used the -strict option. ./scripts/checkpatch.pl -strict 0001-tee-optee-add-invoke_fn-tracepoints.patch WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #44: new file mode 100644 CHECK: Alignment should match open parenthesis #68: FILE: drivers/tee/optee/optee_trace.h:20: +TRACE_EVENT(optee_invoke_fn_begin, + TP_PROTO(struct optee_rpc_param *param), CHECK: Lines should not end with a '(' #71: FILE: drivers/tee/optee/optee_trace.h:23: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #76: FILE: drivers/tee/optee/optee_trace.h:28: + TP_fast_assign( CHECK: Alignment should match open parenthesis #89: FILE: drivers/tee/optee/optee_trace.h:41: +TRACE_EVENT(optee_invoke_fn_end, + TP_PROTO(struct optee_rpc_param *param, struct arm_smccc_res *res), CHECK: Lines should not end with a '(' #92: FILE: drivers/tee/optee/optee_trace.h:44: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #97: FILE: drivers/tee/optee/optee_trace.h:49: + TP_fast_assign( total: 0 errors, 1 warnings, 6 checks, 86 lines checked Thanks, Jens _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel