From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 868AAC433DB for ; Tue, 23 Feb 2021 16:10:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2535364E12 for ; Tue, 23 Feb 2021 16:10:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2535364E12 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QeMBocV3yvUv9tu93Bsiic5OoC+QFXHi6tl0fuoU5FQ=; b=Qxymz3b9hTX2cBsC80+jXCUHn /W0On8QM7um2yECN6n7S4p7zBtnHOIILJ6YBxFE9FWl6ahQot56/9WyHQxCNaQqcn3dyTrD09/OHc TRwW85VsUc1TgTUtRKLIDXWP2ERM+PsGYQjyunfpwwGIZh8wDivI4XHiumgZWLmTSw30QELfVIQ3x uKwCzoxPyLIQR/HHlc7Cn4kR7XUNmT9bDtYJwDsruclYlsCE9TCRrS7cMct+nEBP23mIIVjJiHG9W MBg26z+KSvzjOsvs43j5mYUaQl9NCGScA/IOdyml79H86zQARjpipWRogUQ1wP0fV4FsaiiShR/xV KUK0poibA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEaFj-0007bP-EU; Tue, 23 Feb 2021 16:09:35 +0000 Received: from netrider.rowland.org ([192.131.102.5]) by merlin.infradead.org with smtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEaFg-0007b2-SS for linux-arm-kernel@lists.infradead.org; Tue, 23 Feb 2021 16:09:33 +0000 Received: (qmail 1264834 invoked by uid 1000); 23 Feb 2021 11:09:32 -0500 Date: Tue, 23 Feb 2021 11:09:32 -0500 From: Alan Stern To: =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas Subject: Re: [PATCH 1/2] dt-bindings: usb: generic-ehci: document ignore-oc flag Message-ID: <20210223160932.GD1261797@rowland.harvard.edu> References: <20210223155005.21712-1-noltari@gmail.com> <20210223155005.21712-2-noltari@gmail.com> <20210223155443.GB1261797@rowland.harvard.edu> <54E1894F-C8D8-4E2F-92DF-DC891153BAAB@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <54E1894F-C8D8-4E2F-92DF-DC891153BAAB@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210223_110933_004403_3338F652 X-CRM114-Status: GOOD ( 23.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Florian Fainelli , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Rob Herring , Jonas Gorski , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 23, 2021 at 05:04:57PM +0100, =C1lvaro Fern=E1ndez Rojas wrote: > Hi Alan, > = > > El 23 feb 2021, a las 16:54, Alan Stern esc= ribi=F3: > > = > > On Tue, Feb 23, 2021 at 04:50:04PM +0100, =C1lvaro Fern=E1ndez Rojas wr= ote: > >> Over-current reporting isn't supported on some platforms such as bcm63= xx. > >> These devices will incorrectly report over-current if this flag isn't = properly > >> activated. > >> = > >> Signed-off-by: =C1lvaro Fern=E1ndez Rojas > >> --- > >> Documentation/devicetree/bindings/usb/generic-ehci.yaml | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> = > >> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b= /Documentation/devicetree/bindings/usb/generic-ehci.yaml > >> index cf83f2d9afac..294bbf02399e 100644 > >> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > >> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > >> @@ -117,6 +117,11 @@ properties: > >> Set this flag if EHCI has a Transaction Translator built into > >> the root hub. > >> = > >> + ignore-oc: > >> + $ref: /schemas/types.yaml#/definitions/flag > >> + description: > >> + Set this flag for HCDs without over-current reporting support. > > = > > This is not a good description of a device property. DT entries are = > > supposed to described the hardware, not talk about how to use it. > = > Any suggestions on a proper description? > = > > = > > When you say that the bcm63xx doesn't support over-current reporting, = > > what exactly do you mean? Do you mean that sometimes the hardware turn= s = > > on the over-current bit when an over-current isn't actually present? O= r = > > do you mean something else? > = > Yes, the hardware turns on the over-current bit with no over-current pres= ent. Okay, in that case the property should be named something like = "spurious_oc", and the description should say something like: Set this flag to indicate that the hardware sometimes turns on = the OC bit when an over-current isn't actually present. Alan Stern _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel