From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C325EC433E0 for ; Wed, 24 Feb 2021 14:06:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C8BE64E2B for ; Wed, 24 Feb 2021 14:06:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C8BE64E2B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XHXl4FqEt2twLxJlIi32C09Y1GqDD+qkjpVcY6qgj3E=; b=bkj2T3tAngSYaBag7okHKndCd U/t2p/nJPE7HKDL22oMpwOS5xs4JWZb3Ff6gLtPQiIDDo6Yc9zHIRvzMxrDVI2W7dQKOq9DODSA+r GBGD8eimj+LXx6n5JG1W31ygoNZZ56QWyeOrDp5Fbehqbi8ohqhFqL1SprtnEPEn/2dksQovCnR0C xSzJoXmkLkEd9GEk5eTNwNyc+WlYDksfDXSZIKKwP3z9XXsxJtEHpKQ/LX3gfbfIutsmRTlUBAVnw pG5o6TjhvXhk+3SVmUHySGk5HtKB7P2/+sa8atv+3oSHXab2rgXcfDiHl4UwB3272Y+Z2UpXsNLK8 m2YF7O5+Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEulp-0001Op-Kx; Wed, 24 Feb 2021 14:04:05 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEulm-0001OT-WC for linux-arm-kernel@lists.infradead.org; Wed, 24 Feb 2021 14:04:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FKo27kP6bPoTFaEgNUhT3kOhszGvSDXkiGvKHnLVuc4=; b=v88BLMp8Jlv/IhPa0X6p6VPq/ iKsgGbnhHi3O5dmWqDdE8DnAzITrnXxTLp38at5EWC5cV1s9AkLODNcoVUSMHAtON2JrEP5nxozhx pBW9ThJ+07++O5wqpXsFhDPy36Sf6JIEoxvn3e0rjcWQgA6rYfdGUIgmoWd8icvwNBVlYBXykGaem UCDdMcfOjSlivEo/CA2tXZgMrYjejVsjNOyoxuZnDlpqGDO2RdeQyY3zDWral1voZ404FL4gI4MeF tUmuL2Qfr/Wf8WcgWfTgJJuuu8bKQAjx5eLoWMdpB6wIPybw+oN0+6EW9eIStAcaUhdFVSl7Fgwuz NM9TLTFwQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46656) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEulb-00005z-Dn; Wed, 24 Feb 2021 14:03:51 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lEulX-00042p-Ej; Wed, 24 Feb 2021 14:03:47 +0000 Date: Wed, 24 Feb 2021 14:03:47 +0000 From: Russell King - ARM Linux admin To: Maninder Singh Subject: Re: [PATCH 1/1] arm: print alloc free paths for address in registers Message-ID: <20210224140347.GS1463@shell.armlinux.org.uk> References: <1614170254-3207-1-git-send-email-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1614170254-3207-1-git-send-email-maninder1.s@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210224_090403_691419_F9371AE1 X-CRM114-Status: GOOD ( 10.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vaneet Narang , a.sahrawat@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, penberg@kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, rientjes@google.com, cl@linux.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 24, 2021 at 06:07:34PM +0530, Maninder Singh wrote: > +bool slab_page_object(unsigned long address, void **object, struct kmem_cache **cache) > +{ > + void *addr = (void *)address; > + struct page *page; > + > + if ((addr >= (void *)PAGE_OFFSET) && > + (addr < high_memory)) { > + page = virt_to_head_page(addr); This check is not sufficient. There can be holes in the page array. You need to use virt_addr_valid() to validate "addr". -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel