From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA0A8C433E0 for ; Thu, 25 Feb 2021 17:59:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B6E364F56 for ; Thu, 25 Feb 2021 17:59:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B6E364F56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jJC1fAda77azfjkAazBB//BcUF10VWbc067gD1+Zisc=; b=pR2tPQ9JeV8OmVvl7faQH6Z5q PgCng3LRwfnpGJR9k66ARTMkVzKqbiXjHCMfmR9ZYVjS5DtCvuvbQw7zcAzBPIbJksv93eroSx83p G9HNGqu9cdDIwXKJeJ8dY9yOFAExyO6M/+siUnaP6o970jiWDTMdswdn0ltYvOWGR6fY04JNI12OS p6dCg4hKHXFCKyxfbPFiZBMJR1aAbkRrWNhGTTH5+hKTKivmMAhNpB4DS0Quri3WgVsGd0mb/QiUa wqblidbZnoNWIzYYTKC921WY5Y13ypIVa+UVh/BGxemkIi7ajzgsCf2de7+KgocScdSpyMOcS6fhA u6tJfkoaw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFKuP-0007Un-Ow; Thu, 25 Feb 2021 17:58:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFKuN-0007UL-Th; Thu, 25 Feb 2021 17:58:40 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F73964DE8; Thu, 25 Feb 2021 17:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614275918; bh=kkEUBtk21fzvQ+eByMWisdjrqhC+DKiVgrkLgH0ss/M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ev8I77FFegc2EdWHko9oWR26IKdMF6+y2de4p0n8wL3eoj2h3N3kPlco84vQb4Ua2 I/ND8Raybh6OjAgIDKQwYtn4/Rub1R8ufc/dK8Yhrhii8kQVKhbB+YzPyhAYxCALSR EKpalFu3yn6QUgcNqEa/yQAZ4LJQt/nzdNd/6GOnq0xGbP/r06vVf56CG1LtWR8I/n cx3rE5IpLMAQOe+tYk/kI+BcNjTfj50Wolh+y2bxxyIaM+ZQ/tXDyJQfR/yc25JENz +//LzlT/UmhktjLycSIn5K0hWtTI6pq4vw2kQL39hWP/iBJjT4qCw1jmRXDKnK24eR PyUCV6l4hRGzw== Date: Thu, 25 Feb 2021 10:58:36 -0700 From: Nathan Chancellor To: Arnd Bergmann Subject: Re: [PATCH 1/2] mt76: mt7915: fix unused 'mode' variable Message-ID: <20210225175836.GA23011@24bbad8f3778> References: <20210225145953.404859-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210225145953.404859-1-arnd@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210225_125840_058331_96FCE3DF X-CRM114-Status: GOOD ( 19.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryder Lee , Arnd Bergmann , clang-built-linux@googlegroups.com, linux-wireless@vger.kernel.org, Sean Wang , Nick Desaulniers , linux-kernel@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Lorenzo Bianconi , Jakub Kicinski , Shayne Chen , "David S. Miller" , Kalle Valo , Felix Fietkau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 25, 2021 at 03:59:14PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang points out a possible corner case in the mt7915_tm_set_tx_cont() > function if called with invalid arguments: > > drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable 'mode' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] > default: > ^~~~~~~ > drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:597:13: note: uninitialized use occurs here > rateval = mode << 6 | rate_idx; > ^~~~ > drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:506:37: note: initialize the variable 'mode' to silence this warning > u8 rate_idx = td->tx_rate_idx, mode; > ^ > > Change it to return an error instead of continuing with invalid data > here. > > Fixes: 3f0caa3cbf94 ("mt76: mt7915: add support for continuous tx in testmode") > Signed-off-by: Arnd Bergmann > --- > drivers/net/wireless/mediatek/mt76/mt7915/testmode.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c > index 7fb2170a9561..aa629e1fb420 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c > @@ -543,6 +543,7 @@ mt7915_tm_set_tx_cont(struct mt7915_phy *phy, bool en) > tx_cont->bw = CMD_CBW_20MHZ; > break; > default: > + return -EINVAL; Remove the break if we are adding a return? > break; > } > > @@ -591,6 +592,7 @@ mt7915_tm_set_tx_cont(struct mt7915_phy *phy, bool en) > mode = MT_PHY_TYPE_HE_MU; > break; > default: > + return -EINVAL; > break; > } > > -- > 2.29.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel