From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03EA2C433DB for ; Thu, 25 Feb 2021 18:52:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8555D64F36 for ; Thu, 25 Feb 2021 18:52:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8555D64F36 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:To:From: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=40kxEZNwRN9IEscbiYth/hc+rsfre73cZNATtkTiP1M=; b=3Y+RMTEDb6gAdogqo+gzYYufC VxahhehqQ+PW6cYVbLILhi0i4WtV5XZoSqEvEA911VpxYEDog969a1mePBgE2+SxmIp6LiypPer5t APjbZZM1IOkiBDH+lajfdRcrv+4n2E3lB4wSnnI/15JZYBs5/2d/7Es4qjrulwuucMsG/d2vfAdu1 RF5z+hqoZZoJeX74gDAZgMK5EilRiKUOnFtqyW/uWBTsFCVE5EH5B7REZ1RZ1fGRHTdRFVF1goTfY 63TXQowRPaQ9woAh7QstpM/qpHkqMh4OCNB424FVgU/mtO5JO3qgz2lpkidvgsNDW3DSChMJTZXCP rAjqowUeA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFLj8-0003oF-Hh; Thu, 25 Feb 2021 18:51:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFLj6-0003nt-C4 for linux-arm-kernel@lists.infradead.org; Thu, 25 Feb 2021 18:51:05 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 36ED564F29; Thu, 25 Feb 2021 18:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614279062; bh=MmXrhKpXug2McN3faWeNdMvPLMny3JE46p+2y9M4jYU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=tytnpNQr52fVeD5UQJXFycNDm0X6Ocao34AL65DEC6a+iG2/MZ+Qj565eQzTXlX/3 zCeEaZ4JSeqnHyAZXnSefl2gdKz+jS8OM8zCAwXyZ1SmrOPQ4A9/Lcjamo3968lK2Y IcfGhu3NLdcWT7STywQ+jIhyL0p8cxkEEovqh+vyXaK1ZOG48MvsHmb4E0zQ5ktHdT 5YR2/Rd5lN+vAdrXzNqyFZ36/bko9g8aBLWtcMufNPHIZn6p05xxSFuZg+T5tbb8wY yaWK/2o0zYB/3gZ+jh0iV9qTXvTccifOAUMj9h6sdr+YEKCJ7NTKA9CG/9K/w1G2qc wBMT85rLFuasQ== Date: Thu, 25 Feb 2021 12:51:00 -0600 From: Bjorn Helgaas To: "Kuppuswamy, Sathyanarayanan" Subject: Re: [PATCH 1/2] PCI: controller: thunder: fix compile testing Message-ID: <20210225185100.GA17711@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210225_135104_493762_B74EDADE X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Lorenzo Pieralisi , Robert Richter , Arnd Bergmann , Rob Herring , linux-pci@vger.kernel.org, Catalin Marinas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-kernel@vger.kernel.org, Yicong Yang , Qiuxu Zhuo , "David E. Box" , Jonathan Cameron , Bjorn Helgaas , Sean V Kelley , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 25, 2021 at 09:44:12AM -0800, Kuppuswamy, Sathyanarayanan wrote: > On 2/25/21 6:37 AM, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > Compile-testing these drivers is currently broken. Enabling > > it causes a couple of build failures though: > > > > drivers/pci/controller/pci-thunder-ecam.c:119:30: error: shift count >= width of type [-Werror,-Wshift-count-overflow] > > drivers/pci/controller/pci-thunder-pem.c:54:2: error: implicit declaration of function 'writeq' [-Werror,-Wimplicit-function-declaration] > > drivers/pci/controller/pci-thunder-pem.c:392:8: error: implicit declaration of function 'acpi_get_rc_resources' [-Werror,-Wimplicit-function-declaration] > > > > Fix them with the obvious one-line changes. > Looks good to me. Thanks for looking this over! I'd like to acknowledge your review, but I need an explicit Reviewed-by or similar. I don't want to put words in your mouth by converting "Looks good to me" to "Reviewed-by". _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel