From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB5AC433DB for ; Fri, 26 Feb 2021 04:09:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E34E564EDC for ; Fri, 26 Feb 2021 04:09:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E34E564EDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9nR6lmpDEovP0HWeR++a9clTSQH9Rfn+NtuezkSnVbA=; b=ze0PmO4sgBQSCLlYrK13Y/t4r WtVzjIwarIqoHy+E6w77IVYCA+oKceg/3xPcv2VeGqVCNE1QqpnUZMZxrN3P2+UdP7mujBiNZ6ExF sY7Dv72+nKm4huE7H4R+vUhEyuM7yJxHCbef/qfnDmtKFrg9YvmlcH8v0dIQSvkcoumKZyFoAkoPC KTtXLVfuZj1IQLH8dNuKmB9gmvX1Nk3UdwNkW74W4P97FWOA9OsQilORpjNHknnodbGtTvPcYwSEu Z8cWlVx3g7YN3V/AFMvbTLHVJyOCF8aI/RvQrpps2L3Lf8I6EMzVJtgdHvRskjpxiaXQJ4wp7GngR ByS1P/71w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFUPK-0005hy-Sz; Fri, 26 Feb 2021 04:07:14 +0000 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFUPH-0005hI-G7 for linux-arm-kernel@lists.infradead.org; Fri, 26 Feb 2021 04:07:12 +0000 Received: by mail-qt1-x82b.google.com with SMTP id c1so5887851qtc.1 for ; Thu, 25 Feb 2021 20:07:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VNgVP5bO+x0vJy5odPkV2uB2UEUJ5Qp9L2ilIKOZuM0=; b=R7Tm6zfTEojM846VH5x9z6bj2dYJBkSaEVL27dcTk9dMrKOhGWHlwjCoh+psbk3uQQ 6KDYjOHUyteQGwmqOphNoxyRmnIDVNLigOwILPaZ+sePyn2Zr8g9NmrbRYggr3Jm/kj5 PNaanpcSQmFfzUgSJE1RRR9JQabCKTx50/4BiAZBFNP06vBRuYv6whvhEkDC6bns8av6 M/JZ/cIO4SMsyGRwMJMEs2sIlwqY3cPClskP+ZHMOe7tR+3CiR2avsQ5usD7CMHn6joS FhAuvHxwP/CkhiRwMXjTQkhkjKq2kj/pczc/Vrpf3LefI7aZMUebr53pUEdT3R6XFJSJ CFuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VNgVP5bO+x0vJy5odPkV2uB2UEUJ5Qp9L2ilIKOZuM0=; b=WKGwctF6Y/Xyl0Q5QCJ3uDArjOi5l52XbhC93//5GsNgb2o7jp5HjNZgQEiZbU04Im kLVwbmyAv10Vz9cbPXiztaW92GKvnUxrL0hgfRvKgpzjjmzYbq6CwweJw9Y45sotHwAt SoNr/Q3NjoGwKN7+2qtqjvo+zaazWtzeT8J8iODAfVCNi39ud4QQOtPSnBxbs8vcyOpg VaKboeU7fd0NpUSsp2DTdturVLu2tEojcL6evPuwph8kidSNRFFi18sRUkwc+JxnX9FD eqcXMKOA1ATlX+koPkijnAmUOsNQ+Vua4+exzQx5APwYzsUkQW5WHoUqN974TkrvH5dy HyYg== X-Gm-Message-State: AOAM531Q3hGkjrd6YWJFX0kfWp9NL0SdtJ15vgdlGSq5gSNKTAOrtG6W dOREC7OCS6Ut5RrDZWwNVVE= X-Google-Smtp-Source: ABdhPJzrXnJVeX5vcyvuCgBKuy7gwJQV4Gg2l/0ma11hXSewE9YNqnUiTmwzN3aclIIWVb0LZemIJw== X-Received: by 2002:aed:3fc5:: with SMTP id w5mr1337679qth.76.1614312429586; Thu, 25 Feb 2021 20:07:09 -0800 (PST) Received: from localhost (d27-96-190-162.evv.wideopenwest.com. [96.27.162.190]) by smtp.gmail.com with ESMTPSA id u133sm5531844qka.116.2021.02.25.20.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Feb 2021 20:07:09 -0800 (PST) Date: Thu, 25 Feb 2021 20:07:08 -0800 From: Yury Norov To: Huacai Chen Subject: Re: [PATCH 2/2] MIPS: enable GENERIC_FIND_FIRST_BIT Message-ID: <20210226040708.GA1427525@yury-ThinkPad> References: <20210225135700.1381396-1-yury.norov@gmail.com> <20210225135700.1381396-3-yury.norov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210225_230711_599971_4E0F1CD4 X-CRM114-Status: GOOD ( 22.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Thomas Bogendoerfer , Alexander Lobakin , Catalin Marinas , LKML , "open list:MIPS" , Alexey Klimov , Will Deacon , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 26, 2021 at 09:22:18AM +0800, Huacai Chen wrote: > Hi, Yury, > > On Thu, Feb 25, 2021 at 9:59 PM Yury Norov wrote: > > > > From: Alexander Lobakin > > > > MIPS doesn't have architecture-optimized bitsearching functions, > > like find_{first,next}_bit() etc. > Emm, I think MIPS can use clo/clz to optimize bitsearching functions. find_{first,next}_bit() is about manipulating the bitmaps bigger that a single word, and some arches (arm) implement their own find_bit() functions. find_bit() is not a replacement of __ffs() and ffz(). > Huacai > > > It's absolutely harmless to enable GENERIC_FIND_FIRST_BIT as this > > functionality is not new at all and well-tested. It provides more > > optimized code and saves some .text memory (32 R2): > > > > add/remove: 4/1 grow/shrink: 1/53 up/down: 216/-372 (-156) > > > > Users of for_each_set_bit() like hotpath gic_handle_shared_int() > > will also benefit from this. > > > > Suggested-by: Yury Norov > > Signed-off-by: Alexander Lobakin > > Signed-off-by: Yury Norov > > --- > > arch/mips/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > > index d89efba3d8a4..164bdd715d4b 100644 > > --- a/arch/mips/Kconfig > > +++ b/arch/mips/Kconfig > > @@ -26,6 +26,7 @@ config MIPS > > select GENERIC_ATOMIC64 if !64BIT > > select GENERIC_CMOS_UPDATE > > select GENERIC_CPU_AUTOPROBE > > + select GENERIC_FIND_FIRST_BIT > > select GENERIC_GETTIMEOFDAY > > select GENERIC_IOMAP > > select GENERIC_IRQ_PROBE > > -- > > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel