From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Mike Leach <mike.leach@linaro.org>
Cc: "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Yabin Cui <yabinc@google.com>,
Coresight ML <coresight@lists.linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tingwei Zhang <tingwei@codeaurora.org>,
Leo Yan <leo.yan@linaro.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 02/10] coresight: syscfg: Add registration and feature loading for cs devices
Date: Sat, 27 Feb 2021 13:52:09 -0700 [thread overview]
Message-ID: <20210227205209.GA3631443@xps15> (raw)
In-Reply-To: <CAJ9a7Vhh5xdbmMgcTLjU3qJEg2nbZoZ5j2HqvenwNGoqo+54Rw@mail.gmail.com>
On Fri, Feb 26, 2021 at 07:14:32PM +0000, Mike Leach wrote:
> Hi Mathieu,
>
> On Fri, 19 Feb 2021 at 18:43, Mathieu Poirier
> <mathieu.poirier@linaro.org> wrote:
> >
> > [...]
> >
> > > +/**
> > > + * List entry for Coresight devices that are registered as supporting complex
> > > + * config operations.
> > > + *
> > > + * @csdev: The registered device.
> > > + * @match_info: The matching type information.
> > > + * @ops: Operations supported by the registered device.
> > > + * @item: list entry.
> > > + */
> > > +struct cscfg_csdev_register {
> > > + struct coresight_device *csdev;
> > > + struct cscfg_match_desc match_info;
> > > + struct cscfg_csdev_feat_ops ops;
> > > + struct list_head item;
> > > +};
> >
> > I would call this structure cscfg_registered_csdev and move it to
> > coresight-config.h. That way it is consistent with cscfg_config_csdev and
> > cscfg_feature_csdev and located all in the same file.
> >
>
> I was trying to separate structures that are used to define
> configurations and features, with those that are used to manage the
> same. Hence, most things in coresight_config.h define configurations,
> or their device loaded instance equivalents, and things in
> coresight_syscfg.h are management items. I am happy to change the name
> but would prefer is stay in coresight_syscfg.h
Ok
>
> Thanks
>
> Mike
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-27 20:54 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 17:09 [PATCH v4 00/10] CoreSight configuration management; ETM strobing Mike Leach
2021-01-28 17:09 ` [PATCH v4 01/10] coresight: syscfg: Initial coresight system configuration Mike Leach
2021-02-18 23:52 ` Mathieu Poirier
2021-02-26 19:09 ` Mike Leach
2021-02-22 18:50 ` Mathieu Poirier
2021-02-26 19:10 ` Mike Leach
2021-03-03 10:09 ` Suzuki K Poulose
2021-03-03 15:12 ` Mike Leach
2021-03-03 10:23 ` Suzuki K Poulose
2021-03-04 10:08 ` Suzuki K Poulose
2021-03-04 10:47 ` Mike Leach
2021-03-04 10:48 ` Suzuki K Poulose
2021-01-28 17:09 ` [PATCH v4 02/10] coresight: syscfg: Add registration and feature loading for cs devices Mike Leach
2021-02-19 18:43 ` Mathieu Poirier
2021-02-26 19:14 ` Mike Leach
2021-02-27 20:52 ` Mathieu Poirier [this message]
2021-02-22 17:37 ` Mathieu Poirier
2021-02-26 19:16 ` Mike Leach
2021-02-22 19:05 ` Mathieu Poirier
2021-03-04 10:33 ` Suzuki K Poulose
2021-03-16 18:00 ` Mike Leach
2021-01-28 17:09 ` [PATCH v4 03/10] coresight: config: Add configuration and feature generic functions Mike Leach
2021-02-22 22:57 ` Mathieu Poirier
2021-03-04 11:25 ` Suzuki K Poulose
2021-01-28 17:09 ` [PATCH v4 04/10] coresight: etm-perf: update to handle configuration selection Mike Leach
2021-02-24 18:33 ` Mathieu Poirier
2021-02-26 19:26 ` Mike Leach
2021-03-04 12:13 ` Suzuki K Poulose
2021-03-04 14:19 ` Mike Leach
2021-03-04 14:25 ` Suzuki K Poulose
2021-03-04 14:46 ` Mike Leach
2021-01-28 17:09 ` [PATCH v4 05/10] coresight: syscfg: Add API to activate and enable configurations Mike Leach
2021-02-25 21:20 ` Mathieu Poirier
2021-02-25 21:46 ` Mathieu Poirier
2021-02-26 20:08 ` Mike Leach
2021-03-04 16:49 ` Suzuki K Poulose
2021-03-04 18:15 ` Mike Leach
2021-01-28 17:09 ` [PATCH v4 06/10] coresight: etm-perf: Update to activate selected configuration Mike Leach
2021-02-25 21:51 ` Mathieu Poirier
2021-02-26 20:09 ` Mike Leach
2021-03-04 16:50 ` Suzuki K Poulose
2021-01-28 17:09 ` [PATCH v4 07/10] coresight: etm4x: Add complex configuration handlers to etmv4 Mike Leach
2021-02-28 23:19 ` Mathieu Poirier
2021-03-05 10:18 ` Suzuki K Poulose
2021-03-17 15:04 ` Mike Leach
2021-01-28 17:09 ` [PATCH v4 08/10] coresight: config: Add preloaded configurations Mike Leach
2021-02-28 23:25 ` Mathieu Poirier
2021-03-05 13:39 ` Suzuki K Poulose
2021-01-28 17:09 ` [PATCH v4 09/10] coresight: syscfg: Add initial configfs support Mike Leach
2021-03-01 0:02 ` Mathieu Poirier
2021-03-01 0:04 ` Mathieu Poirier
2021-01-28 17:09 ` [PATCH v4 10/10] coresight: docs: Add documentation for CoreSight config Mike Leach
2021-02-18 21:28 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210227205209.GA3631443@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=corbet@lwn.net \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei@codeaurora.org \
--cc=yabinc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).