From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3635C433DB for ; Sat, 27 Feb 2021 20:54:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CD3564E10 for ; Sat, 27 Feb 2021 20:54:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CD3564E10 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=awwUzGU0dNgUr06CN/avx4Y+HzkPj0lYB3llUuiohMM=; b=lDFokEydmlfdmS8QvPBTJUA/m 6czamOTzd7qhVjHUGF2G8FwTjm1eKZqirCPYSKo2DFvXmcdgNpSm/GV5fJdtrzu3XXsUjJfvvERuv XS3oicTan0MblreBHrwM8ECIGqpbbHJOwjIgX9xTEwxS41B6++RRR0ItU9Jch/5HZgQok8YUDPO/O UmVBlRB0mx5F/0LsCh4pDjo/Dgml2Ks16+RCYMcCUKWBxqduySxj3ayIcDkC4rLqJF5aFa4nvw0m5 Ki5R2azMfUY2F3vGCy+xPuja1JAKAd/4t0pkoDyTBFYSkwVvOE7tMwZNgAEDahjjh7YZgJ7U6gzWM xS84LacUw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lG6Zb-00065S-BF; Sat, 27 Feb 2021 20:52:23 +0000 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lG6ZY-000651-9T for linux-arm-kernel@lists.infradead.org; Sat, 27 Feb 2021 20:52:21 +0000 Received: by mail-pg1-x52c.google.com with SMTP id h4so8444445pgf.13 for ; Sat, 27 Feb 2021 12:52:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iCzhTX7/J8HDQ1NmWTMdWfXjqfGCQtFahBty74znwas=; b=bhR2WP0pAVjerTSc3Rgc0a6ag6fD1FIwlK5OasyrGOmEs5qUpPYQHB2tOjhkS6+fc2 859p06Z6DP1gtVh6ncx1lDLCHFguWhixSY8MaYQ84AzHci6WffISq2cKUg/5pkw9Yhyt ZfSmHTVP36H8PoLttcRMKsITjjZ+ldS55n1gqqvTSfwBP5UIcoadqmtvT7N8MuWb7aUB FErkDr7cMDHUDvQebKhHbGCpYuinji9Pf+dLIM1Y1/t9/OCV6VRAd49iY1yhQE12boGg opXZ+4SMwMnt58d0NLxBfgNSa1pEiaNuCINUqgM2yXoO3z6BfdlUoCzo3BlOow2Hxq+9 Y2BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iCzhTX7/J8HDQ1NmWTMdWfXjqfGCQtFahBty74znwas=; b=pWGYiJPFLfnlxCel/pkMSUCglyzSKht0WHCmKvKmyYpgn1QXY1IaIrE3SZBfO1rp1E Vj7MLJtedy0aDpwDD8bKcx+FAwVqTLkaMHw9XscVZz9++rNS2cnLndLRfMtHXfJcqeKB 0D3LEKeoZd0t4wFS5b5J5OzwfUvEvvFs1TUnjsAIzoFTabvgCWL0VKdKG2sZFML16iQF G3NbPJC2NKjIEwymTeGERXA0JplajjnIKuYLUrASVUGZzYzoSKQA781Z1WyPUQDZHQx7 ibxutVbnyReuO70CUIVOou4VyMA3s7tS2HDLFO2sqfIUkq6YJgPA4K2ERtexNh2oNgQS qDdg== X-Gm-Message-State: AOAM531+Nu9oIaTo923LMGe+cRTkoPJnzzuHV+qC7rx3N/7BFtYu/eCD OZFGdTJCLTnkSbGPbgIg4NRUhQ== X-Google-Smtp-Source: ABdhPJwIUTl7xvSqFvF7pALtDLpFq8SMPiddit6YCRp3lTejTLgNoH4UqOhZFykBAvPKRzFw3aE6bQ== X-Received: by 2002:a63:2110:: with SMTP id h16mr8015755pgh.441.1614459133593; Sat, 27 Feb 2021 12:52:13 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id 192sm10432202pfx.193.2021.02.27.12.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Feb 2021 12:52:12 -0800 (PST) Date: Sat, 27 Feb 2021 13:52:09 -0700 From: Mathieu Poirier To: Mike Leach Subject: Re: [PATCH v4 02/10] coresight: syscfg: Add registration and feature loading for cs devices Message-ID: <20210227205209.GA3631443@xps15> References: <20210128170936.9222-1-mike.leach@linaro.org> <20210128170936.9222-3-mike.leach@linaro.org> <20210219184313.GA3065106@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210227_155220_624385_A6CF87F5 X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Suzuki K. Poulose" , Alexander Shishkin , Yabin Cui , Coresight ML , Jonathan Corbet , "open list:DOCUMENTATION" , Greg Kroah-Hartman , Linux Kernel Mailing List , Tingwei Zhang , Leo Yan , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 26, 2021 at 07:14:32PM +0000, Mike Leach wrote: > Hi Mathieu, > > On Fri, 19 Feb 2021 at 18:43, Mathieu Poirier > wrote: > > > > [...] > > > > > +/** > > > + * List entry for Coresight devices that are registered as supporting complex > > > + * config operations. > > > + * > > > + * @csdev: The registered device. > > > + * @match_info: The matching type information. > > > + * @ops: Operations supported by the registered device. > > > + * @item: list entry. > > > + */ > > > +struct cscfg_csdev_register { > > > + struct coresight_device *csdev; > > > + struct cscfg_match_desc match_info; > > > + struct cscfg_csdev_feat_ops ops; > > > + struct list_head item; > > > +}; > > > > I would call this structure cscfg_registered_csdev and move it to > > coresight-config.h. That way it is consistent with cscfg_config_csdev and > > cscfg_feature_csdev and located all in the same file. > > > > I was trying to separate structures that are used to define > configurations and features, with those that are used to manage the > same. Hence, most things in coresight_config.h define configurations, > or their device loaded instance equivalents, and things in > coresight_syscfg.h are management items. I am happy to change the name > but would prefer is stay in coresight_syscfg.h Ok > > Thanks > > Mike > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel