From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5416C433DB for ; Mon, 1 Mar 2021 15:19:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6B3464E40 for ; Mon, 1 Mar 2021 15:19:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6B3464E40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V5Wx85nwcPtRK8ogHc/57cRRTIsQDBNv870ViT9kaWo=; b=x5fKzUaLaBQWn9Xum31eulJQW Xq20S7LxLidxbTleNdJqNgfd+u38XxxNjuajQIC62rENOcSFiWjw5L7mHp/uOyDpPDOeiqL3NN1IA v4Dg7EyYStf3ii/+jmb4AoLDd6Lu1ICevdlr+x9ndoa15r6NG9pydTox/ifmtNQb24pof+ngWvP8K uUJy7Be9iPCbMJ8+rpUkM5aRx768p9wDpdo2myr7feqD0n4IxCRix48H2UoQJQWQpkfjI4CdzFKPm gJeJaDjkyZ4ip6LicG9V/BWMeP+Alt0DOPekTP9hR+7yhf7wLcHeaRhQ7Gr6BxKNgUXvdTlkOVOAN KD1dF5YsQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lGkJE-0001Tw-JU; Mon, 01 Mar 2021 15:18:08 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lGkJB-0001TC-Fo for linux-arm-kernel@lists.infradead.org; Mon, 01 Mar 2021 15:18:06 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E672D600CC; Mon, 1 Mar 2021 15:18:02 +0000 (UTC) Date: Mon, 1 Mar 2021 15:18:00 +0000 From: Catalin Marinas To: Anshuman Khandual Subject: Re: [PATCH] arm64/mm: Drop THP conditionality from FORCE_MAX_ZONEORDER Message-ID: <20210301151759.GC3250@arm.com> References: <1614597914-28565-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1614597914-28565-1-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210301_101805_597425_FE52268C X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Steve Capper Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 01, 2021 at 04:55:14PM +0530, Anshuman Khandual wrote: > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 9cd33c7be429..d4690326274a 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1156,8 +1156,8 @@ config XEN > > config FORCE_MAX_ZONEORDER > int > - default "14" if (ARM64_64K_PAGES && TRANSPARENT_HUGEPAGE) > - default "12" if (ARM64_16K_PAGES && TRANSPARENT_HUGEPAGE) > + default "14" if ARM64_64K_PAGES > + default "12" if ARM64_16K_PAGES > default "11" > help > The kernel memory allocator divides physically contiguous memory I think this makes sense. The original "14" was added by Steve C in commit d03bb1455f3a ("ARM64: mm: Raise MAX_ORDER for 64KB pages and THP.") back in 3.11. It looks like hugetlbfs (and the HUGETLB_PAGE_ORDER definition) was added in the same kernel but we somehow missed the !TRANSPARENT_HUGEPAGE case and smaller page order. The warning in __fragmentation_index() was added much later in 4.14. Anyway, the patch looks fine to me, we could apply it to some past stable kernels: Acked-by: Catalin Marinas An alternative would have be to add a dependency on both TRANSPARENT_HUGEPAGE and HUGETLB_PAGE but I'm not sure it's worth it. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel