From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D69C8C433E9 for ; Mon, 1 Mar 2021 18:05:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A9B465401 for ; Mon, 1 Mar 2021 18:05:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A9B465401 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K5Tb9cg1uk5udvsVkiLRtG9DHdYPpqPckeE+T7PC7bs=; b=BGzk0t/TS0lSl2W5Rx0pQpfrR VUDliSywQqUtYaaDbs1FxYdCmKtnr/C3ObcUYY6umQWdObcVlrkMBm22FW+wYb8m7DZ3ZzfxF/Ik2 qUV2BbjWMPcbvTGdsZXAnATzpT5ruiC7uqaIxabwzYOEd+FsNmkklLVDOqUcQaI8RKGjkQxkHr00s L/2wKkcWTY2fSCgfPbKuJJqlQe4qhYiH8j3IcfLu6InOelFfqTWk/SI0+SHJAqehZKJxMiKEgdm9N VMQgm4hOGrNXSjoXX02x650bgLNLg0TVx5HGoC0wanpWVipG36QYmUUXRi46gRktHBlJgOJ4wU10I ax8WHAAIg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lGmtq-0005aE-Uo; Mon, 01 Mar 2021 18:04:06 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lGmtn-0005Zo-6t for linux-arm-kernel@lists.infradead.org; Mon, 01 Mar 2021 18:04:04 +0000 Received: by mail-pf1-x432.google.com with SMTP id d12so9489328pfo.7 for ; Mon, 01 Mar 2021 10:04:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Vw5HrvvsSsFIw3Wy5upPbTw/Y96phUPsIzFqKD3AMZc=; b=JcgGjlgT6weg9toZVTlSEzS3XWNR0y0QpIhPSVx+/Wscg59QZFPkw2WZ6u1nueIH/I Z5JELxtGKI1LENZ7DQJlDOisRK6yFbVwut9uOtuFx2aEyOeSYxxklxfvOfr9H0UNCjNs KWUfP41ZZ0Tu/K7ZPdXpqsiAk16SnGE54Erd3MiU64a1WRm1sQie85+Unbh/RLLwepL/ 25kLs/VqUkTxXWaF1cVVHTpuoGYOjP1xn49DHxQ22XT4hCXqwxnq7h1xkENITokzCHRO fy3bihJQAZw4SxK3oJ28FnqRLlyJYzNrEwALqeOdaTNTZ/+T/ZxqSW8biWNlPbGRlQeK YR4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Vw5HrvvsSsFIw3Wy5upPbTw/Y96phUPsIzFqKD3AMZc=; b=pqmP86u/Z9jcGTPcVVM+Kj4lJOvYvhixZ4QUvz2LfAQbGOcZshUbWddeT+k5qDpXyc ZQMM7hqD+amyZvK99LDaXD81ewXxz7I+fR3y0y/8+82pApmdcIvudGnauznqxmwCAsKV x7mPN676WnpsZ5TgSQP4fsI+32PVhKLFAG4rCWUX0HxNnI2AaMwahbTFNOkuI8e/PbvR ZjDp+KjEWiFUVy4qs1P5IKjBUc/+N64IgwrnpFA7W7yfaGRX0z2AA6Rf7tkYrGKq/4vO aFvICTJuKQlNSXZZImUhbb2ZlRZh/E1hONzog7/vuYYcQEDgQno5ugxrPv4xLki6Ev3q 4YBg== X-Gm-Message-State: AOAM53131in93dJcF/JM9qYcHPVvx6N8KQzrFUVzlqW4p6HbH5c2tndX CV5GFXCTS4WDdNbBUIkTUdJAcg== X-Google-Smtp-Source: ABdhPJwAymEQYWV0W9QJQiRK07JIRMar/E1O0kHFE9KdMR8144IIsFpzBqpZxZ4MhS9HV6m247zidA== X-Received: by 2002:a05:6a00:2296:b029:1b6:6972:2f2a with SMTP id f22-20020a056a002296b02901b669722f2amr15841966pfe.69.1614621840869; Mon, 01 Mar 2021 10:04:00 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id np7sm60257pjb.10.2021.03.01.10.03.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Mar 2021 10:03:59 -0800 (PST) Date: Mon, 1 Mar 2021 11:03:57 -0700 From: Mathieu Poirier To: Arnaud POULIQUEN Subject: Re: [PATCH v6 05/16] remoteproc: Add new get_loaded_rsc_table() to rproc_ops Message-ID: <20210301180357.GA3690389@xps15> References: <20210223233515.3468677-1-mathieu.poirier@linaro.org> <20210223233515.3468677-6-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210301_130403_556317_B4A4292C X-CRM114-Status: GOOD ( 33.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, alexandre.torgue@st.com, arnaud.pouliquen@st.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, mcoquelin.stm32@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 26, 2021 at 05:14:36PM +0100, Arnaud POULIQUEN wrote: > Hi Mathieu, > Good morning, > On 2/24/21 12:35 AM, Mathieu Poirier wrote: > > Add a new get_loaded_rsc_table() operation in order to support > > scenarios where the remoteproc core has booted a remote processor > > and detaches from it. When re-attaching to the remote processor, > > the core needs to know where the resource table has been placed > > in memory. > > > > Signed-off-by: Mathieu Poirier > > --- > > New for V6: > > - Don't return an error if a resource table doesn't exist. > > --- > > > > drivers/remoteproc/remoteproc_core.c | 32 ++++++++++++++++++++++++ > > drivers/remoteproc/remoteproc_internal.h | 10 ++++++++ > > include/linux/remoteproc.h | 6 ++++- > > 3 files changed, 47 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > > index 8c7e9f1d50d7..0012b7bdce24 100644 > > --- a/drivers/remoteproc/remoteproc_core.c > > +++ b/drivers/remoteproc/remoteproc_core.c > > @@ -1537,6 +1537,32 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw) > > return ret; > > } > > > > +static int rproc_set_loaded_rsc_table(struct rproc *rproc) > > +{ > > + struct resource_table *table_ptr; > > + struct device *dev = &rproc->dev; > > + size_t table_sz; > > + int ret; > > + > > + table_ptr = rproc_get_loaded_rsc_table(rproc, &table_sz); > > + if (!table_ptr) { > > + /* Not having a resource table is acceptable */ > > + return 0; > > Would it be an over protection to set rproc->table_ptr to NULL here? > I thought about that too but since memory for @rproc is allocated with kzalloc() it wouldn't provide anything more. > else > > Reviewed-by: Arnaud Pouliquen > > Thanks, > Arnaud > > > + } > > + > > + if (IS_ERR(table_ptr)) { > > + ret = PTR_ERR(table_ptr); > > + dev_err(dev, "can't load resource table: %d\n", ret); > > + return ret; > > + } > > + > > + rproc->cached_table = NULL; > > + rproc->table_ptr = table_ptr; > > + rproc->table_sz = table_sz; > > + > > + return 0; > > +} > > + > > /* > > * Attach to remote processor - similar to rproc_fw_boot() but without > > * the steps that deal with the firmware image. > > @@ -1556,6 +1582,12 @@ static int rproc_attach(struct rproc *rproc) > > return ret; > > } > > > > + ret = rproc_set_loaded_rsc_table(rproc); > > + if (ret) { > > + dev_err(dev, "can't load resource table: %d\n", ret); > > + goto disable_iommu; > > + } > > + > > /* reset max_notifyid */ > > rproc->max_notifyid = -1; > > > > diff --git a/drivers/remoteproc/remoteproc_internal.h b/drivers/remoteproc/remoteproc_internal.h > > index c34002888d2c..4f73aac7e60d 100644 > > --- a/drivers/remoteproc/remoteproc_internal.h > > +++ b/drivers/remoteproc/remoteproc_internal.h > > @@ -177,6 +177,16 @@ struct resource_table *rproc_find_loaded_rsc_table(struct rproc *rproc, > > return NULL; > > } > > > > +static inline > > +struct resource_table *rproc_get_loaded_rsc_table(struct rproc *rproc, > > + size_t *size) > > +{ > > + if (rproc->ops->get_loaded_rsc_table) > > + return rproc->ops->get_loaded_rsc_table(rproc, size); > > + > > + return NULL; > > +} > > + > > static inline > > bool rproc_u64_fit_in_size_t(u64 val) > > { > > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h > > index 6b0a0ed30a03..51538a7d120d 100644 > > --- a/include/linux/remoteproc.h > > +++ b/include/linux/remoteproc.h > > @@ -368,7 +368,9 @@ enum rsc_handling_status { > > * RSC_HANDLED if resource was handled, RSC_IGNORED if not handled and a > > * negative value on error > > * @load_rsc_table: load resource table from firmware image > > - * @find_loaded_rsc_table: find the loaded resouce table > > + * @find_loaded_rsc_table: find the loaded resource table from firmware image > > + * @get_loaded_rsc_table: get resource table installed in memory > > + * by external entity > > * @load: load firmware to memory, where the remote processor > > * expects to find it > > * @sanity_check: sanity check the fw image > > @@ -390,6 +392,8 @@ struct rproc_ops { > > int offset, int avail); > > struct resource_table *(*find_loaded_rsc_table)( > > struct rproc *rproc, const struct firmware *fw); > > + struct resource_table *(*get_loaded_rsc_table)( > > + struct rproc *rproc, size_t *size); > > int (*load)(struct rproc *rproc, const struct firmware *fw); > > int (*sanity_check)(struct rproc *rproc, const struct firmware *fw); > > u64 (*get_boot_addr)(struct rproc *rproc, const struct firmware *fw); > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel