From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E908AC433E0 for ; Wed, 3 Mar 2021 18:20:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5989364EEC for ; Wed, 3 Mar 2021 18:20:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5989364EEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4io4sMWoIc6oN2TqbOFodjDima4wB+/6BdZYjj1yZO0=; b=jxcvo0oJg/QMdX1SFxuorz6Tt sSAv6bXhqQyqDBNLfZbQv27Q0ux/FdiKpYWVTKDp8qN1T1J+4QQ1tyNtOLfQMZoEYfjFZ2mxwn+Qa 5D9AHJAJXI37rXfaUJbVKaBtdjYSpU54UUWUkDOKKNYLoSFUl2sRdER4mJD6yyHjzA7l/ort8ocAW 0PmRFcLM+v6pvqfjsTfc0BxdRY89wkxC7Q9a5ihmJoWzpFa/lb7giilb1C1m8xzLDJ8N+vE/tUahs w3sS5u0pZZNLfKtMjl9T8seLcUd2KazkgEZ2rRCYP3xwJIuTb4LMAdhOxw/2aKhgogM/3ucF1BvND 6HnwvxgGw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHW4U-005z65-Vi; Wed, 03 Mar 2021 18:18:07 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHSzj-005GnL-SX for linux-arm-kernel@desiato.infradead.org; Wed, 03 Mar 2021 15:01:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=2PNFKuioXg+dsTbFSmfNgC7L3q5vE+OZRH16KDNi1I4=; b=K5u5Ql4VE/f5uFG/bPKck2Wa63 i1tBj7AU/bJQUUE6v++bfW1FN7zz21znEkNB5n5nmMf8o5sDu48R/7DKym+k1rfpc2OpDUW0I9wVA /DaHW4P9TN9wg+Ma1BNCB56CqCNkSCz1SecFoolK/zrfBuwLNYCTiaPCuAORtoSSM1obCbr6Yt4nY dKgMKrr3SA+yiMEdkP9L+8he60fQ5lSobddEclPQFp17fxXhPD/rNL22TWYdWQEWU2n32E9CJ2nfQ pi5UuQuasByfCw5DiTdC+7qUQhNp2UMdiUOozrgm3cl6h0duujyTXb+CKPED9M8pI0S42pJGvK5xO yDglxidw==; Received: from mail.kernel.org ([198.145.29.99]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lH3eG-00H3D5-Ak for linux-arm-kernel@lists.infradead.org; Tue, 02 Mar 2021 11:57:13 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4338E64F5A; Tue, 2 Mar 2021 11:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614686226; bh=ttBSAstuxahvrv6pryYeHwkR2zP2IIvHIkOm3LxkB/Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EWvWZ0zehZnFwlm1SuPprezHBsNpcwmzCOvBdSRtaniTLtfqhL+SoJcLfMuvjzOxZ UsEkA8Wxf2SWO5St91CBE7pS5yJ6pDKrEyT0SIvA99fo6YeoiwZa5L6yxukR1J+dsg Ja+VSuLSbpkDIHHZ0BL3yTamfHXIAZYWJFcRhPnKSVuKuN0ju80E93E7JooZew3H3F +gvoy4bXJFBq63wPG7N+LVks4UArhn7MVbJInzyE1lxSupNJS+waLyqfuFMWYanRbL PaHfVE+coev1yEL9FEacJOkQ6v7K91A1S8MkQckL3g/N0N2siqV5IMkn0lBCxj4x+R ecZKAb65FBs8g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alain Volmat , Mark Brown , Sasha Levin , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.10 15/47] spi: stm32: make spurious and overrun interrupts visible Date: Tue, 2 Mar 2021 06:56:14 -0500 Message-Id: <20210302115646.62291-15-sashal@kernel.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210302115646.62291-1-sashal@kernel.org> References: <20210302115646.62291-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210302_115713_533173_113E16ED X-CRM114-Status: UNSURE ( 8.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Alain Volmat [ Upstream commit c64e7efe46b7de21937ef4b3594d9b1fc74f07df ] We do not expect to receive spurious interrupts so rise a warning if it happens. RX overrun is an error condition that signals a corrupted RX stream both in dma and in irq modes. Report the error and abort the transfer in either cases. Signed-off-by: Alain Volmat Link: https://lore.kernel.org/r/1612551572-495-9-git-send-email-alain.volmat@foss.st.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-stm32.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index 6017209c6d2f..4bcdad084801 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -928,8 +928,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) mask |= STM32H7_SPI_SR_RXP; if (!(sr & mask)) { - dev_dbg(spi->dev, "spurious IT (sr=0x%08x, ier=0x%08x)\n", - sr, ier); + dev_warn(spi->dev, "spurious IT (sr=0x%08x, ier=0x%08x)\n", + sr, ier); spin_unlock_irqrestore(&spi->lock, flags); return IRQ_NONE; } @@ -956,15 +956,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) } if (sr & STM32H7_SPI_SR_OVR) { - dev_warn(spi->dev, "Overrun: received value discarded\n"); - if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0))) - stm32h7_spi_read_rxfifo(spi, false); - /* - * If overrun is detected while using DMA, it means that - * something went wrong, so stop the current transfer - */ - if (spi->cur_usedma) - end = true; + dev_err(spi->dev, "Overrun: RX data lost\n"); + end = true; } if (sr & STM32H7_SPI_SR_EOT) { -- 2.30.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel