[PATCH] module: remove duplicate include in ./arch/arm/include/asm/pgtable.h

[PATCH] module: remove duplicate include in ./arch/arm/include/asm/pgtable.h

[menglong8.dong]

From: Zhang Yunkai <zhang.yunkai@zte.com.cn>

'asm-generic/pgtable-nopud.h' included in 'pgtable.h' is duplicated.

Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
 arch/arm/include/asm/pgtable.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h
index c02f24400369..f3124e57be83 100644
--- a/arch/arm/include/asm/pgtable.h
+++ b/arch/arm/include/asm/pgtable.h
@@ -9,15 +9,14 @@
 
 #include <linux/const.h>
 #include <asm/proc-fns.h>
+#include <asm-generic/pgtable-nopud.h>
 
 #ifndef CONFIG_MMU
 
-#include <asm-generic/pgtable-nopud.h>
 #include <asm/pgtable-nommu.h>
 
 #else
 
-#include <asm-generic/pgtable-nopud.h>
 #include <asm/memory.h>
 #include <asm/pgtable-hwdef.h>
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] module: remove duplicate include in ./arch/arm/include/asm/pgtable.h

[Geert Uytterhoeven]

On Wed, Mar 3, 2021 at 3:04 AM <menglong8.dong@gmail.com> wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
>
> 'asm-generic/pgtable-nopud.h' included in 'pgtable.h' is duplicated.
>
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] module: remove duplicate include in ./arch/arm/include/asm/pgtable.h

[Russell King - ARM Linux admin]

On Tue, Mar 02, 2021 at 06:04:22PM -0800, menglong8.dong@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> 
> 'asm-generic/pgtable-nopud.h' included in 'pgtable.h' is duplicated.
> 
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>

I don't see this change has anything to do with module code, so what is
the reason for "module:" in the subject line? What am I missing here?

I also think that this patch needs a better explanation, since it's not
a removal of a redundant include, whereas your other similarly described
changes are.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel