From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC695C433E0 for ; Wed, 3 Mar 2021 22:22:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3209764F10 for ; Wed, 3 Mar 2021 22:22:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3209764F10 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cognitivepilot.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hSnoiYS0K5I5lDjGBU/vyGORl6nLPCfUM86sDb46YK4=; b=UFEww+uTRti8QBZ90JA33IoVZ eERaub+yzyKusLW/pd0KaRbVLQ3QlMfC0WiAsTrjgVDWBTC5PXetN7AYMSc6p609HU7D7D3q1bHpm TWJ4Xq/ondExhnqn2xlx3JeuSWTpzlwK1LATh0oe1ZUIDwrpko7+bYv9K3coHZVvfplsp8u3WIhTE 1KpxNyZs+fOh0Q0vWeXCjbQrs2TYUt8HS+La3XsUuc4pj8DAXk6UJCuKAMmhZocVlDAWO1h7LG6GL Hz3MucmzrzD9JM8oM/Nk2crrer9OIQ8akSp04K6T/DMgdnwycbR+EDQ/XN607yfw+w7BkGb/JNUtO H4azwjSrQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHZir-006io4-Sy; Wed, 03 Mar 2021 22:12:05 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHTAr-005KiQ-BZ for linux-arm-kernel@desiato.infradead.org; Wed, 03 Mar 2021 15:12:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description; bh=L5dGyt1YFJtH0xc4v2WDq+A7Ato+/iPAp7Ys+ymYk5Q=; b=onj3C4gTD8ydQuLGc3fd+WGFu/ /uY37U1nCRepaOEgqD8hW2nMztVKIWmPpkkTNPc7tnALojQD/RJjjHJvkzqDRFm04dt6PxzHpmD/G pCzzP7+9p6GGMKET2l0suaGwMWnxdo/S9SiTsgVq4NytAoVKSH9Efs9NlkLWGmBcbSeLBKMZRYMvD cz/DXXcUi5xV3bvofi5/5kWs28qlYm39M/TsY5jCpHA0xGbJ9E58MfEbqAzQxW7lhChfQuTqHnYMt ztBU88eC1lbpjHFRySekF0hK8Gsh38l+oIuAWbxIfqFrcrQVNGIgl9ZL+rzk5hQfVxwyqfa3jP7pe 6uVIUZRg==; Received: from mail.cognitivepilot.com ([91.218.251.140]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHTAj-00368F-NM for linux-arm-kernel@lists.infradead.org; Wed, 03 Mar 2021 15:12:25 +0000 Received: from mail.cognitivepilot.com (localhost [127.0.0.1]) by mail.cognitivepilot.com (Postfix) with ESMTP id 4DrHXV3Qq5zltRYg for ; Wed, 3 Mar 2021 18:11:54 +0300 (MSK) X-Virus-Scanned: amavisd-new at cognitivepilot.com Received: from mail.cognitivepilot.com ([127.0.0.1]) by mail.cognitivepilot.com (mail.cognitivepilot.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1iUIE5rUOWlf for ; Wed, 3 Mar 2021 18:11:53 +0300 (MSK) Received: from NervousEnergy (unknown [185.68.147.27]) by mail.cognitivepilot.com (Postfix) with ESMTPS id 4DrHXT1xYmzltRYW; Wed, 3 Mar 2021 18:11:53 +0300 (MSK) Date: Wed, 3 Mar 2021 18:11:43 +0300 From: Ivan Uvarov To: Andre Przywara Cc: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Icenowy Zheng Subject: Re: [draft2 PATCH] ARM: dts: sun8i: r40: add devicetree for FETA40i-C/OKA40i-C Message-ID: <20210303181143.5b7f0c3f@NervousEnergy> In-Reply-To: <20210303130834.401cc50c@slackpad.fritz.box> References: <20210303130834.401cc50c@slackpad.fritz.box> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_151225_277413_52EDCACD X-CRM114-Status: GOOD ( 33.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 3 Mar 2021 13:08:34 +0000 Andre Przywara wrote: > On Tue, 2 Mar 2021 13:54:15 +0300 > Ivan Uvarov wrote: > > Hi Ivan, > > many thanks for spending the time in piecing this together and caring > about upstreaming! > Many more thanks to you for helping me out with the process. I wouldn't have gotten anywhere near this far without your help. > > Should be a TAB here. > > And I don't know if this is just my client, but someone mangled equal > signs into "=3D" everywhere :-( > I am trying to ignore this for now ... > Can you force pure text email in Thunderbird? Or use git send-email? > I was using Thunderbird's plain text mode when composing this; looks like it imposes its own modifications anyway. I've switched to Claws now, hopefully it'll handle the next iteration more gracefully. > > +®_dldo1 { > > + regulator-always-on; > > + regulator-min-microvolt =3D <3300000>; > > + regulator-max-microvolt =3D <3300000>; > > + regulator-name =3D "vcc-wifi-io"; > > +}; > > + > > +®_dldo4 { > > + regulator-always-on; > > Does this really need to be always on? If it's just for SATA, I'd > expect this to be enabled by the driver when needed? As you correctly > do in the ahci node below. I'm not sure, to be honest. I haven't tested without it. I should probably try to. > > + regulator-min-microvolt =3D <2500000>; > > + regulator-max-microvolt =3D <2500000>; > > + regulator-name =3D "vdd2v5-sata"; > > Does this end prematurely here? It does. Looks like I deleted the last line of the file somehow while creating the patch. > > + > > +&mmc0 { > > + vmmc-supply =3D <®_dcdc1>; > > + vqmmc-supply =3D <®_dcdc1>; > > + bus-width =3D <4>; > > + cd-gpios =3D <&pio 8 11 GPIO_ACTIVE_LOW>; // PI11 > > + status =3D "okay"; > > +}; > > + > > +&mmc1 { > > So this is the SDIO connector on the board, right? Which is just a set > of header pins? Yes, that's it. > Not sure we should have it in here, then. OK. > What about MMC3, which is apparently connected to a microSD slot (TF > card in the schematic)? I never needed it, so never added it. Probably should. > > > + regulator-min-microvolt =3D <3300000>; > > + regulator-max-microvolt =3D <3300000>; > > + regulator-name =3D "vcc-wifi"; > > +}; > > + > > +®_dldo3 { // possibly unneeded > > If it's unneeded, you can drop it. If it turns out be needed later on, > we can always add it. Did the board work without it? > Did you try Wifi? We should not add untested features. WiFi does work without any hiccups on my board with this DTS. I haven't tested with the regulator disabled. > > + // regulator-always-on; > > + regulator-min-microvolt =3D <3300000>; > > + regulator-max-microvolt =3D <3300000>; > > + regulator-name =3D "vcc-wifi-2"; > > +}; > > + > > +®_eldo2 { > > + regulator-always-on; > > This shouldn't be always on. I guess this AXP pin is connected to the > VDD-SATA pin on the SoC, so it just drives the integrated SATA PHY. > Which probably means that this node belong into the SoM .dtsi, as the > connection is on the SoM. You just reference it from the ahci node > here. > > > + regulator-min-microvolt =3D <1200000>; > > + regulator-max-microvolt =3D <1200000>; > > + regulator-name =3D "vdd1v2-sata"; > > +}; > > + > > +®_eldo3 { > > + regulator-always-on; > > Again, why always on? Do you know where this is connected to? > If this is VCC_PE on the SoC, then I wonder if this should be moved to > the SoM .dtsi, with a range between 1.8V and 3.3V, since those are > valid input voltages for the VCC_PE pin. And then here you overwrite > this with 2.8V, as this is apparently used for the CSI connector on > the board, which seems to work on 2.8V. > But I am not sure if this is too much, and just having this node here > is sufficient. I'll look into both of those. > > + regulator-min-microvolt =3D <2800000>; > > + regulator-max-microvolt =3D <2800000>; > > + regulator-name =3D "vcc-pe"; > > +}; > > + > > +&tcon_tv0 { > > + status =3D "okay"; > > +}; > > + > > +&uart0 { > > + pinctrl-names =3D "default"; > > + pinctrl-0 =3D <&uart0_pb_pins>; > > + status =3D "okay"; > > +}; > > + > > +&uart3 { > > Please add uart3 to the aliases section then. Sure. I think I'll post a new version of the patch tomorrow, which should fix formatting and address the issues you've raised that can be fixed immediately without much further testing. It will also include the other uarts that are available on the devboard (2,4 and 7). Thank you for your assistance once more, you've been tremendously helpful. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel