From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, adrien.grassein@gmail.com
Subject: Re: [PATCH] arm64: dts: imx8mm-nitrogen-r2: Pass the i2c3 unit name
Date: Thu, 4 Mar 2021 19:30:41 +0800 [thread overview]
Message-ID: <20210304113041.GP15865@dragon> (raw)
In-Reply-To: <20210208143327.593805-1-festevam@gmail.com>
On Mon, Feb 08, 2021 at 11:33:27AM -0300, Fabio Estevam wrote:
> Pass the i2c3 unit name to fix the following W=1 build warning:
>
> arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts:159.8-172.5: Warning (unit_address_vs_reg): /soc@0/bus@30800000/i2c@30a40000/i2cmux@70/i2c3: node has a reg or ranges property, but no unit name
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> index c0c384d76147..48ccbb8ff127 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> @@ -156,7 +156,7 @@ i2cmux@70 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - i2c3 {
> + i2c3@0 {
Or it should be i2c@3?
Shawn
> reg = <0>;
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-04 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 14:33 [PATCH] arm64: dts: imx8mm-nitrogen-r2: Pass the i2c3 unit name Fabio Estevam
2021-03-04 11:30 ` Shawn Guo [this message]
2021-03-04 11:41 ` Adrien Grassein
2021-03-05 0:35 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304113041.GP15865@dragon \
--to=shawnguo@kernel.org \
--cc=adrien.grassein@gmail.com \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).