* [PATCH] arm64: dts: imx8mm-nitrogen-r2: Pass the i2c3 unit name
@ 2021-02-08 14:33 Fabio Estevam
2021-03-04 11:30 ` Shawn Guo
2021-03-05 0:35 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2021-02-08 14:33 UTC (permalink / raw)
To: shawnguo; +Cc: Fabio Estevam, adrien.grassein, linux-arm-kernel
Pass the i2c3 unit name to fix the following W=1 build warning:
arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts:159.8-172.5: Warning (unit_address_vs_reg): /soc@0/bus@30800000/i2c@30a40000/i2cmux@70/i2c3: node has a reg or ranges property, but no unit name
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
index c0c384d76147..48ccbb8ff127 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
@@ -156,7 +156,7 @@ i2cmux@70 {
#address-cells = <1>;
#size-cells = <0>;
- i2c3 {
+ i2c3@0 {
reg = <0>;
#address-cells = <1>;
#size-cells = <0>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mm-nitrogen-r2: Pass the i2c3 unit name
2021-02-08 14:33 [PATCH] arm64: dts: imx8mm-nitrogen-r2: Pass the i2c3 unit name Fabio Estevam
@ 2021-03-04 11:30 ` Shawn Guo
2021-03-04 11:41 ` Adrien Grassein
2021-03-05 0:35 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2021-03-04 11:30 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-arm-kernel, adrien.grassein
On Mon, Feb 08, 2021 at 11:33:27AM -0300, Fabio Estevam wrote:
> Pass the i2c3 unit name to fix the following W=1 build warning:
>
> arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts:159.8-172.5: Warning (unit_address_vs_reg): /soc@0/bus@30800000/i2c@30a40000/i2cmux@70/i2c3: node has a reg or ranges property, but no unit name
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> index c0c384d76147..48ccbb8ff127 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> @@ -156,7 +156,7 @@ i2cmux@70 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - i2c3 {
> + i2c3@0 {
Or it should be i2c@3?
Shawn
> reg = <0>;
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mm-nitrogen-r2: Pass the i2c3 unit name
2021-03-04 11:30 ` Shawn Guo
@ 2021-03-04 11:41 ` Adrien Grassein
0 siblings, 0 replies; 4+ messages in thread
From: Adrien Grassein @ 2021-03-04 11:41 UTC (permalink / raw)
To: Shawn Guo; +Cc: Fabio Estevam, linux-arm-kernel
Le jeu. 4 mars 2021 à 12:30, Shawn Guo <shawnguo@kernel.org> a écrit :
>
> On Mon, Feb 08, 2021 at 11:33:27AM -0300, Fabio Estevam wrote:
> > Pass the i2c3 unit name to fix the following W=1 build warning:
> >
> > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts:159.8-172.5: Warning (unit_address_vs_reg): /soc@0/bus@30800000/i2c@30a40000/i2cmux@70/i2c3: node has a reg or ranges property, but no unit name
> >
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> > index c0c384d76147..48ccbb8ff127 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> > @@ -156,7 +156,7 @@ i2cmux@70 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > - i2c3 {
> > + i2c3@0 {
>
> Or it should be i2c@3?
It's in the i2c3 node, so let's name it "i2c3@0".
Thanks,
>
> Shawn
>
> > reg = <0>;
> > #address-cells = <1>;
> > #size-cells = <0>;
> > --
> > 2.25.1
> >
Adrien
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm-nitrogen-r2: Pass the i2c3 unit name
2021-02-08 14:33 [PATCH] arm64: dts: imx8mm-nitrogen-r2: Pass the i2c3 unit name Fabio Estevam
2021-03-04 11:30 ` Shawn Guo
@ 2021-03-05 0:35 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2021-03-05 0:35 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-arm-kernel, adrien.grassein
On Mon, Feb 08, 2021 at 11:33:27AM -0300, Fabio Estevam wrote:
> Pass the i2c3 unit name to fix the following W=1 build warning:
>
> arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts:159.8-172.5: Warning (unit_address_vs_reg): /soc@0/bus@30800000/i2c@30a40000/i2cmux@70/i2c3: node has a reg or ranges property, but no unit name
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-05 0:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-08 14:33 [PATCH] arm64: dts: imx8mm-nitrogen-r2: Pass the i2c3 unit name Fabio Estevam
2021-03-04 11:30 ` Shawn Guo
2021-03-04 11:41 ` Adrien Grassein
2021-03-05 0:35 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).