From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30156C433E6 for ; Fri, 5 Mar 2021 08:41:15 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD03764F1C for ; Fri, 5 Mar 2021 08:41:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD03764F1C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2fYNagvrrz87wtDXyFEb+3CZYrcAjtNoIInkAtNqogY=; b=GMGVsAFQkLVtERrqcE/scyrm5 Qi9SJGkAckQg/XXbnKtjvN+RDw+rGX3p0RByJZnCrjvy0bp1/Dc9/m4WYcLMhwqt2ZbqWmoqU6Yrh P7fN5AVualXAgtbg6oELNqMAl9T1rG6PRFGM8im22CLf32nw9uNT7L5SnZnuzU9V7cf5GwXdFRRYH cT3h8psaLzWJn42ncjJTR6VjNVvilfpG/Lz0A4ymeVliDQRJDfX+5QotoqdNjHj0f4L44AXBXuRhq AA9lIuirKgV5N3priPwxj/TAX0ptnNvrbr/TQQLxrCRRan4IlFe8Wiuy3oqlkSbaN/xPMs1vIKpW4 LViEZokHw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI5zs-00E2m5-EC; Fri, 05 Mar 2021 08:39:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI5zn-00E2kq-L6 for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 08:39:41 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E1DD64F1C; Fri, 5 Mar 2021 08:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614933578; bh=KAegymEuv7yVOJGKyuC+TZCpN/j2HHm/SEltnoCqf6A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DinIt2tHORXyRfy+44Ue45kHb5nir/6SrrTOFOgKAODAp02VBBsGnfgLHUACHsDgS xZHPm8mdxNrcoXZIE/KtVlWmwyzKzXIGyGgrl52W8nK7QmWOumCS4WE2GqX/Nj5vjW nAHyFwlQI7p52mEAszGxg2jHXKAgmA8crmjXSuXgSs8HMrCO/GU1ov1b5SAZ6aoC/r 2LteiTUqu9d3U+PneYZZGd/73bt7YMHzfW2+SglQs038CGM1DsZ0Gd3Cax5HCl15Kr jOp3yV9HEttfQR+lsq3HieNxvMjQ5ok+62dafwH3qxGN8GcVWchOCqstNBnomchUx4 /dsrNxRcs3CGA== Date: Fri, 5 Mar 2021 16:39:31 +0800 From: Shawn Guo To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Christoph Niedermaier , Fabio Estevam , Ludwig Zenz , NXP Linux Team , Greg Kroah-Hartman , Arnd Bergmann Subject: Re: [PATCH] ARM: dts: imx6q-dhcom: Add PU,VDD1P1,VDD2P5 regulators Message-ID: <20210305083931.GT15865@dragon> References: <20210203235403.308539-1-marex@denx.de> <20210303125614.GG15865@dragon> <3189923d-df38-6dab-6be7-b2439c234fe4@denx.de> <20210304075652.GN15865@dragon> <5ae1374f-fd10-523f-7b6f-fa7fb40eba20@denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5ae1374f-fd10-523f-7b6f-fa7fb40eba20@denx.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_083939_942276_FE8EE1F7 X-CRM114-Status: GOOD ( 21.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 04, 2021 at 01:07:32PM +0100, Marek Vasut wrote: > On 3/4/21 8:56 AM, Shawn Guo wrote: > > On Wed, Mar 03, 2021 at 03:04:07PM +0100, Marek Vasut wrote: > > > On 3/3/21 1:56 PM, Shawn Guo wrote: > > > > On Thu, Feb 04, 2021 at 12:54:03AM +0100, Marek Vasut wrote: > > > > > Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1 > > > > > via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied > > > > > from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs. > > > > > > > > > > Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2") > > > > > > > > It's more like an improvement or additions rather than fixes. I dropped > > > > the tag and applied for -next. > > > > > > I would argue that describing SoC regulators correctly is a bugfix, since it > > > can lead to stability issues of the SoC. > > > > Then resend the patch with details of the issue that it fixes. > > Can you please tell me what is missing in the original patch description > that justifies dropping the Fixes: tag ? I would argue that fully describing > CPU regulators in DT is a fix which should go through the stable tree and > the original patch description is accurate. You claim that the patch fixes a stability issue, but commit log mentions nothing about it. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel