From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 0/3] arm64: dts: renesas: falcon: Add I2C EEPROMs and sub-boards
Date: Fri, 5 Mar 2021 15:15:43 +0100 [thread overview]
Message-ID: <20210305141543.GB1312@kunai> (raw)
In-Reply-To: <20210304153257.4059277-1-geert+renesas@glider.be>
[-- Attachment #1.1: Type: text/plain, Size: 1048 bytes --]
On Thu, Mar 04, 2021 at 04:32:54PM +0100, Geert Uytterhoeven wrote:
> Hi all,
>
> This patch series adds the device nodes for all I2C EEPROMs in the
> Falcon board stack. As some EEPROMs are located on sub-boards,
> it also introduces individual .dtsi files for these sub-boards.
> Note that (for now) these sub-boards don't have compatible values or
> model strings, as I think this needs more discussion.
>
> This has been tested on the Falcon boards in Magnus' and Kieran's farms.
> The EEPROM on the CPU board in Magnus' farm contains some data.
> All other EEPROMs are present, but in pristine state (all ones).
>
> Changes compared to v1:
> - Move EEPROMs in sub-boards to separate .dtsi files and patches.
>
Checked the datasheets and tested, too, so:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
One minor question is: why do the labels in patches 2+3 have the "-id"
suffix and patch 1 does not? Don't we want consistency here?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-05 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 15:32 [PATCH v2 0/3] arm64: dts: renesas: falcon: Add I2C EEPROMs and sub-boards Geert Uytterhoeven
2021-03-04 15:32 ` [PATCH v2 1/3] arm64: dts: renesas: falcon: Add I2C EEPROM nodes Geert Uytterhoeven
2021-03-04 15:32 ` [PATCH v2 2/3] arm64: dts: renesas: falcon: Add CSI/DSI sub-board Geert Uytterhoeven
2021-03-04 15:32 ` [PATCH v2 3/3] arm64: dts: renesas: falcon: Add Ethernet sub-board Geert Uytterhoeven
2021-03-05 14:15 ` Wolfram Sang [this message]
2021-03-05 14:18 ` [PATCH v2 0/3] arm64: dts: renesas: falcon: Add I2C EEPROMs and sub-boards Geert Uytterhoeven
2021-03-05 14:19 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305141543.GB1312@kunai \
--to=wsa+renesas@sang-engineering.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox