From: Rob Herring <robh@kernel.org>
To: Oliver Graute <oliver.graute@gmail.com>
Cc: shawnguo@kernel.org, m.felsch@pengutronix.de, festevam@gmail.com,
narmstrong@baylibre.com, Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Oleksij Rempel <linux@rempel-privat.de>,
Stefan Riedmueller <s.riedmueller@phytec.de>,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Li Yang <leoyang.li@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/3] dt-bindings: arm: fsl: Add Variscite i.MX6UL compatibles
Date: Fri, 5 Mar 2021 15:31:15 -0600 [thread overview]
Message-ID: <20210305213115.GA676128@robh.at.kernel.org> (raw)
In-Reply-To: <1613308450-27958-4-git-send-email-oliver.graute@gmail.com>
On Sun, Feb 14, 2021 at 02:13:50PM +0100, Oliver Graute wrote:
> Add the compatibles for Variscite i.MX6UL compatibles
>
> Signed-off-by: Oliver Graute <oliver.graute@gmail.com>
> ---
>
> Changelog:
>
> v4:
> - added missing 6 in i.MX6
>
> v3:
> - rebased
>
> v2:
> - renamed binding
> - removed superflous "
>
> Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 297c87f..e67b622 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -499,6 +499,7 @@ properties:
> - technexion,imx6ul-pico-dwarf # TechNexion i.MX6UL Pico-Dwarf
> - technexion,imx6ul-pico-hobbit # TechNexion i.MX6UL Pico-Hobbit
> - technexion,imx6ul-pico-pi # TechNexion i.MX6UL Pico-Pi
> + - variscite,imx6ul-var-6ulcustomboard # i.MX6 UltraLite Carrier-board
Doesn't match your dts file. Plus looks like a lot of redundancy.
Run dtbs_checks and with W=1 and make sure you aren't adding more
warnings. Lots will be from the base SoC dtsi, but feel free to fix some
of those too.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-03-05 21:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 13:13 [PATCH v9 0/3] Variscite DART-6UL SoM support Oliver Graute
2021-02-14 13:13 ` [PATCH v9 1/3] ARM: dts: imx6ul: Add " Oliver Graute
2021-03-07 12:55 ` Shawn Guo
2021-02-14 13:13 ` [PATCH v9 2/3] ARM: dts: Add support for i.MX6 UltraLite DART Variscite Customboard Oliver Graute
2021-03-07 13:02 ` Shawn Guo
2021-02-14 13:13 ` [PATCH v4 3/3] dt-bindings: arm: fsl: Add Variscite i.MX6UL compatibles Oliver Graute
2021-03-05 21:31 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305213115.GA676128@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=m.felsch@pengutronix.de \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=narmstrong@baylibre.com \
--cc=oliver.graute@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=s.riedmueller@phytec.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).