From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E6C2C433DB for ; Sat, 6 Mar 2021 03:07:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90DC564E42 for ; Sat, 6 Mar 2021 03:07:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90DC564E42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qVL79zQnkgktPhPy8BaKGHHZzw1AfvmD6CJt05kbfT0=; b=pRsT5DmqqZHvvPbfBF7kCQB8o U+bjicZ/oU0VIp4tgqaSVY5nh0WSTS6VGHqOH3KJHfbJh1vXxYNNPPdTGrCU9jR/l7wdrcbRZrlAM +XxVw163Zbd+ry92dgBtHZ24wUrkTeZBXIksE/XZ4Bh2+mia5lGxJZRhgYtPEn6/trDrS6ZeGJlgb avlLtu1JAFGaYrqIKgsSK1yHRMK3J3mSUPsIsRaLPyJMOAocBu4RrglnckxLS9cxjqB6ASqVeIEut ksJXeBPeWMtu+2aZkVo9g+PuJ4ABpKQDnywUO5wSZwi33sqa5PBAcpKeNnKl0tFje9/seUG9PyWmR uKkkyZQAA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lINFz-000azN-5o; Sat, 06 Mar 2021 03:05:31 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lINFs-000awn-C5 for linux-arm-kernel@lists.infradead.org; Sat, 06 Mar 2021 03:05:28 +0000 Received: by mail-pf1-x431.google.com with SMTP id r5so3329022pfh.13 for ; Fri, 05 Mar 2021 19:05:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=C3NLEHrnsN9ERk6AvvzJ5QN+B7qHrtPpBVa7hDiDUzw=; b=M1kxf5FFuBGbYf80LTez2uwZPcP1lv5lFoZXNRisoDLzEBxL3joYrkfG8RN+5hpe/9 6Xz7y+vW23H60eGxTsn2ds+KgMAqSgEcZvR/Pv1INKDfQAowaHJBxE54hwq8JNFDwMDJ 5NV0/J8ns3/MUu+sGdP3OapdxbpgsWQjwL5r47oU6Ixee4nV8BO5zi3OA0Lx0Hrk9jXI 8S0uzY/xMqmEaOhc8vWhKZED4i3M3oWVFxScA3dgqmWmUpGbg7fbNQeZ4G2wgT4ai38r dk93z8mOfi0wNDipeanuJEid7/vsPzDKgi6hKIA8v4Pokh0za8FlmQawRsv6ZWFBqm3i 2YqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=C3NLEHrnsN9ERk6AvvzJ5QN+B7qHrtPpBVa7hDiDUzw=; b=LK+1fM2Bcm0PMSqErn2TJUP3m3eUxY6n0CS7pfzUSYpYSffyz6NQiOtO5zleA1O4qE mej9mxuA77VgCDGoUHV0bfQtqOoiZThq16izpcD0gAOvllybDeNENR/quJ15fXNK6Ch4 ditGgQddMd1uoNhqdIcWM5Pn9kyNFOTfsCDyfW0D2KfmATfMojRX+vXvnHGO56dzqqkH HXfANT8O0AkNeroYZXdy7FNt5wnKhJ36gwEPsoyrZqiwUIHXcKHwIeQdDtSGyPBPNuB6 megnHHyJPCq+XOUb8j5ixp2rm5eIdaAddIOiakBq/WcR5AkQfBS6iTrq2AL/D1kaXB1q Vkwg== X-Gm-Message-State: AOAM531K4DQpKHjdkM2krp42vmgMGxvBPQeEYKuOGdX+3B4lTCl7z1ge qRCqNcI3RKnjFxAMQfSuhAP8iNOsNEHX4USeiDc= X-Google-Smtp-Source: ABdhPJxPKR48rF0f9k74bRjzyzQ9501I3wZwxWa7o8VClbp2FhAkOOqOgBOKFQr1/IEEE1joJwICrA== X-Received: by 2002:a63:e5d:: with SMTP id 29mr11134045pgo.450.1614999918067; Fri, 05 Mar 2021 19:05:18 -0800 (PST) Received: from leoy-ThinkPad-X240s ([103.136.125.226]) by smtp.gmail.com with ESMTPSA id j35sm3929857pgj.45.2021.03.05.19.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 19:05:17 -0800 (PST) Date: Sat, 6 Mar 2021 11:05:12 +0800 From: Leo Yan To: Arnaldo Carvalho de Melo Cc: Mathieu Poirier , Suzuki K Poulose , Mike Leach , Jonathan Corbet , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , Namhyung Kim , Daniel Kiss , Denis Nikitin , Al Grant , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/8] perf cs-etm: Fix bitmap for option Message-ID: <20210306030512.GD5478@leoy-ThinkPad-X240s> References: <20210206150833.42120-1-leo.yan@linaro.org> <20210206150833.42120-5-leo.yan@linaro.org> <20210208204641.GE2077938@xps15> <20210209015855.GA54680@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210306_030524_596973_040506A0 X-CRM114-Status: GOOD ( 24.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnaldo, On Fri, Mar 05, 2021 at 02:29:44PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Feb 09, 2021 at 09:58:55AM +0800, Leo Yan escreveu: > > On Mon, Feb 08, 2021 at 01:46:41PM -0700, Mathieu Poirier wrote: > > > On Sat, Feb 06, 2021 at 11:08:29PM +0800, Leo Yan wrote: > > > > From: Suzuki K Poulose > > > > > > > > When set option with macros ETM_OPT_CTXTID and ETM_OPT_TS, it wrongly > > > > takes these two values (14 and 28 prespectively) as bit masks, but > > > > actually both are the offset for bits. But this doesn't lead to > > > > further failure due to the AND logic operation will be always true for > > > > ETM_OPT_CTXTID / ETM_OPT_TS. > > > > > > > > This patch defines new independent macros (rather than using the > > > > "config" bits) for requesting the "contextid" and "timestamp" for > > > > cs_etm_set_option(). > > > > > > > > [leoy: Extract the change as a separate patch for easier review] > > > > > > This should go just above your name - see below. > > I fixed this up and added this patch to my perf/urgent branch, for > v5.12, since the kernel bits are upstream and this is a fix. Yeah, it makes sense to pick this patch into perf/urgent branch since it's a fixing patch. Actually, this patch has been merged into the tmp.perf/core branch [1], after you move it to the perf/urgent branch, I can confirm all other patches for perf tool in this series have been merged into the tmp.perf/core branch. Thanks, Leo [1] https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/core&id=8c559e8d68630d64d932bada633705f6551427df _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel