From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6034BC433DB for ; Sat, 6 Mar 2021 09:49:52 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB4FC65017 for ; Sat, 6 Mar 2021 09:49:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB4FC65017 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kLEpy06YReN2DVpnTj7nWcxdvYh3Cd8ODFzaAzrSLxc=; b=M3P1Loexch5jWpYzjxg15YP8s 5eKozdTA447VJbIm+xYeBOhPaXEu+pxU7P2+yyd8wjxoTU29Q4kVDD/F9SUPwWsJw2FgRu+FL6MJD 0fhLkmH5X1vw0CdToVLJu0PY+TA+RY1JP5xEavY3F2x623Bm+khjaHZFEjC1lEkxm0yIbZRjpaIsk WO5IE+WWF8ZZFHHaeXJxHOQ5WSkhPShu7n0qibP0vPGRGJJPTLOk+3SoWFNaLZCvxQCjJCd1eGSwW PxnUyumTHzP8hpo2q0e9PsagSSzINaWnjsBJ91rHFiuVvzZqu2V9i5x51vlMuxZnWp7HnoKwDnkLN DguVOHbUA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lITX3-002i8W-4D; Sat, 06 Mar 2021 09:47:33 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lITV1-002i5G-HW for linux-arm-kernel@lists.infradead.org; Sat, 06 Mar 2021 09:47:29 +0000 Received: by mail-pl1-x629.google.com with SMTP id s7so2634026plg.5 for ; Sat, 06 Mar 2021 01:45:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OrPR8SCgp/TDBWi7TQcMhS3IkX8qoHvZgwUCqJ/NqdI=; b=VRreclAG1k+qmJNdv7UCkdEcWxdRgIfw2KSUezw924U3rjLMNqMTDHdg1v44ppVbr3 buAc14quQHiobY0ltDDBCIBL/eEY4D880Eyx6ukMYOzN1mXqVVJpd5ue+4H25bTFqqZ7 O3/wkdGUiRkZJMtPsd83OIU3uB6EAfawWEEC3ro3EnUURtiFx0rfeer0J2Hce1LZB4EP GHCPkwSx760blDs3L84B1FADusrcw0Gqi1xlpSltBqaKmh7fqi5urGVW7wA2Hf9ppBGY 3iVDz+f9NMgy/bNxGNwJDpjiJCe81q6D/15WClkIFl0TDVxFDgVkZaNkbSqpvIVIch+x +jCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OrPR8SCgp/TDBWi7TQcMhS3IkX8qoHvZgwUCqJ/NqdI=; b=YRug+J3+N9nZB8mFNmiN5glH/t7hAf3VIH/BeiwUym7vEkyYxXbveDZv4i+K/4b3QK J0wNXSHLM7/ILTzuPXXCNVTydWew1QSOxn+26e9tIpQ+Ol4wLl/utWEGX0b4a2GPDBo6 8uBi4yMrVNQdORIfrC17zpltl+Qya1xIBaJ803fHfvz9kRfXt+vjp2zDAuNxCNpNp8UQ qEjNx2+ExIHK32BzGH4zEoN0QYKJ7WQpksTTfKwIdGfHdx0cRMkmrC1VsG9Q5Wmzx+/o sxXtCfX0yWzziiKThJH7l8zGJBlInE9t2PCCRV6euuMceb6x6x7ImoRiPHYmrg3WiW1B 0rGQ== X-Gm-Message-State: AOAM532cGsGkldwG946Q1H55q+hsOeoBmWo756T1lFHNhicu2RFFYR5C gJjegsW5GCJUW5SJfPcGkAQ7sQ== X-Google-Smtp-Source: ABdhPJww6KoYOO4ImE2czyutBV0PbuLHuBQcrCidHeKDkwgK+a87ViuaTr0ShjnDZt5YWmStw5MrNw== X-Received: by 2002:a17:902:768b:b029:e3:fb85:1113 with SMTP id m11-20020a170902768bb02900e3fb851113mr12606639pll.3.1615023925014; Sat, 06 Mar 2021 01:45:25 -0800 (PST) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id e1sm4573038pjt.10.2021.03.06.01.45.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 Mar 2021 01:45:24 -0800 (PST) Date: Sat, 6 Mar 2021 17:45:18 +0800 From: Shawn Guo To: Ard Biesheuvel Cc: linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jeffrey Hugo , Bjorn Andersson , Rob Clark , Leif Lindholm , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 1/1] efi: stub: omit SetVirtualAddressMap() if marked unsupported in RT_PROP table Message-ID: <20210306094517.GN17424@dragon> References: <20210305093958.187358-1-ardb@kernel.org> <20210305093958.187358-2-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210305093958.187358-2-ardb@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210306_094727_815939_230BC4A2 X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 05, 2021 at 10:39:58AM +0100, Ard Biesheuvel wrote: > The EFI_RT_PROPERTIES_TABLE contains a mask of runtime services that are > available after ExitBootServices(). This mostly does not concern the EFI > stub at all, given that it runs before that. However, there is one call > that is made at runtime, which is the call to SetVirtualAddressMap() > (which is not even callable at boot time to begin with) > > So add the missing handling of the RT_PROP table to ensure that we only > call SetVirtualAddressMap() if it is not being advertised as unsupported > by the firmware. > > Signed-off-by: Ard Biesheuvel On Lenovo Yoga C630 laptop: Tested-by: Shawn Guo It's a great help to dropping 'efi=novamap' kernel cmdline, which is a very nice thing for distros to support Snapdragon laptops. Thanks much, Ard! Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel