From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB31BC433DB for ; Sun, 7 Mar 2021 01:34:13 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 266C2650BB for ; Sun, 7 Mar 2021 01:34:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 266C2650BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UTb6XloQCXsfvxjEIONKmfQ92YnAC+DuELDC+rBASIw=; b=Wp/YwHcPAIVmfSs07AIFw6tuW TWNLZY+HKQl1uMWt3aDdVgyBP80cpQMrHUoo8OgfGMDeq6enXyZkCU2w0uuhmnpD4pTug2/Df3p8C fXQ2DyjM7CaraW2ss4wCkPFLslPNAFuwKj10rnfhIvbny3SCjOtnXnmC8rfgOanBXUDndpmuWoqYS Oljs1OkJRvEoAEJL42ghHMqy93VnFWKyDYc8pimhEA9tQPRaEHo/v0ZHjbSWotgdc8ArAMYqMSFkw 2KdodX8b9ktFZHbqQi0PvdJxJvms0JgV3vWMwezvjzFtOhzQYXzJt5nRsietfiH32Pqf4KIlPslYW 6dIaPgGXQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lIiGy-006jpL-HZ; Sun, 07 Mar 2021 01:31:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lIiGu-006jo4-H2 for linux-arm-kernel@lists.infradead.org; Sun, 07 Mar 2021 01:31:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D144564F73; Sun, 7 Mar 2021 01:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615080710; bh=+/r93ntH3DgOQIY9c6cFZMwuxdjd4LhylcwvKAAao5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jkrqFJT9bVKOIHuyz/RuoP0CTMn9PZqYkkUBluHuiI10DTv9YEpf1WIjj4/aolqW4 yTv5Xnp0pljNAkD8kTiIhTfhTrQSrRBzOiGVVVKuAtG0ODPkghRBEh+Vnsk3OGzoXm 30coFEkL8FgMXcu5Vw98llIIgiyFkW6ZuFy8+1EIjuXPc49SfWG6hTyS9xiwm9S6H1 YfSLu80UwiQ0V4N6dQn3VxTdo4SAiONkJmLkOS/5Hpsb3JpiCCj4630fZLOSXvBIPw 9I5hBEXSxz7aBMm0fjRR2HGzHUCxGZXdSBVIlGsyGTDn7zyhMy/RcE7z8YtDx5VE6y ih1lvn0MhzTGg== Date: Sun, 7 Mar 2021 09:31:46 +0800 From: Shawn Guo To: Fabio Estevam Cc: linux-arm-kernel@lists.infradead.org, david@protonic.nl, o.rempel@pengutronix.de Subject: Re: [PATCH] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings Message-ID: <20210307013145.GY15865@dragon> References: <20210208142123.587551-1-festevam@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210208142123.587551-1-festevam@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210307_013153_138787_3AC00294 X-CRM114-Status: GOOD ( 13.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 08, 2021 at 11:21:23AM -0300, Fabio Estevam wrote: > Remove the unnecessary #address-cells/#size-cells and rename the node > names to fix the following W=1 dtc warnings: > > arch/arm/boot/dts/imx6dl-plybas.dts:26.13-30.5: Warning (unit_address_vs_reg): /gpio_keys/button@20: node has a unit name, but no reg or ranges property > arch/arm/boot/dts/imx6dl-plybas.dts:32.13-36.5: Warning (unit_address_vs_reg): /gpio_keys/button@21: node has a unit name, but no reg or ranges property > arch/arm/boot/dts/imx6dl-plybas.dts:20.12-37.4: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > Signed-off-by: Fabio Estevam > --- > arch/arm/boot/dts/imx6dl-plybas.dts | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6dl-plybas.dts b/arch/arm/boot/dts/imx6dl-plybas.dts > index 333c306aa946..e6e9721ceea2 100644 > --- a/arch/arm/boot/dts/imx6dl-plybas.dts > +++ b/arch/arm/boot/dts/imx6dl-plybas.dts > @@ -19,17 +19,15 @@ chosen { > > gpio_keys { > compatible = "gpio-keys"; > - #address-cells = <1>; > - #size-cells = <0>; > autorepeat; > > - button@20 { > + start-button { I prefer name style like button-xxx. Shawn > label = "START"; > linux,code = <31>; > gpios = <&gpio5 8 GPIO_ACTIVE_LOW>; > }; > > - button@21 { > + clean-button { > label = "CLEAN"; > linux,code = <46>; > gpios = <&gpio5 9 GPIO_ACTIVE_LOW>; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel