From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A742C433DB for ; Sun, 7 Mar 2021 13:17:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8DAA64F67 for ; Sun, 7 Mar 2021 13:17:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8DAA64F67 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=STN0/Y55jlA1dNTer9bP36UmcE+fe6NsxiOV1latkU4=; b=aoPXp+X9QOsQUquZoYrxZJofu d8nKu4rfkrHHSrdpgu9BkR9f5nJXiqj67ad2e/h4bT4cA0QOqiRz7xk4rsHMejcRdf94mrcsOHvYo ZMCYC6HJcm8q/m0Kk5DvryrzqydKOuROlpzeUNemmBcftgvNYTJ94R03KXahHwqhx/bxuLhbfBi+c l43XcgCfsGFmlILVcVn/sNDxWltHNoDrUkoVchYn86l6EpytY+kQaPF6pc/a680bsSyuBhOFa8sws WzsCrytH8l0FDmJtXPx+nGJcDTyH1OOMptXGa6iDPmpll5ZrExfN4ecmh9z5XRzKK65qYh+C3Nzek RhjohfNBA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lItGW-00A9nq-Ev; Sun, 07 Mar 2021 13:16:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lItGO-00A9lF-Ix for linux-arm-kernel@lists.infradead.org; Sun, 07 Mar 2021 13:16:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C48BA65101; Sun, 7 Mar 2021 13:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615122959; bh=UiDPOCbalAXRXfE7w6/jPoptwzkmB0I2pUlCkFrlA8c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hs5ZuoZBN/kPNVJVrlhAyAmi8BsQ72HL2Ua1/aI5uZXr1gHn4Jv7qM2CLSfl+DSi6 cjrfq+XwCeHTgNRY1Rz3okT0PxQ8vR7uk4gUJKv+/80qGCR8y4v9QDktpFdo+lEOc5 7G9IuJd6O136/UBQfGPGY0YoI4Ee128Rex7fjUUCKY3nNmwviXDBNgQ+UZn6GEoU5g KzVGaIHQemYnrcTVR+yBn/UOrE64OfH1LFsmth87bfSMRvky/sdVMSdBb0P7dLGPVP s50y6m9A0sS9dgLewDMkosI7HHiJi/AbgcXrEaNKR1mJIPv1MORR5HVKJw12hkxnVT 3wEQzJ+oVFVFQ== Date: Sun, 7 Mar 2021 21:15:53 +0800 From: Shawn Guo To: Richard Zhu , Abel Vesa Cc: ping.bai@nxp.com, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] clk: imx8mp: Remove the none exist pcie clocks Message-ID: <20210307131553.GE543@dragon> References: <1613637226-31447-1-git-send-email-hongxing.zhu@nxp.com> <1613637226-31447-2-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1613637226-31447-2-git-send-email-hongxing.zhu@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210307_131605_118784_1D5F1A7C X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Copy Abel who is stepping up to maintain i.MX clock drivers. Shawn On Thu, Feb 18, 2021 at 04:33:46PM +0800, Richard Zhu wrote: > In the i.MX8MP PCIe design, the PCIe PHY REF clock comes from external > OSC or internal system PLL. It is configured in the IOMUX_GPR14 register > directly, and can't be contolled by CCM at all. > Remove the PCIE PHY clock from clock driver to clean up codes. > There is only one PCIe in i.MX8MP, remove the none exist second PCIe > related clocks. > Remove the none exsits clocks IDs together. > > Signed-off-by: Richard Zhu > Reviewed-by: Jason Liu > --- > drivers/clk/imx/clk-imx8mp.c | 15 --------------- > include/dt-bindings/clock/imx8mp-clock.h | 3 --- > 2 files changed, 18 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c > index 2f4e1d674e1c..afbeb6bf1909 100644 > --- a/drivers/clk/imx/clk-imx8mp.c > +++ b/drivers/clk/imx/clk-imx8mp.c > @@ -152,10 +152,6 @@ static const char * const imx8mp_can2_sels[] = {"osc_24m", "sys_pll2_200m", "sys > "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out", > "sys_pll2_250m", "audio_pll2_out", }; > > -static const char * const imx8mp_pcie_phy_sels[] = {"osc_24m", "sys_pll2_100m", "sys_pll2_500m", > - "clk_ext1", "clk_ext2", "clk_ext3", > - "clk_ext4", "sys_pll1_400m", }; > - > static const char * const imx8mp_pcie_aux_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll2_50m", > "sys_pll3_out", "sys_pll2_100m", "sys_pll1_80m", > "sys_pll1_160m", "sys_pll1_200m", }; > @@ -380,14 +376,6 @@ static const char * const imx8mp_memrepair_sels[] = {"osc_24m", "sys_pll2_100m", > "sys_pll1_800m", "sys_pll2_1000m", "sys_pll3_out", > "clk_ext3", "audio_pll2_out", }; > > -static const char * const imx8mp_pcie2_ctrl_sels[] = {"osc_24m", "sys_pll2_250m", "sys_pll2_200m", > - "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_500m", > - "sys_pll2_333m", "sys_pll3_out", }; > - > -static const char * const imx8mp_pcie2_phy_sels[] = {"osc_24m", "sys_pll2_100m", "sys_pll2_500m", > - "clk_ext1", "clk_ext2", "clk_ext3", > - "clk_ext4", "sys_pll1_400m", }; > - > static const char * const imx8mp_media_mipi_test_byte_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll2_50m", > "sys_pll3_out", "sys_pll2_100m", > "sys_pll1_80m", "sys_pll1_160m", > @@ -585,7 +573,6 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) > hws[IMX8MP_CLK_VPU_G2] = imx8m_clk_hw_composite("vpu_g2", imx8mp_vpu_g2_sels, ccm_base + 0xa180); > hws[IMX8MP_CLK_CAN1] = imx8m_clk_hw_composite("can1", imx8mp_can1_sels, ccm_base + 0xa200); > hws[IMX8MP_CLK_CAN2] = imx8m_clk_hw_composite("can2", imx8mp_can2_sels, ccm_base + 0xa280); > - hws[IMX8MP_CLK_PCIE_PHY] = imx8m_clk_hw_composite("pcie_phy", imx8mp_pcie_phy_sels, ccm_base + 0xa380); > hws[IMX8MP_CLK_PCIE_AUX] = imx8m_clk_hw_composite("pcie_aux", imx8mp_pcie_aux_sels, ccm_base + 0xa400); > hws[IMX8MP_CLK_I2C5] = imx8m_clk_hw_composite("i2c5", imx8mp_i2c5_sels, ccm_base + 0xa480); > hws[IMX8MP_CLK_I2C6] = imx8m_clk_hw_composite("i2c6", imx8mp_i2c6_sels, ccm_base + 0xa500); > @@ -643,8 +630,6 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) > hws[IMX8MP_CLK_MEDIA_CAM2_PIX] = imx8m_clk_hw_composite("media_cam2_pix", imx8mp_media_cam2_pix_sels, ccm_base + 0xbe80); > hws[IMX8MP_CLK_MEDIA_LDB] = imx8m_clk_hw_composite("media_ldb", imx8mp_media_ldb_sels, ccm_base + 0xbf00); > hws[IMX8MP_CLK_MEMREPAIR] = imx8m_clk_hw_composite_critical("mem_repair", imx8mp_memrepair_sels, ccm_base + 0xbf80); > - hws[IMX8MP_CLK_PCIE2_CTRL] = imx8m_clk_hw_composite("pcie2_ctrl", imx8mp_pcie2_ctrl_sels, ccm_base + 0xc000); > - hws[IMX8MP_CLK_PCIE2_PHY] = imx8m_clk_hw_composite("pcie2_phy", imx8mp_pcie2_phy_sels, ccm_base + 0xc080); > hws[IMX8MP_CLK_MEDIA_MIPI_TEST_BYTE] = imx8m_clk_hw_composite("media_mipi_test_byte", imx8mp_media_mipi_test_byte_sels, ccm_base + 0xc100); > hws[IMX8MP_CLK_ECSPI3] = imx8m_clk_hw_composite("ecspi3", imx8mp_ecspi3_sels, ccm_base + 0xc180); > hws[IMX8MP_CLK_PDM] = imx8m_clk_hw_composite("pdm", imx8mp_pdm_sels, ccm_base + 0xc200); > diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h > index e8d68fbb6e3f..43927a1b9e94 100644 > --- a/include/dt-bindings/clock/imx8mp-clock.h > +++ b/include/dt-bindings/clock/imx8mp-clock.h > @@ -125,7 +125,6 @@ > #define IMX8MP_CLK_CAN1 116 > #define IMX8MP_CLK_CAN2 117 > #define IMX8MP_CLK_MEMREPAIR 118 > -#define IMX8MP_CLK_PCIE_PHY 119 > #define IMX8MP_CLK_PCIE_AUX 120 > #define IMX8MP_CLK_I2C5 121 > #define IMX8MP_CLK_I2C6 122 > @@ -182,8 +181,6 @@ > #define IMX8MP_CLK_MEDIA_CAM2_PIX 173 > #define IMX8MP_CLK_MEDIA_LDB 174 > #define IMX8MP_CLK_MEDIA_MIPI_CSI2_ESC 175 > -#define IMX8MP_CLK_PCIE2_CTRL 176 > -#define IMX8MP_CLK_PCIE2_PHY 177 > #define IMX8MP_CLK_MEDIA_MIPI_TEST_BYTE 178 > #define IMX8MP_CLK_ECSPI3 179 > #define IMX8MP_CLK_PDM 180 > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel