From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DCDC433DB for ; Tue, 9 Mar 2021 07:49:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3324864EF0 for ; Tue, 9 Mar 2021 07:49:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3324864EF0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:From:To:Date:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nblUG57llMn1WnVvbNO4U+8zIpT5mLg+PsSppEg/r5Q=; b=ZnXP5sEVhtZfmePt546WLCPN4 yIWRDibCouPCKAGUFE6rbTlbbEA/cSrGL1HZu157xYhU5yBbwdwu0g28HynQvFTVfDcdfGvFaLwyc 1coPrjIZi/CC98Te+gBqTJ8AHUciz3t7/iZ+t9D5wXM9MQDmbc9GQfANyfNNmmLp1/FFnGiMBwhmb N/4dRw+srTudADm+3vIPjqlKnECWZmG6dzV10CnH/4CuUISbj9ZH40YbGvFGB91sbLeKdYWvtzuj4 3d9vM3kq/cMKCA1Bw6cY7lm3bmRUSwkSZvb5kbTzBw7HuaQHQfwiS3Ih9H6FvLHSSbnbKvgChnh9/ xb0MZ7rXw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJX5U-003yZM-2I; Tue, 09 Mar 2021 07:47:31 +0000 Received: from mail-40136.protonmail.ch ([185.70.40.136]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJX5J-003yYm-AD for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 07:47:20 +0000 Date: Tue, 09 Mar 2021 07:47:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1615276032; bh=+ZlcTZnrhrZ8o7M1JrptlxBInGQYHsPbgf1Nr0uMsQ0=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=TxKn1Jcnp1F8jZez32EQsOrCPDgvTGtkRoJCDS1vmcYP8iX4xUP5r12Mf323ZS9re uZQS704MUiB1voO6Gn4s/ELYUmkOa5o5uXmSkQ+Q/Omc8gy0yb6MB800FMdSa3dSBv Za0jyyJxQK/td48v87cqCAZOUCd7oqnV49DUDD7w= To: Krzysztof Kozlowski From: Timon Baetz Cc: Liam Girdwood , Mark Brown , Rob Herring , Sebastian Reichel , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 3/3] power: supply: max8997_charger: Switch to new binding Message-ID: <20210309084658.4a140b92@focal-fossa> In-Reply-To: <20210201180335.rrsqfvbcmxvx64gf@kozik-lap> References: <20210130172747.2022977-1-timon.baetz@protonmail.com> <20210130172747.2022977-4-timon.baetz@protonmail.com> <20210131172840.fxaadhhsafa4aeex@kozik-lap> <20210201083128.18499ffd.timon.baetz@protonmail.com> <20210201180335.rrsqfvbcmxvx64gf@kozik-lap> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_074718_455039_77CC369B X-CRM114-Status: GOOD ( 23.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Timon Baetz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 1 Feb 2021 19:03:35 +0100, Krzysztof Kozlowski wrote: > On Mon, Feb 01, 2021 at 09:26:42AM +0000, Timon Baetz wrote: > > On Sun, 31 Jan 2021 18:28:40 +0100, Krzysztof Kozlowski wrote: > > > On Sat, Jan 30, 2021 at 05:30:14PM +0000, Timon Baetz wrote: > > > > Get regulator from parent device's node and extcon by name. > > > > > > > > Signed-off-by: Timon Baetz > > > > --- > > > > drivers/power/supply/max8997_charger.c | 12 ++++++++---- > > > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/power/supply/max8997_charger.c b/drivers/power/supply/max8997_charger.c > > > > index 321bd6b8ee41..625d8cc4312a 100644 > > > > --- a/drivers/power/supply/max8997_charger.c > > > > +++ b/drivers/power/supply/max8997_charger.c > > > > @@ -168,6 +168,7 @@ static int max8997_battery_probe(struct platform_device *pdev) > > > > int ret = 0; > > > > struct charger_data *charger; > > > > struct max8997_dev *iodev = dev_get_drvdata(pdev->dev.parent); > > > > + struct device_node *np = pdev->dev.of_node; > > > > struct i2c_client *i2c = iodev->i2c; > > > > struct max8997_platform_data *pdata = iodev->pdata; > > > > struct power_supply_config psy_cfg = {}; > > > > @@ -237,20 +238,23 @@ static int max8997_battery_probe(struct platform_device *pdev) > > > > return PTR_ERR(charger->battery); > > > > } > > > > > > > > + // grab regulator from parent device's node > > > > + pdev->dev.of_node = iodev->dev->of_node; > > > > charger->reg = devm_regulator_get_optional(&pdev->dev, "charger"); > > > > + pdev->dev.of_node = np; > > > > > > I think the device does not have its own node anymore. Or did I miss > > > something? > > > > The idea is to reset of_node to whatever it was before (NULL) and basically > > leave the device unchanged. Probe might run again because of deferral. > > Good point. > > > > > > > if (IS_ERR(charger->reg)) { > > > > if (PTR_ERR(charger->reg) == -EPROBE_DEFER) > > > > return -EPROBE_DEFER; > > > > dev_info(&pdev->dev, "couldn't get charger regulator\n"); > > > > } > > > > - charger->edev = extcon_get_edev_by_phandle(&pdev->dev, 0); > > > > - if (IS_ERR(charger->edev)) { > > > > - if (PTR_ERR(charger->edev) == -EPROBE_DEFER) > > > > + charger->edev = extcon_get_extcon_dev("max8997-muic"); > > > > + if (IS_ERR_OR_NULL(charger->edev)) { > > > > + if (!charger->edev) > > > > > > Isn't NULL returned when there is simply no extcon? It's different than > > > deferred probe. Returning here EPROBE_DEFER might lead to infinite probe > > > tries (on every new device probe) instead of just failing it. > > > > extcon_get_extcon_dev() just loops through all registered extcon devices > > and compared names. It will return NULL when "max8997-muic" isn't > > registered yet. extcon_get_extcon_dev() never returns EPROBE_DEFER so > > checking for NULL seems to be the only way. Other drivers using that > > function also do NULL check and return EPROBE_DEFER. > > Indeed, thanks for clarification. Looks good: > > Reviewed-by: Krzysztof Kozlowski Is something blocking this from being accepted? Timon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel