From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84829C433E0 for ; Tue, 9 Mar 2021 09:20:43 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CBC96522F for ; Tue, 9 Mar 2021 09:20:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CBC96522F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FFx/LHdJmF9lV/EwGWSpHC+UV68siOzQjcXASctYRfA=; b=nXEfo7BkAaO9yx9RN9THFX0Yl PPMj86vKz9SeaAFegasIjov9+MnkxfIFaaBL1AMu4z9dbblD2kclGlINpiIHMKhzB2dQgQ7PPaK11 EZ/a0OER7acrGCW+1Q16EdneOpsNy5+OImXQ1jvDpj73P2CdCWG+eQnqXOmQBjwOgndWZsT3BBQwT 1mmqyfflp7Tst3OjqkqquJJOhSWbbZ8H9i68yKlr1NJNAXWgULeDkMOfupaPJcdbVW3QvBK/aGm5o 0YnfKXoZ5Z+3X7XwNMtAvoo4ecX112prmIb4PWrllMJDS2PiuTOp4rQeHg8HaVd5oss7qax7HD/YO P39zTXgWA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJYWH-0048Dk-8X; Tue, 09 Mar 2021 09:19:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJYWB-0048DP-HO for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 09:19:09 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 24BBB6522E; Tue, 9 Mar 2021 09:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615281546; bh=iX5Ic4F1TQ9OsADSxd3DzW3ka+qK+zltIfosLa1xPnE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KWXvM8qnjXRUrFChgfgfN8wrAg2Zw7mugk8o9/AZ6IM+OHZ2oZcY/0M8HhvLIxGvq KRB6N0igFA3GEUaU02gMZTAl6wApANR6GSU4d2B0k4/wq9iuYQiFYy6CNckjCp3vVB 7bSEI+S9y7vbZkBpkQqUVl5uMUpR2yaIyI3/jnIsm0yWGIMPw7HN4jMehiFIbI2qU5 df0vWg1qG89M36dTl33cX6hHZwRAT2g3pdUF1pqlDB3UNApreiu4RU2L8Yl4KiHWKT eo+JcoxU9vwVMkpscPY67n9xt6Y+Lwju0e0DKayD0gZKJq9p1voN6UqafKPKv2HDJf autnRGTGsHx5A== Date: Tue, 9 Mar 2021 09:19:00 +0000 From: Will Deacon To: Viresh Kumar Cc: Rafael Wysocki , Catalin Marinas , Sudeep Holla , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Vincent Guittot , Ionela Voinescu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback Message-ID: <20210309091900.GA27747@willie-the-truck> References: <20210308145209.GA26458@willie-the-truck> <20210309041643.tcyv6rpto4k3sv5v@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210309041643.tcyv6rpto4k3sv5v@vireshk-i7> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_091907_856931_9091DFD2 X-CRM114-Status: GOOD ( 19.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 09, 2021 at 09:46:43AM +0530, Viresh Kumar wrote: > On 08-03-21, 14:52, Will Deacon wrote: > > On Mon, Mar 01, 2021 at 12:21:17PM +0530, Viresh Kumar wrote: > > > +EXPORT_SYMBOL_GPL(topology_set_scale_freq_source); > > > > I don't get why you need to export this in this patch. The arm64 topology > > code is never built as a module. > > > > > +EXPORT_SYMBOL_GPL(topology_clear_scale_freq_source); > > > > Same here. > > > > > +EXPORT_SYMBOL_GPL(freq_scale); > > > > And here. > > After this patch, any part of the kernel can use these > helpers/variables to run their own implementation of tick-freq-scale > and so this patch looked to be the right place for that to me. > > And the second patch in the series updates the CPPC cpufreq driver > (tristate) to use these exported symbols, so we have the first user > who needs the exported symbols as well. Ok, then how about putting the exports in their own patch that immediately precedes the patch which uses them? I think that would make it much clearer. > > This one probably wants a less generic name as well if it's going > > to be exported. > > x86 names it arch_freq_scale, perhaps we should stick to that instead. Sounds like a improvement, thanks. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel