From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F238C433DB for ; Wed, 10 Mar 2021 02:58:55 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED31A64FE8 for ; Wed, 10 Mar 2021 02:58:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED31A64FE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yI1qoHvSvnEzCpfF7Xd9uCNh02TxI/LzxsZeXbVPAQE=; b=LOReeAB5S0npxhByQOwOHK09A hO6C2bH2r9DRpKpP64WLt62Ubwk0/oFtgRec1S/gC3VAq862zXUw2BSg895R4oVZREBtHADMjbaMV SfKIpJrz4k1KaprpirpeWsK0Pd9CdvMtdpzlxO9dEotuQsHKAglG9XwQwh3Twi4+HeKUz6RC3Qzz8 c0fZckcI/z84/1vBsB2y6hM0x1aPS80EPTdozX74fEjuIppkdHBHvxX5oQ2xD9NzcwgJWuaQ5dwh/ YVrMm1ksftaEMuYeSRL7mhTvd3o7k07eACS2LwAAKzut+qzdndJClH3xACw+QqsEn6CaNU6Syjm/r SHHpaIIyw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJp2K-005qVH-Fr; Wed, 10 Mar 2021 02:57:25 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJozu-005qH2-MH for linux-arm-kernel@lists.infradead.org; Wed, 10 Mar 2021 02:55:17 +0000 Received: by mail-pf1-x435.google.com with SMTP id y13so7597707pfr.0 for ; Tue, 09 Mar 2021 18:54:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=F7L2rfwUmYIB7S+xDvEKqrJHTr/uik/Q3th44+Fbt0s=; b=CzYw2jEQodgFUJkFkDCkjqeMhkZ/maXPSsR6uL5nluiwEGymjIwN6FaDnhBr6C8qZX QnnK1649X6ZSZEjfjSM096wR1FImuJXXS0L0LpF/kViYWtWBHPrKsWb5p/b9iVB91TQX /1PZQh5T/WjCzTDF4QmHBVP+Ch6cLXz6dcC9P3dMitAXW9POtDU/eR/MrcjpGsNmPESp 8S6UUzmZLu9xJdMztduwcTIeZrTUAYOC6puynMFFQO/vDRQXFWbsQfoFYqHevvDQEHLD IqHuULYzeBYvJ1O3KoapWQ2Mzd6P563s4SM+HCJ2DoFduuwRVaNU3ZB0EkUhsdF9OLth MsUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=F7L2rfwUmYIB7S+xDvEKqrJHTr/uik/Q3th44+Fbt0s=; b=bGvEJoPdbBQJHy2I3Ph1JM5ciYBVVk+9gpZspNj91AtE3qk5MHWvXp0VJyQMW3vn/Q 5DX19r7ig/h3I0Ff+W23jDK5d4zE/cW4GnAtdtkCXqgul866o19203b80geLZiG3my/A 9xGDDEPpfrpj7LU3PQOqSOZFo9fxIhP45v3Dv7GsvNKkK1gn4TcxL343LUDxIrpVmw3n keIT0l9Mj9DyNqhAVg/RT4Ci2sI7OWP9Ry9gJNJxlTVwr8r/OzOgipkQcTofz/KdsX8A Oq1ez5ou26Hak0AxxgYuiA0dPVht0NFBqAS3aAHCjETkDTvYDXWMYdnjPRIvWZrV4NJc NITQ== X-Gm-Message-State: AOAM531kk215aQ+81TtYKU1SlmAKFT+K/nRUTq7glYveckjrDhe4mp/c TLbRr+aSFRlD7T6yjQ6dHTQZVw== X-Google-Smtp-Source: ABdhPJxy3zQnKdDxFnFa4MAF0F/2s0x0egEHF+1b/xyt2pTLAUFBzQ5G1nVeO1qogvOJVDwEg+/8WA== X-Received: by 2002:a62:1911:0:b029:1ed:b722:3b50 with SMTP id 17-20020a6219110000b02901edb7223b50mr1094613pfz.70.1615344893238; Tue, 09 Mar 2021 18:54:53 -0800 (PST) Received: from localhost ([122.171.124.15]) by smtp.gmail.com with ESMTPSA id fa21sm4034926pjb.25.2021.03.09.18.54.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Mar 2021 18:54:52 -0800 (PST) Date: Wed, 10 Mar 2021 08:24:50 +0530 From: Viresh Kumar To: Ionela Voinescu Cc: Rafael Wysocki , Catalin Marinas , Will Deacon , Sudeep Holla , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Vincent Guittot , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback Message-ID: <20210310025450.plggnrhbsrpycteq@vireshk-i7> References: <20210309151157.GB25243@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210309151157.GB25243@arm.com> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210310_025515_076541_8CC4911B X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09-03-21, 15:11, Ionela Voinescu wrote: > On Monday 01 Mar 2021 at 12:21:17 (+0530), Viresh Kumar wrote: > > diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h > > index 0f6cd6b73a61..3bcfba5c21a7 100644 > > --- a/include/linux/arch_topology.h > > +++ b/include/linux/arch_topology.h > > @@ -34,7 +34,19 @@ void topology_set_freq_scale(const struct cpumask *cpus, unsigned long cur_freq, > > unsigned long max_freq); > > bool topology_scale_freq_invariant(void); We don't normally add blank lines between declarations (variables or function), like what's done here. > > > > -bool arch_freq_counters_available(const struct cpumask *cpus); > > +enum scale_freq_source { > > + SCALE_FREQ_SOURCE_CPUFREQ = 0, > > + SCALE_FREQ_SOURCE_ARCH, > > +}; > > + > > +struct scale_freq_data { > > + enum scale_freq_source source; > > + void (*set_freq_scale)(void); > > +}; > > + > > +void topology_scale_freq_tick(void); > > +void topology_set_scale_freq_source(struct scale_freq_data *data, const struct cpumask *cpus); > > +void topology_clear_scale_freq_source(enum scale_freq_source source, const struct cpumask *cpus); > > Nit: can you split these lines? And so in order to be consistent across the file, I haven't added one here. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel