From: Maxime Ripard <maxime@cerno.tech>
To: Evgeny Boger <boger@wirenboard.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 1/2] net: allwinner: reset control support
Date: Wed, 10 Mar 2021 09:39:57 +0100 [thread overview]
Message-ID: <20210310083957.utmn7twsm2qgksfp@gilmour> (raw)
In-Reply-To: <20210309012116.2944-2-boger@wirenboard.com>
[-- Attachment #1.1: Type: text/plain, Size: 1727 bytes --]
Hi,
On Tue, Mar 09, 2021 at 04:21:15AM +0300, Evgeny Boger wrote:
> R40 (aka V40/A40i/T3) and A10/A20 share the same EMAC IP.
> However, on R40 the EMAC is gated by default.
>
> Signed-off-by: Evgeny Boger <boger@wirenboard.com>
> ---
> .../net/allwinner,sun4i-a10-emac.yaml | 11 +++-
> drivers/net/ethernet/allwinner/sun4i-emac.c | 65 +++++++++++++++++--
> 2 files changed, 70 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml
> index 8d8560a67abf..27f99372d153 100644
> --- a/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml
> +++ b/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml
> @@ -15,7 +15,12 @@ maintainers:
>
> properties:
> compatible:
> - const: allwinner,sun4i-a10-emac
> + oneOf:
> + - const: allwinner,sun4i-a10-emac
> + - const: allwinner,sun4i-r40-emac
> + - items:
> + - const: allwinner,sun4i-r40-emac
> + - const: allwinner,sun4i-a10-emac
There's no need to handle the fallback case, it should have either one
of the two, not both.
The good news is that it simplifies the binding here too, since you can
use an enum
The DT binding modifications are usually in a separate patch too
>
> reg:
> maxItems: 1
> @@ -30,6 +35,9 @@ properties:
> description: Phandle to the device SRAM
> $ref: /schemas/types.yaml#/definitions/phandle-array
>
> + resets:
> + maxItems: 1
> +
You should make resets required for the R40 compatible too through an if
clause.
It looks good otherwise, thanks!
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-10 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 1:21 [PATCH v2 0/2] sun8i: r40: second ethernet support Evgeny Boger
2021-03-09 1:21 ` [PATCH v2 1/2] net: allwinner: reset control support Evgeny Boger
2021-03-09 17:19 ` Rob Herring
2021-03-10 8:39 ` Maxime Ripard [this message]
2021-03-09 1:21 ` [PATCH v2 2/2] dts: r40: add second ethernet support Evgeny Boger
2021-03-09 1:32 ` Evgeny Boger
2021-03-10 8:40 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310083957.utmn7twsm2qgksfp@gilmour \
--to=maxime@cerno.tech \
--cc=boger@wirenboard.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox