From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA47C433DB for ; Wed, 10 Mar 2021 08:42:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95B8E64FE7 for ; Wed, 10 Mar 2021 08:42:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95B8E64FE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=by/sUmCUxygJgWwQUet7Gp7RVpVrCKhf3dLR9Mym42w=; b=TOoLQ/lqCaaitTsiQpXDiEtMF MpI7/B2mwQyw7ZfhAmsENup15z3w6nT1ZYt7JccRX4tfNoN5AJy4Qrns7LndlaHwBvzu5c0TtZ03H SIJziGylL3rYwJsuiN+//Kg5g/0Xxkhz5QXbggIxXiIXzm0QHnQCCd1zRsjTTB9Jmom/90JpPfk5+ mi3zhVbxBBqZ/+IXxFVSgTWDrL1M9w1OuZk+SQIjX0dLgiEi5jMVcxDbGuPQnoxAm9NrJBJOClhNP S1G0NayLYZ0g4sHP7aKEo6atEviN/Hx2rxcm3vSaMAeiBF1RzWkuz/xLegt6UnhT97xuPW7eVPp2s bfoPhP9bw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJuOk-006K1D-LZ; Wed, 10 Mar 2021 08:40:57 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJuOf-006Jzv-EW for linux-arm-kernel@lists.infradead.org; Wed, 10 Mar 2021 08:40:51 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ACF435C011A; Wed, 10 Mar 2021 03:40:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 10 Mar 2021 03:40:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=4aFa8ajfrfPGsMoJ6jBruT/ef0k /BrtB121ENQhgRqs=; b=lvCqxqrBgD2OH6YcUh8VIANSBBliqX6juN0F7iyviO5 1oKt9HE9jn3y/C+wRvzkHsG5dTNWhMQB7KyAhPtA4WMmtPStNk3oOWYl66/rxkNy 5ZnuGJWwogjL8wDkxa0kE7UigEBEmP3t4U7gTHcfORYAhj/MJak7ZsnNDubjA1gJ O5tsRL2feNOpcR1LNuzgg5n3Wilu2xYjFovKq1d5fTaENJtQnpCflswz/BY1DlkA oWlw2mr0L/fE+fRfG34Bl3IBTB6rg7s5vrtsBijHaKxkLA5ZaH/3vFqUSKJWyNQQ jtNPbqQD9i5wpKYrRrpk9nIZIoCpBY2R2TsjFevjJ7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=4aFa8a jfrfPGsMoJ6jBruT/ef0k/BrtB121ENQhgRqs=; b=Tz/nthDkogD567Uyx4ij9t cu4P8ZTsDnIpAzRd/6ongJmdw1AFhCF+UEG7kZ5KwDh0d3Z9JplGaVSZeaMYWk1E 36ZnhMCdTnuT1QaiLySGhgSccVsCJ3rkO6dvVrIsCag2TDtu5d9hmEC4+MehaSH1 en8X17uCl+mLBuQJTrAvASR1d419cwSZan82My7QL8yAaPJvoFtdWEW3p2DnkpnD aW31kJ9yvHOX/aoscp8BWL+RDsYB5wleZenn1nlJuh8mq32vtTffNJpfHRXmxC8M QQF/flRKUwvxhwUHQHDN+mUbg40qigKzX0JYe3N741wftx/H6PEpK4KErKSDCwUA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddujedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheei heegudenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 60A65240054; Wed, 10 Mar 2021 03:40:47 -0500 (EST) Date: Wed, 10 Mar 2021 09:40:44 +0100 From: Maxime Ripard To: Evgeny Boger Cc: Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH v2 2/2] dts: r40: add second ethernet support Message-ID: <20210310084044.gopd6hh5qbfhe7sk@gilmour> References: <20210309012116.2944-1-boger@wirenboard.com> <20210309012116.2944-3-boger@wirenboard.com> MIME-Version: 1.0 In-Reply-To: <20210309012116.2944-3-boger@wirenboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210310_084049_920270_B8070F03 X-CRM114-Status: GOOD ( 18.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8762160824441862569==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8762160824441862569== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4lnpgufg5h5jmxfr" Content-Disposition: inline --4lnpgufg5h5jmxfr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Mar 09, 2021 at 04:21:16AM +0300, Evgeny Boger wrote: > R40 (aka V40, A40i, T3) has two different Ethernet IP > called EMAC and GMAC. > EMAC only support 10/100 Mbit in MII mode, > while GMAC support both 10/100 (MII) and 10/100/1000 (RGMII). >=20 > In contrast to A10/A20 where GMAC and EMAC share the same pins > making EMAC somewhat pointless, on R40 EMAC can be routed to port H. > Both EMAC (on port H) and GMAC (on port A) > can be then enabled at the same time, allowing for two ethernet ports. >=20 > Signed-off-by: Evgeny Boger > --- > arch/arm/boot/dts/sun8i-r40.dtsi | 59 ++++++++++++++++++++++++++++++++ > 1 file changed, 59 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r= 40.dtsi > index d5ad3b9efd12..c31386e421b1 100644 > --- a/arch/arm/boot/dts/sun8i-r40.dtsi > +++ b/arch/arm/boot/dts/sun8i-r40.dtsi > @@ -217,6 +217,20 @@ > #size-cells =3D <1>; > ranges; > =20 > + sram_a: sram@0 { > + compatible =3D "mmio-sram"; > + reg =3D <0x00000000 0xc000>; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + ranges =3D <0 0x00000000 0xc000>; > + > + emac_sram: sram-section@8000 { > + compatible =3D "allwinner,sun4i-a10-sram-a3-a4"; > + reg =3D <0x8000 0x4000>; > + status =3D "okay"; > + }; > + }; > + > sram_c: sram@1d00000 { > compatible =3D "mmio-sram"; > reg =3D <0x01d00000 0xd0000>; > @@ -541,6 +555,33 @@ > drive-strength =3D <40>; > }; > =20 > + emac_pa_pins: emac-pa-pins { > + pins =3D "PA0", "PA1", "PA2", > + "PA3", "PA4", "PA5", "PA6", > + "PA7", "PA8", "PA9", "PA10", > + "PA11", "PA12", "PA13", "PA14", > + "PA15", "PA16"; > + function =3D "emac"; > + }; > + > + emac_ph_pins: emac-ph-pins { > + pins =3D "PH8", "PH9", "PH10", "PH11", > + "PH14", "PH15", "PH16", "PH17", > + "PH18","PH19", "PH20", "PH21", > + "PH22", "PH23", "PH24", "PH25", > + "PH26", "PH27"; > + function =3D "emac"; > + }; > + > + emac_pa_pins: emac-pa-pins { > + pins =3D "PA0", "PA1", "PA2", > + "PA3", "PA4", "PA5", "PA6", > + "PA7", "PA8", "PA9", "PA10", > + "PA11", "PA12", "PA13", "PA14", > + "PA15", "PA16"; > + function =3D "emac"; > + }; > + I guess you forgot to remove that node? Maxime --4lnpgufg5h5jmxfr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYEiGDAAKCRDj7w1vZxhR xRsKAQDQY/99RhS0OARN4qMmT2cMbn2EKyhjTO5RHm60LwcoVAEA83a8MXg06wW2 Y5Mq/YOkAYF4dwOPCstPyZHjZnwMRQ0= =uU/P -----END PGP SIGNATURE----- --4lnpgufg5h5jmxfr-- --===============8762160824441862569== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8762160824441862569==--