From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B30FAC433DB for ; Thu, 11 Mar 2021 16:48:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C90F64FCE for ; Thu, 11 Mar 2021 16:48:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C90F64FCE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=55ds/Wosg8zxrpGJSGjTEfElrDdsPbvb5tfSqaBBSYk=; b=hpI3owySMMhcceR9IRnEIIU/c p9BAWykJTNdIqN8W6KHRj6rt2JOQzQuGrhzD4LkcOMMmkjewsVBFzZ6DIDA4K8T5qzxtphsCcw7r0 uHLKoI+msrd9KgtRnLuNp7QgBbnbuPa0EqQfwy3+P4Kwsoe/l3OKV52dgxSWqDIJmXMPMze9MU9ib aWVoQwfSOtUp9wImJ5m7Pe1/sLN7REaZ+AxCf65lRVk0KPZSrJ6YBV6SoILqeDXpi9nhatigLj45l 6+2ggvBQl4eEcW4ZOk1H+MjYZeURhnhyz8OnDI+oFj8VmvJ55EK3UWp1s0P54iKxZrsHFIcwJ0KSE aBiRFZVAw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKOT2-009bsI-Lb; Thu, 11 Mar 2021 16:47:20 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKOSy-009brk-68; Thu, 11 Mar 2021 16:47:17 +0000 Received: by mail-ed1-x52b.google.com with SMTP id z1so3784001edb.8; Thu, 11 Mar 2021 08:47:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SX756dXupgS3itIHiEP07yjhdJyqc8DqtHCMzdh6MRo=; b=R9wg2pKVwClt4BFKX1kiHQ7mq/v3644NmsFSa2zgKZ+Kb6OrNqbR1V1dZy4zL9R4vu vLMpqQSxTBlMZ0t/6N8aPfWVUXykG8YcWk0cWKX5MjKRhlS5NRIPvZXyMMDi4jscxqz/ Ev7aGxqArVCDT9/XzGEjphh8HcBIwqNdVQiYor0aMMM6FsRRoVyxr7przjyqcmb/yZZ5 bAF5A6qjeby9EVZlPG8s93Tn0GDu0gFPp5KYkw/Y2sfLbuADksNLa5FtZtHW6Q2vU+hF dK4aXpg8pk/WBiV8F8x3swUMS0Y9HNodZkXwttw7rBQElyG32sI+RbnGR4qBoYUBGMcb LRSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SX756dXupgS3itIHiEP07yjhdJyqc8DqtHCMzdh6MRo=; b=bdkZcJN68IeEUqVzOmW7GA770zN719BABgOeiJzoZsjnfTVVm+GSuVC+EfbPfJ/TnH 0KRPsp/xsJjzJdiGuTj9t+i0rvPQCxT0AvawB0vO+nG4b8D12dyf57xueLEYP31BCg/P JZQKLrjAKpjNz+9YhsT8n5okHxbdxZ/1r9aJHKVSLpjzm6/4Bw8eJ7nDtDFs8WqPotmW kPk/IkSm1v93sbh8esAIH1g1Bk2EgWPmNjTA3F/eSYYAT1ktVjkzRIn724vlqDSo5TTG f1Mmivu48T25GpF7S7rIoCHHC4jzWWzZgsdkigczeUyi+B+6aybcya/1KBZ6xj7u22l9 kZ2Q== X-Gm-Message-State: AOAM531fuegAaGa7AKfo3cbUo23Bbf03GaB+otePri8afA06YcZdZHD0 XWRe7RPQ1uov8+u9HAS2VHM= X-Google-Smtp-Source: ABdhPJzbvJBnHK734cKDjR2nu98P9RPcWwwdIsl6VSvtR5afUwQr00mWWgTTX1afwARu8pPC3xNBhQ== X-Received: by 2002:aa7:d656:: with SMTP id v22mr9302062edr.119.1615481234980; Thu, 11 Mar 2021 08:47:14 -0800 (PST) Received: from BV030612LT ([81.18.95.223]) by smtp.gmail.com with ESMTPSA id da17sm1578584edb.83.2021.03.11.08.47.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 08:47:14 -0800 (PST) Date: Thu, 11 Mar 2021 18:47:11 +0200 From: Cristian Ciocaltea To: Philipp Zabel Cc: "David S. Miller" , Jakub Kicinski , Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver Message-ID: <20210311164711.GA892053@BV030612LT> References: <158d63db7d17d87b01f723433e0ddc1fa24377a8.1615423279.git.cristian.ciocaltea@gmail.com> <20210311064336.GA6206@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210311064336.GA6206@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210311_164716_294334_3DDC9C03 X-CRM114-Status: GOOD ( 22.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Philipp, Thanks for your quick review! I will incorporate the indicated changes in the next patch revision. Kind regards, Cristi On Thu, Mar 11, 2021 at 07:43:36AM +0100, Philipp Zabel wrote: > Hi Cristian, > > On Thu, Mar 11, 2021 at 03:20:13AM +0200, Cristian Ciocaltea wrote: > > Add new driver for the Ethernet MAC used on the Actions Semi Owl > > family of SoCs. > > > > Currently this has been tested only on the Actions Semi S500 SoC > > variant. > > > > Signed-off-by: Cristian Ciocaltea > > --- > [...] > > diff --git a/drivers/net/ethernet/actions/owl-emac.c b/drivers/net/ethernet/actions/owl-emac.c > > new file mode 100644 > > index 000000000000..ebd8ea88bca4 > > --- /dev/null > > +++ b/drivers/net/ethernet/actions/owl-emac.c > > @@ -0,0 +1,1660 @@ > [...] > > +static int owl_emac_probe(struct platform_device *pdev) > > +{ > [...] > > + priv->reset = devm_reset_control_get(dev, NULL); > > Please use > > priv->reset = devm_reset_control_get_exclusive(dev, NULL); > > instead, to explicitly state that the driver requires exclusive > control over the reset line. > > > + if (IS_ERR(priv->reset)) { > > + ret = PTR_ERR(priv->reset); > > + dev_err(dev, "failed to get reset control: %d\n", ret); > > + return ret; > > You could use: > > return dev_err_probe(dev, PTR_ERR(priv->reset), > "failed to get reset control"); > > regards > Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel