From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E11C433E9 for ; Thu, 11 Mar 2021 17:58:43 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F395D64FE5 for ; Thu, 11 Mar 2021 17:58:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F395D64FE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GSSjVUNTElMRCP5wMCHdLzKFpkR33nlCMe+WCgUqreY=; b=IsuGnboNmxDMXYPt7mB01ZdSI yro08aQf+61QaN0mOz5vAeItri7QsOIRtocWl0assGmab9RXGFRpsLjjzmFK+HFMPy0sskeBBYEKJ Au2BtlNppJBXd+LIfs4WFSaMavL9sV0fBJeTUwhj2Qz0N06hgRqHNK35M+00aHuCts+1ZZkOOeh/j wbJU90976GuHzsrBkmyGqhfWNRzajEBKZIVzIFSX6uzuFScc/XT1j29dNiSZRoGMvTTH7kEm51KYC uVX4Fq4HvnrbEqRTr9ckleabye5opnbWDCdw9TWOV4gyMA32WZSkQgYKb6uCsltGg9YEQ3aAwnjuT 9026yLQUQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKPYe-009mNZ-Bi; Thu, 11 Mar 2021 17:57:12 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKPYU-009mMV-CT for linux-arm-kernel@lists.infradead.org; Thu, 11 Mar 2021 17:57:08 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 12BHuxlk042621; Thu, 11 Mar 2021 11:56:59 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1615485419; bh=q08sJDe3heSV4QnUx6HBERqRFXasPw62PnUGroZLHvQ=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=EZ2htw8QV3Zy0M40FE+VW7TS8Ir0UPukIu0zvt8R36esfrQiA8LsmEk8SMdvSseOW s4ng9ZYR+Zo7Iq8tT+epEjwiEb2G3F//7E6jmcnGkI/wOmrf5FNGVCuUiIixUva+3c QWZrmNwtrLNVDGBUBwWYD2ZXG2oW8n7RM7TFOV5E= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 12BHuxsx110234 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 11 Mar 2021 11:56:59 -0600 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 11 Mar 2021 11:56:58 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Thu, 11 Mar 2021 11:56:58 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 12BHuw1U018537; Thu, 11 Mar 2021 11:56:58 -0600 Date: Thu, 11 Mar 2021 11:56:58 -0600 From: Nishanth Menon To: Jan Kiszka CC: Tero Kristo , Rob Herring , , , , Le Jin , Bao Cheng Su , Vignesh Raghavendra Subject: Re: [PATCH v4 3/3] arm64: dts: ti: Add support for Siemens IOT2050 boards Message-ID: <20210311175658.agmnphz2pjydwnc5@annex> References: <9bff40f434e5298890e5d139cc36cc46a0ca2d76.1615369068.git.jan.kiszka@siemens.com> <20210311131754.i5ewls6hgeitcgre@astonish> <8d076ff1-cdac-941f-e796-a2e6dba792ab@siemens.com> <20210311140056.fzvke3rrg6c2uuoa@uncouth> <519ae6b7-35db-1fdd-de1e-e0155e0ca82a@siemens.com> <20210311142151.5o54k7kmrnatufcw@target> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210311_175704_148456_4B075164 X-CRM114-Status: GOOD ( 24.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15:36-20210311, Jan Kiszka wrote: > On 11.03.21 15:21, Nishanth Menon wrote: > > On 15:14-20210311, Jan Kiszka wrote: > > > > [...] > > > >>> > >>> See [1] compare the compatibles against > >>> Documentation/devicetree/bindings -> I think you should describe what > >>> your hardware really is though. > >> > >> This SPI bus is routed to an Arduino connector. By default, userspace > >> (e.g. mraa) takes ownership and adds the desired logic for what is being > >> connected. We have no idea what shield or other extension the user adds, > >> though. > > > > overlays look like the right approach for variable systems like these. > > It is not exactly plug and play.. but it does provide a level of > > flexibility that is helpful. > > Yes, that's for extensions which have kernel drivers. The default model > here is userspace, though. Will add as a separate patch to our queue for > now. My colleagues did some checkups and pulled up a few thread on spidev of potential interests.. See: https://patchwork.kernel.org/project/spi-devel-general/patch/1427499742-26916-1-git-send-email-broonie@kernel.org/ https://yurovsky.github.io/2016/10/07/spidev-linux-devices.html etc... I'd split the spidev node alone as an addendum indicate the checkpatch warning, describe the details and loop in spidev list, Mark, et.al. to discuss the direction. I am hoping we can get this resolved or get a direction for .13-rc1 But that said, I see some examples such as for i in `git grep ".compatible" drivers/spi/spidev.c|grep =|cut -d '=' -f2|cut -d ' ' -f2`; do git grep $i Documentation/devicetree/bindings/; done Documentation/devicetree/bindings/spi/spi-mux.yaml: compatible = "lineartechnology,ltc2488"; Documentation/devicetree/bindings/misc/ge-achc.txt:- compatible : Should be "ge,achc" Documentation/devicetree/bindings/misc/ge-achc.txt: compatible = "ge,achc"; Documentation/devicetree/bindings/misc/lwn-bk4.txt:- compatible : Should be "lwn,bk4" Documentation/devicetree/bindings/misc/lwn-bk4.txt: compatible = "lwn,bk4"; So, the shield could be hosting one of those say ge,achc or maybe lwn,bk4 ?- will probably be good to document the dts is for such a configuration, though it is possible that such a configuration might work for others? I agree with Mark that "dt should indicate specific hardware" and we should constraint the definition in such a scope? [...] > > > >> Are we talking about spidev here? Then let's drop that node, but I do > >> need to know how to describe spidev properly > > > > yes - the spidev is my problem. can you drop the node and repost? i cant > > locally modify and hope it works. > > > > Done. Thanks, I will try and pick up the v5 later today - need to redo my sanity checkups. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel