From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8445C433E0 for ; Fri, 12 Mar 2021 02:44:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EB9164F87 for ; Fri, 12 Mar 2021 02:44:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EB9164F87 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4LttNtp55VNGx21SBDAMW2lGJH6QNlcl5pHH7sWrqIQ=; b=pXXQgRcib8ubrFOiS7jdhURTe ulU87tXY7lWcld3CFqCzg2F9ho/Zbooad5W9FTGXFbdz8DLiKYDdbjhmmDIV3yyT4Ux/Aa1dzIZeQ 7H6zwumzap9MbNOKVRqFmF5Fd1VW75rxaXACGImsr8plPIHq52CfA3FjOaTI82hRk5ROj2uMxsZC8 ZqLmCyI5tba8iiIElCcBQm86Jm/Welyx7KuaCYeisBLvEDWQV2AsEqf9NRkBst6FTWp8LQJ1j+j6Z 8Z1Jg/KGRXscE1PLVwtIeyC8/Ysf9qmfSwj4+ArNN06VS4ui9Mweb6/4kyIR98xbmenFeYZscep7h xzp8A16bQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKXlv-00AUih-Vb; Fri, 12 Mar 2021 02:43:28 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKXlp-00AUho-Bh for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 02:43:25 +0000 Received: by mail-pl1-x62f.google.com with SMTP id a8so4704545plp.13 for ; Thu, 11 Mar 2021 18:43:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BNPsz0QLD3vM6+qNFMQ0OL0lFNeTebIONp/Q9dpVBmA=; b=QFHHVkV6BruBDLSqpSS5ZgpkzbKbFL9XcSmhEzK11y2mzkKvPQY9xpKatfo/Os2Tcd vIbekihgbpvMJcPrRh8gScKUhr1OSYBQOHteZqL4n+5ye8SOoMq6eXo3GEVPYy8bBb5Y 7GtOMqPoVrJccKwnjRy9eXNFAdum8kSTxSXaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BNPsz0QLD3vM6+qNFMQ0OL0lFNeTebIONp/Q9dpVBmA=; b=tPqkQokSZA+iwSqv80ciDUUaZyVD/+VJgogAdjEt5nR9uVXcHYrDjc/xTytiE1IF4r Dce6Qa9MGLJIXT2q0YhtQyFAp5xlzoJCWRxzN3ZdaX4gN+/WZZYk8iy1LxFppBytxb/r Oy7teVmmLFsl8RoFQoPoHadiJRpXJ1uHQWbUv5irDPzyWVfNP5KQsI6FTFcc0cMqZX+r SLV0kduXCTZJXCLQeJVfUL4OZx6b4Lko/17JKO3nrrF++J7KlMVxguMxOb6nmOHzs8mw IW2iQ16eAqWaqC64M0ma5cArGsZmb/j7ckPdlhZkPCyDxRxrEk5WZADtUPaqaVpvg6ch dTnw== X-Gm-Message-State: AOAM533I3V2mpUKpid7Pw4MXtfW9ppmRAbi4ViOWaqncAj6K035H2Iq5 BHqPbRAYj3MZvwB1JjnqY0Ur7w== X-Google-Smtp-Source: ABdhPJwFKoCF8whxDXdLUhHjkHxm4/5ycmKLMkKhBI3hwmAY7tNoQI3rQR7e3wSMLF56vcYEDo4ITg== X-Received: by 2002:a17:902:9a45:b029:e6:1444:5287 with SMTP id x5-20020a1709029a45b02900e614445287mr11337807plv.54.1615517000236; Thu, 11 Mar 2021 18:43:20 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d2sm382256pjx.42.2021.03.11.18.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 18:43:19 -0800 (PST) Date: Thu, 11 Mar 2021 18:43:18 -0800 From: Kees Cook To: Sami Tolvanen Cc: Nathan Chancellor , Nick Desaulniers , Masahiro Yamada , Will Deacon , Jessica Yu , Arnd Bergmann , Tejun Heo , bpf@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/17] workqueue: cfi: disable callback pointer check with modules Message-ID: <202103111840.58C5D95F@keescook> References: <20210312004919.669614-1-samitolvanen@google.com> <20210312004919.669614-6-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210312004919.669614-6-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_024323_098579_DF201DF7 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 11, 2021 at 04:49:07PM -0800, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG, a callback function passed to > __queue_delayed_work from a module points to a jump table entry > defined in the module instead of the one used in the core kernel, > which breaks function address equality in this check: > > WARN_ON_ONCE(timer->function != delayed_work_timer_fn); > > Disable the warning when CFI and modules are enabled. Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel