From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 966B5C433DB for ; Fri, 12 Mar 2021 02:44:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1735D64F6B for ; Fri, 12 Mar 2021 02:44:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1735D64F6B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nDqOIQ3542jjAb+ElMOQAw1h8XqYAO7YGUZTZOvWc9k=; b=VO4LFreGU5WyP4CB1wsbVvVZH xR8gZo4Yp1T/kLD7JG+jj1znxT3QX9hka+8OQy0SmJvF5XxyxChgqsxs9JdcyhsnHU7DOAk+LxzqC PXBIwWggPfh1oCg9MhvQ2PEftzfaXGMcPgRizRRxU4JA2Wmu642IO6CV38CdDWzxA78TeaFYTfo1o HyqBUEyvfIRNQnYwAKaZCR6CAA6rWQCy61L2UxRn2gIsMoovVu8BjCHSO0ohivarxeLx/2k41HOKr vG/bJMNEQMwhwuGBZKahsuE8C8XkjrpSouETrgjsP/bSxzD3Ab3FJ2GuretCb+O9SPl6k/akD1GiK Z+kWN4mqA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKXm5-00AUk6-LC; Fri, 12 Mar 2021 02:43:38 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKXlz-00AUj7-3e for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 02:43:32 +0000 Received: by mail-pj1-x1030.google.com with SMTP id x7-20020a17090a2b07b02900c0ea793940so10054586pjc.2 for ; Thu, 11 Mar 2021 18:43:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/xpt2hBBtW7abKxiGDhtHzeOxtHyWoss9DJQhg+zWHw=; b=fS3ImwrxxM2DE3EPiSqkkSbtg7AkezrPZEd01kE1dWcZszmGj9zSpFTelfDiqstTga WftPqqERieBGyxCVAYbjYrgDbk6A5YKAfLzSpkArBkvYk41+DSZTjZOqaRsE43dgsGh6 xNgvTqcdZWxl1z22bhI6cbBrEqddMCMIaR2WM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/xpt2hBBtW7abKxiGDhtHzeOxtHyWoss9DJQhg+zWHw=; b=SQH41L3O0ZvYQNDoXt9DQSngf3AMd2Z1yQ0GCZtlAR5jhzwf4WcYs/KRymV0BALvW1 LmNV+lYk3WM1ePkSE4ZpLoWiOMbaITJJ23yGbyYKTWdCaWuz2VSfKvUjczWRiN4AqqdA x0RGgsguX1HLJJBKXZjHmQ4WzBktJG8PWQOLRQfxHpzT8R3yOzHBKOWJVQFwXff4XJsL JOIIyQV78ju+cKeaVIDog+7ENbYU6bvu/jxxpePFj6aZzEeUa9Ol4MQdKrOPvae5lxnO +rK2qoXWrgtpzgJC8wuB0fbw65cV43KBdnxWa9sREdTBctWwqk0Meq6U/ZuTt5NaIDoQ +Wqw== X-Gm-Message-State: AOAM533tH+576IWuV/4OQlSN/NqDcwchwGRrve+KCg6HVhDtBKUzKPA9 Ilwzoh945S5lmcQXYmBM+YTWUCaZE0dfLw== X-Google-Smtp-Source: ABdhPJwJNeCPNAMR2ch3Yz24PwKhscrbLVrh74rWQAy51W9PeIe5O7weL/Cd+eYEYu9YKFOgM7LJSw== X-Received: by 2002:a17:90b:686:: with SMTP id m6mr11513193pjz.26.1615517009803; Thu, 11 Mar 2021 18:43:29 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s19sm3652536pfh.168.2021.03.11.18.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 18:43:29 -0800 (PST) Date: Thu, 11 Mar 2021 18:43:28 -0800 From: Kees Cook To: Sami Tolvanen Cc: Nathan Chancellor , Nick Desaulniers , Masahiro Yamada , Will Deacon , Jessica Yu , Arnd Bergmann , Tejun Heo , bpf@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/17] kthread: cfi: disable callback pointer check with modules Message-ID: <202103111843.9456B460@keescook> References: <20210312004919.669614-1-samitolvanen@google.com> <20210312004919.669614-7-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210312004919.669614-7-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_024331_343736_FF6B02FA X-CRM114-Status: GOOD ( 12.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 11, 2021 at 04:49:08PM -0800, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG, a callback function passed to > __kthread_queue_delayed_work from a module points to a jump table > entry defined in the module instead of the one used in the core > kernel, which breaks function address equality in this check: > > WARN_ON_ONCE(timer->function != kthread_delayed_work_timer_fn); > > Disable the warning when CFI and modules are enabled. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel