From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC833C433DB for ; Fri, 12 Mar 2021 02:48:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B18C64F87 for ; Fri, 12 Mar 2021 02:48:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B18C64F87 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=38cBLaeTjXaB2p6ysX49qkJ4kSn8FSliJnHFchT1jHQ=; b=klLS3EsIff7ItK3fOse2QIPvb IZttM0oJ2G5FEbXR80G+6VP82rxvBhLNnRjWlovQWQmezFTlCHv/R1F7hspfPJIIPmn3lcBVgbWes bY+ixZ2pIdan5sQWCtYjeNVIn9WQUrzCF3sW4GDORr/xJAvwCmMdQW73mrgirDgDjlDpZOS1p/zGQ 6DadKB2US8YggoPVn+ekhgxqft/q4LLVuONOfg5ZNvB35ujE750rD2MGs0NANayPACtYjn479PnLz +P3KwM3PIOVc7AXKrSICopkv08Ry87Yn4s9gvtfUmOzg3CHTeET2pzz22iz9SDi3qlHMOJDKG8U29 2reDkCzkQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKXoj-00AVJv-Vh; Fri, 12 Mar 2021 02:46:22 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKXoI-00AVC5-1D for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 02:45:58 +0000 Received: by mail-pf1-x42f.google.com with SMTP id 16so870112pfn.5 for ; Thu, 11 Mar 2021 18:45:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fac5qEwtGUhYp0i9UgwCZogHJ9c5ndld0feZGyCBugw=; b=Yf1jNw5HL2aTwVR53Xw1DAzotE73G/J5yX4CJQJM+XgSnLG8J+vcgPlTdkWIsbuxH6 QLetB8TZJzSr1rGbx8bLv9sUGwRivp/1eoW5SZQo+X5smcoP6bJxSpB38YAMtOOcS0+B DCLkvZloqcKPnWQPN8dAzDhjkMWed0N6lx+N8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fac5qEwtGUhYp0i9UgwCZogHJ9c5ndld0feZGyCBugw=; b=p5t5FuyMD9hQoyv/6QkVIyvMBAFu3IP+mQYvI4D7HVhCYtixp5FI48C6UMj+wyVVv9 jR60tCJC8MYxIRdJUncJ6Wjd6mJhQg3QAC83bgLdC4k35SHqMlOAcWA3DZqu2YErLfeg GHHt9DyO+HtHcOel5WXIVCTIfEnhnj/oAdbM9rImr3ULBVNM58gFFml69psh+3mViTOs sYhLq7mtskJ/ELzZbtuuykVlu0OcoBO/MJYOEcNq5HxV+wB7z340tqWGlUBf0gENfVMo Y+NzOYtgnoRg2wabEfQsh8UR73Aq8X38UDVWigS3NtS88QuflptYs+YCAfKH+YallVne z+Zg== X-Gm-Message-State: AOAM532xZuqMd9fjwV8Wc8tKyUlQt9nQXYFduGUb6y160+WRPLPg/F38 DsicOu9uUHMwypTAdBmvUbZMtg== X-Google-Smtp-Source: ABdhPJwkatQTgQrGNraBkT/X2lsgOwTQFo5tDOWcr2Yd9maNZVjYw6Sy3JQXdf01TBLr7xwbPU4otA== X-Received: by 2002:a62:35c2:0:b029:1f1:3a8b:83d5 with SMTP id c185-20020a6235c20000b02901f13a8b83d5mr10327491pfa.29.1615517152536; Thu, 11 Mar 2021 18:45:52 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n184sm3522810pfd.205.2021.03.11.18.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 18:45:51 -0800 (PST) Date: Thu, 11 Mar 2021 18:45:51 -0800 From: Kees Cook To: Sami Tolvanen Cc: Nathan Chancellor , Nick Desaulniers , Masahiro Yamada , Will Deacon , Jessica Yu , Arnd Bergmann , Tejun Heo , bpf@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/17] psci: use __pa_function for cpu_resume Message-ID: <202103111845.6E00D2E@keescook> References: <20210312004919.669614-1-samitolvanen@google.com> <20210312004919.669614-12-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210312004919.669614-12-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_024556_549342_62D5DAF9 X-CRM114-Status: GOOD ( 10.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 11, 2021 at 04:49:13PM -0800, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG, the compiler replaces function pointers with > jump table addresses, which results in __pa_symbol returning the > physical address of the jump table entry. As the jump table contains > an immediate jump to an EL1 virtual address, this typically won't > work as intended. Use __pa_function instead to get the address to > cpu_resume. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel