From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5942DC433E0 for ; Fri, 12 Mar 2021 11:41:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9EA664FC3 for ; Fri, 12 Mar 2021 11:41:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9EA664FC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=ddGA4GM3lest+OjGUUIBDMbRIgfD54PNbNH4X3mn2pY=; b=ibRC3aIblsjxXFLCwt99wK10ka 2/VMTrKYvHAHAFdtxmiikKYDvHMnn601325k/krWzKdQjr7YUxge8dOlO2GO3FNSKHGAibXqR16PD CqM7qtVDdvf/w9H2P2UC3WUC5JjKTBpzzjFoCOsLuwNEhH+zJnqFYv52gKKt5cfPlU3wtEaxTFLUR +vCynhFOGPaJ5W+Be8Xq9OT0z2s9QJ9V6lU8TUqWQPWKCSLLrNiR/iYvA3/PPJ2K76udr3wCpw+yx k5OvIB1tGZ182ydD0tr7ag5EHT+Kbv0/0JxNKJc/tH8LtYVkTxBAIHKVeQ3Rpiozw3iRxQAFpKex9 ybEsDy1A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKg91-00BJGY-4n; Fri, 12 Mar 2021 11:39:51 +0000 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKg8t-00BJG6-Ak for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 11:39:45 +0000 Received: by mail-qt1-x82b.google.com with SMTP id c6so3462626qtc.1 for ; Fri, 12 Mar 2021 03:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NT/ilheENgOprsbTHUaQCwi56ldWVaF5Qxrd2bZGlO8=; b=Znc2qyMfhmV9T+vXD0ouLh44xXVVwZup02RxmzqQ5JBgunqWiN4a6IP99IB/zLPjlK 5KS1sCQux1wKRhieH3Y14zys6+A1ovmpgScOvNFUMY5DF1+/m9bebEdiMmKbjWgtd5rW O22mqevo1plJYGITn6hotLufI2s2KCNAMyOTdD8P6ekQlwx9MY5sHbAocEiL1UM+ZMxA ebOA2TSc6JUM3znR7m48icqTbDHRKgmuYP8luWn+w4VGqVQIoaxkqZg+l53mUYDkOiYu 9mL0mFDvqw+2IooAlW/xpJ8e5tvXIR/L8i3Z5HH75sY9HMx2CqRykAInCEubqzPzc0Yq 2t2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NT/ilheENgOprsbTHUaQCwi56ldWVaF5Qxrd2bZGlO8=; b=lIKmltBeTFZKeaHYaxwb48LaaUY71YXC4m2qymealsQk0gr7z4ttNUWc1R1IQTsTf2 UtvPsOB7T1SV11/z7SvYHleWCuIp7gHyWlDIK3tzyhZsJt2aR+d4N38Bt117ODdlHuQB pnET3rdu9u7+IS+BWPH2mSt2IdvXRurzqxbqD5xp2ZCQMm6y9N3LPSavzDUNDekNF7AQ lpXBj6bAPXT+MRDLjgf2ZEzewV9sH6TyS4kpNBOa/QEg6iwsrkAC5SBIKOpJl09eZp5y XyAysENk74wJ/L2iyTw1AW8zKOkJOQeTRAzAKLbDt3ZQot729d39m/pLgGpexmuoptr8 TYGA== X-Gm-Message-State: AOAM533RJWj+2rpeuScf3VBlTUDH/svi9UIHJ/nULYu4/9x79B890wJt KxFdrNcCM8m9McVTEn1JOHETKiti0xyxaw== X-Google-Smtp-Source: ABdhPJzSvA4jvGC9YGZdYqh50498KMLZqupiNIhtqysI8txcxE5gNmZek3CNQCFbFLYqoZu6Le3bmg== X-Received: by 2002:ac8:4314:: with SMTP id z20mr11491994qtm.127.1615549181991; Fri, 12 Mar 2021 03:39:41 -0800 (PST) Received: from localhost.localdomain ([2804:14c:482:919:6d66:63bd:7809:96db]) by smtp.gmail.com with ESMTPSA id o23sm3669319qtm.31.2021.03.12.03.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 03:39:41 -0800 (PST) From: Fabio Estevam To: shawnguo@kernel.org Cc: kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, andrew@lunn.ch, qiangqing.zhang@nxp.com, Fabio Estevam Subject: [PATCH] ARM: imx6ul-14x14-evk: Do not reset the Ethernet PHYs independently Date: Fri, 12 Mar 2021 08:37:46 -0300 Message-Id: <20210312113746.1405836-1-festevam@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_113943_540415_E47F18BB X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The imx6ul-evk board designer took the bad decision to tie the two Ethernet PHY reset lines together. This prevents one Ethernet interface to work while the other one is brought down. For example: # ifconfig eth0 down # [ 279.386551] fec 2188000.ethernet eth1: Link is Down Bringing eth0 interface down also causes eth1 to be down. The Ethernet reset lines comes from the IO expander and both come in logic level 0 by default. To fix this issue, remove the Ethernet PHY reset descriptions from its respective PHY nodes and force both Ethernet PHY lines to be at logic level 1 via gpio-hog. Fixes: 2db7e78bf02b ("ARM: dts: imx6ul-14x14-evk: Describe the KSZ8081 reset") Reported-by: Joakim Zhang Signed-off-by: Fabio Estevam --- arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi index c593597b2119..5a1e10def6ef 100644 --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi @@ -210,9 +210,6 @@ ethphy0: ethernet-phy@2 { micrel,led-mode = <1>; clocks = <&clks IMX6UL_CLK_ENET_REF>; clock-names = "rmii-ref"; - reset-gpios = <&gpio_spi 1 GPIO_ACTIVE_LOW>; - reset-assert-us = <10000>; - reset-deassert-us = <100>; }; @@ -222,9 +219,6 @@ ethphy1: ethernet-phy@1 { micrel,led-mode = <1>; clocks = <&clks IMX6UL_CLK_ENET2_REF>; clock-names = "rmii-ref"; - reset-gpios = <&gpio_spi 2 GPIO_ACTIVE_LOW>; - reset-assert-us = <10000>; - reset-deassert-us = <100>; }; }; }; @@ -243,6 +237,22 @@ &can2 { status = "okay"; }; +&gpio_spi { + eth0-phy-hog { + gpio-hog; + gpios = <1 GPIO_ACTIVE_HIGH>; + output-high; + line-name = "eth0-phy"; + }; + + eth1-phy-hog { + gpio-hog; + gpios = <2 GPIO_ACTIVE_HIGH>; + output-high; + line-name = "eth1-phy"; + }; +}; + &i2c1 { clock-frequency = <100000>; pinctrl-names = "default"; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel