From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C525C433E0 for ; Sat, 13 Mar 2021 13:58:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1C6C64F18 for ; Sat, 13 Mar 2021 13:58:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1C6C64F18 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z++4LyUoaA6noobr2lKLASifykiuJE68uJYFeDN5nPw=; b=lCkQ/YhADMQAUuHaPwIwYMNkS 55NVKT/KQew1xhBXhRXIUP/Z3A+VHdw8GZ3HdNZhRJyzojGdUp6rdEc4VjXALo7zUYNvdWQLu473T N0ZqLmTXHMJ+BeO4yV6DarK7LZLZxN8TzrKLasLEMiLFoBOcY2bKgvgOnHOWWDEe65dCvpgRgsX+D Wgu1YNh0fINXw9Pjj1/D8hnx3Hb0xjpPEiDdEZ6nDvXGKDxsq/O3YOFiANlJd6V0EWdZmfR/WSrlH oR9PDenQ4AgQd1RvPi3NfxHLOVg02/0L9UG0BdSd5IaUKJNjGm7XA6Bt2RkczfC1Q3GuUoTCaEYVw xbbhhs3BQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lL4kH-00DFk9-Gn; Sat, 13 Mar 2021 13:56:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lL4kC-00DFjn-JI for linux-arm-kernel@lists.infradead.org; Sat, 13 Mar 2021 13:55:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 38BF064ECC; Sat, 13 Mar 2021 13:55:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615643749; bh=HZDFAaAc+30zj26a6rHFHmvPP4XFn4P7Za6e7XITPq8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lO7JHPo4f6/WB/Xv9sDqVR82RDOtiY1K/UipRnUEWaBbNnn/32huTsonbccHO/v8F dyuoeOT1YDjIHNXJzF4Ftwl66ZaNA+zOKBgxgK0ycWfgF8VElW5PBsrum7eK/Bo66m MJt1qTOHHQKTcUOE+7y7R7gLZcG3QS91Vm2huCVPJ7GaW7IfHmrrO+79lXROiSdpYS zVvvCwEKEgRtMKIH7DB5eOmLlyzXdpzSk9apm4WVRMLxte/lb8qHWlSoQjbBbYGUmr zISH2LavPJzv8itmB5+gmJsWhR/jK38gTkgwO3NqpmsmynmdyI9KKfAR1vi776uM05 0VJ908SgjsETw== Date: Sat, 13 Mar 2021 21:55:40 +0800 From: Peter Chen To: Frank Li Cc: pawell@cadence.com, a-govindraju@ti.com, linux-imx@nxp.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dan.carpenter@oracle.com Subject: Re: [PATCH 1/1] usb: cdns3: fix static checker warning. Message-ID: <20210313135540.GA11729@b29397-desktop> References: <20210310160125.810157-1-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210310160125.810157-1-Frank.Li@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210313_135552_882956_F230996B X-CRM114-Status: GOOD ( 17.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21-03-10 10:01:25, Frank Li wrote: > The patch c450e48eb570: "usb: cdns3: add power lost support for > system resume" from Feb 18, 2021, leads to the following static > checker warning: > > drivers/usb/cdns3/core.c:551 cdns_resume() > error: uninitialized symbol 'ret'. > > drivers/usb/cdns3/core.c > 544 > 545 if (!role_changed) { > 546 if (cdns->role == USB_ROLE_HOST) > 547 ret = cdns_drd_host_on(cdns); > 548 else if (cdns->role == USB_ROLE_DEVICE) > 549 ret = cdns_drd_gadget_on(cdns); > > "ret" is uninitialized at else branch. > > Signed-off-by: Frank Li > --- > drivers/usb/cdns3/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c > index 5d486c8a9d99..bb739d88179f 100644 > --- a/drivers/usb/cdns3/core.c > +++ b/drivers/usb/cdns3/core.c > @@ -527,7 +527,7 @@ int cdns_resume(struct cdns *cdns, u8 set_active) > struct device *dev = cdns->dev; > enum usb_role real_role; > bool role_changed = false; > - int ret; > + int ret = 0; > > if (cdns_power_is_lost(cdns)) { > if (cdns->role_sw) { > -- > 2.25.1 > Hi Frank, If this issue is reported by Dan, you may add his reported-by tag. Besides, please keep your signed-of-by tag as the same with your patch author. I fixed both, you do not need to re-send. -- Thanks, Peter Chen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel