From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C699C433DB for ; Mon, 15 Mar 2021 21:42:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD92264F4C for ; Mon, 15 Mar 2021 21:42:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD92264F4C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:From:Subject:Cc: To:Message-Id:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NMb+VgA1ygcVDRJXkdLM/fXy8yukNP3QGjef1CrVHWQ=; b=ThdzSIxdI/qPEazMuD9D1ScyN UFlGwuvumfjz8fVlbJEHo0v3CwEcsnZeTBzveRxUMLTrDfuXPv/go71fStzUvhFpygBTRCurzg8/F uYh7+zqsGbcktQLLgEgNksWJmiwmbVxhMN1ix816l98tth6yOCacft4HaTzZeLDzOLRTfRiS48Wnj xYSdsk1CwH3sBDPd/NLq53KnAoGn5upokhbBIsLIX/gmnRlq7JmxIlRAniihRhFRDdENIWPIa8NMv RPl46aR839UCyWm5r+p0CipkJK/kXgPyZOtA8SVwjx2it5luUUcdjVIHdZHCoz1rWq7EM448TDmIr yTYmfaBVg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLuxn-00GxgY-Py; Mon, 15 Mar 2021 21:41:24 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLuxi-00Gxfi-15 for linux-arm-kernel@lists.infradead.org; Mon, 15 Mar 2021 21:41:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615844473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkdqntrkesd0zsgt86ODqpue66pp2ATokoiM4RMTzrY=; b=gdoLVnsOnYdrHVYByEQcVCGaT40G9kq1EbeAZlmAlUxxNiC1mOg1P6deQ1/L3CFm2OEN7/ twsSpGk3GX5oS4RcMwoKHfHfpgaT7mNExFsWgCEDrI/bPam5QNYotFGwRlfCUts7D+4ug0 FBm4RBTbgsFdAYG0+ldPgp7voc5VJao= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-Sj3oSMX9MzyFVnnvkG8hOQ-1; Mon, 15 Mar 2021 17:39:39 -0400 X-MC-Unique: Sj3oSMX9MzyFVnnvkG8hOQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C52CF87A83A; Mon, 15 Mar 2021 21:39:37 +0000 (UTC) Received: from localhost (unknown [10.10.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id A83145C3E6; Mon, 15 Mar 2021 21:39:34 +0000 (UTC) Date: Mon, 15 Mar 2021 14:39:33 -0700 (PDT) Message-Id: <20210315.143933.939938434416308507.davem@redhat.com> To: cristian.ciocaltea@gmail.com Cc: andrew@lunn.ch, kuba@kernel.org, robh+dt@kernel.org, afaerber@suse.de, mani@kernel.org, p.zabel@pengutronix.de, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver From: David Miller In-Reply-To: References: Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210315_214119_456110_73F2F082 X-CRM114-Status: UNSURE ( 9.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Cristian Ciocaltea Date: Mon, 15 Mar 2021 13:29:17 +0200 > + > +#define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK) > +static int debug = -1; > +module_param(debug, int, 0); > +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); Module parameters are strongly discouraged in networking drivers, pplease delete this ad just pass the default to netif_mdg_init(), thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel